From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id C151D4C95; Thu, 15 Nov 2018 11:49:13 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Nov 2018 02:49:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,236,1539673200"; d="scan'208";a="86662504" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.124]) ([10.237.220.124]) by fmsmga008.fm.intel.com with ESMTP; 15 Nov 2018 02:49:11 -0800 To: David Wilder , dev@dpdk.org Cc: stable@dpdk.org, pradeep@us.ibm.com, chaozhu@linux.vnet.ibm.com References: <20181114204051.9580-1-dwilder@us.ibm.com> From: "Burakov, Anatoly" Message-ID: <9db4f22f-fdce-dad4-f0fd-cf33aa0863a4@intel.com> Date: Thu, 15 Nov 2018 10:49:10 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181114204051.9580-1-dwilder@us.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] mem: Fix anonymous mapping on Power9. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Nov 2018 10:49:14 -0000 On 14-Nov-18 8:40 PM, David Wilder wrote: > Removed the use of MAP_HUGETLB for anonymous mapping on ppc64. The > MAP_HUGETLB had previously been added to workaround issues on IBM Power8 > systems when mapping /dev/zero (see: commit > 284ae3e9ff9a92575c28c858efd2c85c8de6d440). In the current code the > MAP_HUGETLB flag will cause the anonymous mapping to fail on Power9. > Note, Power8 is currently failing to correctly mmap Hugepages, with and > without this change. > > Signed-off-by: David Wilder > Reviewed-by: Pradeep Satyanarayana > --- Can't test it (obviously), but LGTM Acked-by: Anatoly Burakov -- Thanks, Anatoly