From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0079.outbound.protection.outlook.com [104.47.37.79]) by dpdk.org (Postfix) with ESMTP id 21DA71B5E6 for ; Wed, 25 Oct 2017 13:08:08 +0200 (CEST) Received: from CY4PR03CA0099.namprd03.prod.outlook.com (10.171.242.168) by CO2PR03MB2360.namprd03.prod.outlook.com (10.166.93.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.156.4; Wed, 25 Oct 2017 11:08:07 +0000 Received: from BL2FFO11OLC002.protection.gbl (2a01:111:f400:7c09::168) by CY4PR03CA0099.outlook.office365.com (2603:10b6:910:4d::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.156.4 via Frontend Transport; Wed, 25 Oct 2017 11:08:06 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11OLC002.mail.protection.outlook.com (10.173.161.186) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.156.4 via Frontend Transport; Wed, 25 Oct 2017 11:08:06 +0000 Received: from [10.232.134.49] (B35197-11.ap.freescale.net [10.232.134.49]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v9PB8157020033; Wed, 25 Oct 2017 04:08:01 -0700 To: Thomas Monjalon CC: , , , , , , , , , , , , References: <20171014221734.15511-1-akhil.goyal@nxp.com> <20171024141545.30837-1-akhil.goyal@nxp.com> <20171024141545.30837-2-akhil.goyal@nxp.com> <2031024.JVCIT9oVUT@xps> From: Akhil Goyal Message-ID: <9db8c78d-5f0d-6561-66f9-816c495cfdb0@nxp.com> Date: Wed, 25 Oct 2017 16:38:00 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <2031024.JVCIT9oVUT@xps> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131534032866065234; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(7966004)(346002)(376002)(39860400002)(39380400002)(2980300002)(1110001)(1109001)(339900001)(199003)(24454002)(189002)(83506002)(105606002)(106466001)(31686004)(8936002)(4326008)(2906002)(68736007)(54906003)(50466002)(58126008)(5890100001)(33646002)(64126003)(86362001)(8656006)(93886005)(8676002)(6916009)(15650500001)(85426001)(305945005)(31696002)(81166006)(81156014)(356003)(23676002)(76176999)(65956001)(47776003)(5660300001)(54356999)(6246003)(104016004)(65806001)(7416002)(77096006)(316002)(498600001)(65826007)(97736004)(189998001)(50986999)(53546010)(36756003)(2950100002)(229853002)(53936002)(230700001); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR03MB2360; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11OLC002; 1:AjVC60FyA9JvrCt61edyDklra0PSSVSWtSpLLbgZvMjZLBaPrM5kXgwC5UJzpB+olmq4hqR5wwAUC1GpukKvQZ6MeatqJB7FW4EbW3Lougvclzvu9pODUqZhMKxVd8XL X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 29a38cb9-b264-41cd-d9f3-08d51b98ab4f X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4628075)(201703131517081)(2017052603199); SRVR:CO2PR03MB2360; X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2360; 3:rKxUIRscIUAcNZ/fNDLSf4h/6OQxYFSK7Z32FDY3Ew2jxXdkzuduqAZwuyBE4Polx3H9YJEi8OzDpEuMdsfNQT/6V7s59M1aeMFYdD0O21txazxrhDmGUQvAzBVBZuvmlHIhq8Sk6cinHueowt8quRWu7trVF/cv6MwvQE02WBPb1ntm4N+szP4LhAIf4T6yO/KJhErfQtsobviSvn4PMc9hwChv6Q16e3NLpEvzGqkWsQVixvyijDIm8GnCBP0ALRlUHUwinwSZz6FP7VlPoIram1Mn7oYzEH055L5k6riSN/TjMw35xHkNXAKl00BxxAYzbJnzKycBIWIOV6imf8hBQp69c4fnZFlB52rFxJ0=; 25:wjAKNKWbuB/ZlZWczBTcFzvnqdjlgKwVGSlnElDFvnWL3BIVpz2yjMNQrDf0NfaoK3gPLxS1zjyS1oK41TucPAM2GKt6TEfE+jzegJsrHWakRCB75tkzoHayEDxI6/Hn9uPhGRt0JBHNL951x+Nfvz4XLgS9HYX1pRLSGH1Ze6cq/VdDDNmiEc6k4ARLkZQsct0QcTLK6VSri6w4St/9FF5d3OQb/iUFgpM96AvIzzMtw9ZxmmNAY0gVwpJrKb6inhTbs/NAG2MVOiaTThl5mos5HixMs80zK7DYaJ9JWmhIjQeD9gGaPMC2+lvrc5IHPdEfeFaJNuL1rIBW1kMsjIp4cc0gfAN7nISpn0AJ8Wo= X-MS-TrafficTypeDiagnostic: CO2PR03MB2360: X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2360; 31:h4aHTLUTUbPUn37ZKTYnnHwOfKiIFi+r3vI70KQd/Vn4JwQknEzAxx/YDpGT1UQ5u432WwA3/Q19VnkvuCk5fS9Btp/BzaWJdL5AX8Pb2jz1J2dRe5uBMX584RrjWQvEOFg1+VfYPMTcR09poTeo8OgX6XUQbzzUWwRIby3g1OB5YmJ5tJe2YVbrPKqIK73T5+1MJ3u4RwSXB24GIgWyTZqID8Q5j0ih+RZal7RAsNo=; 4:r2CLyQrCWxDwCFj43Ge4xlG4yr8vKS7xaqHHc1BCRGVMwyvol0dG98yuNI0DzsMB6tZR1ipve0FQniaJELWd6sk3096z4K0sOj/3z6rCJo4dhvN1z0+FzWdRC/H2eXuwkg5O6Jk/mdRFY53ZMvdDnRBm7PU69CqCcjeJPY69PaVsEy1/vvmUMv52ZllSXfJRX/5sI5KubXJyqkvHxk/glwyTi20QgRiUJV6o/P28vvNSyGGcbUK2dOUlOkP4r9cy/nltrJCWmAwql1O62m7ulrmzppWhJSVz8VR4Cxy8wY6fmnAUkma56TnsCGTG59OpHo2c6GXCk0fmB3cQtInLzkn+dpSVBVuyBWNnY/aZRsihJQa/A9nUPMqEXOOADXKd X-Exchange-Antispam-Report-Test: UriScan:(192374486261705)(185117386973197)(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(8121501046)(5005006)(93006095)(93001095)(100000703101)(100105400095)(3231020)(3002001)(10201501046)(6055026)(6096035)(20161123565025)(20161123563025)(20161123556025)(20161123561025)(201703131430075)(201703131433075)(201703131441075)(201703131448075)(201703161259150)(20161123559100)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CO2PR03MB2360; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CO2PR03MB2360; X-Forefront-PRVS: 0471B73328 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDTzJQUjAzTUIyMzYwOzIzOmswSE1UZnprQktYV3RuaURYSExLK0N3VDJk?= =?utf-8?B?NFNtQTMyK0thUkUyc2o5ZXBVQkhiYzBzYXg0SXQ2YXB2cnRUWmdOTG1qaGg4?= =?utf-8?B?cU0zaTNIVVdlS3JjYmZveThjRUdjTjhuNXo0SzFjdDF2MGh0S2NhTEN1czUr?= =?utf-8?B?WDBhOXNBV1VpNHJnZm5BQWZ5eTdweUp4SWNxM2U3bDgvaDRIdlhJNXM5bXBv?= =?utf-8?B?WXlTWWZkWWJ6MHFPZ0hsaG5saHF1MUpkU0xzcUhuUHduZkxSL1RuczNkZ2RN?= =?utf-8?B?NXRZVTIyK1BRdGlWUTR5dFpBbU1VTy9HczhVbExpaDJ4WWtmQ2VaY1dnL2dQ?= =?utf-8?B?VW4ySDZ5RXBLdUNZSC8vR2lpd05MWGF1SmZNT0FNejhuc2JlS1FTNlVaU0RS?= =?utf-8?B?V1o1ZTgvR3BsMmdxNytRbERLNldHUG1kTFVwY255SlRRRHQzcmNZN25ncDRM?= =?utf-8?B?RmNhbldPTW4vNTFNYTlJZkRpK0pXQ2p1aWVpU2lTQVY1NlM3VlI2NWY1M3lq?= =?utf-8?B?RWE4and1bnhveTZjdlgzem9FZnQzY1F5WmhZZ0pZVWsxem8rNnFDSldTd2du?= =?utf-8?B?VEdDUm1xSXZ5Q1EzU2I4b3krZENKd2Y5VjRGMGloL2JOSXJMbEZyTVhRNjVW?= =?utf-8?B?SUtYMHB5dDhaMXdZTGRmRVo4WndEOXM5SXZVbzNXVlpWckwyUDJiMUFTZ0N1?= =?utf-8?B?bVdlTUp4NHVyZ1VaWDNCdWtZeVNydHQ3aUJLeVdlWUVkdW54UVZzVklZbldi?= =?utf-8?B?VkQrdUptTEJQMFV4cXhXbjAyTmpScGNKSEpsRGRYOW0wb0N4cnRwSUJkV1hj?= =?utf-8?B?NXZmUmcyY1dRMTFQMkVjem0rVXVXMnRHUjU0bVc2dzdsazhycjhrR2hBeGg5?= =?utf-8?B?NGMyS1FhWlhuK0FOcklwVk9aSnBrTk96YW4rTWJvY3EyVGRYazlnVnN2RUI2?= =?utf-8?B?U0tCL2h5ZFpERUk0SXhQb2d3QUNmV3pQYmZWSzY2UGtSQ3pKM2xtNVZRVnVl?= =?utf-8?B?aElSTXNBUld2TW1ESnRjUnIzclVQeG5ZSko4eDliWDZnR3FMeHRDdXV1WXRU?= =?utf-8?B?R09BaDhpZS9VdmhsU0cwTExvK1lQM3dQSUlETG9Id3VOdy84VWpxR3hVanlK?= =?utf-8?B?c1o2ZEoyWngyVEhhTDVkSzRNWVpKak43Mkdta2IzVjhaUUt5NDk0SzZsYWoz?= =?utf-8?B?ZGk4M1JkdzFidzhjOEJ0UTlDa2tYRXlUNnZWV1krWFlmSlZ1bHZwTmQzMWhV?= =?utf-8?B?OEdtV1V3dGtXckxFbElkMlJBQWtVSHl2b2lTUjJVMU1heWIrYTdMaTZzQ2xp?= =?utf-8?B?R0N4bzVjS3pQeTFka2kzSWNFQy8vcC80amxVSWpoeDUzSml0V1RDeVJQWjJP?= =?utf-8?B?RmlpR2JUYS94ajNFbVJ4YW5KekUvQkFoUXFoZS9iT0hTRGx1YzIxeUdEZGcy?= =?utf-8?B?RGdjUmlKQVc2VlhqbGRwVkNnOWNHQm9uUTdKelkyVFB5ekkyeGE1cXJKQXRo?= =?utf-8?B?UkFZSTlFUk5mWDNQSVB4Q0lvWUpxRVhSdXlvNVRMeTJCNWpkc1Q1ZDVEanRD?= =?utf-8?B?QUhkYndzNHEzSGNKOTZuSkFJUnR3ekFCTFhuZ2dRWEd3OENnanZyRjdZc1NQ?= =?utf-8?B?YllpM08xT1crLzQzZ3l0NHZyQzl2NHRMem1WL3U3Tm10ckE4K3B0cUUwNXFI?= =?utf-8?B?b1dEQzJFZHJreGY4eWEyb1RLZ0lRcVl5WG9mNVBvS0pkRmN4QXJnOEdUMENn?= =?utf-8?B?Vkl5WEpRZUhEWHB5UmNzT3lhOGlVaFpMRlpvdkhScFlOdkt4YWVyd0ZYYkpR?= =?utf-8?B?dndUaVdzdmRQMUFyZ0luaHdLMkVQM3g4TmdYY3MyN3NzWEV2aTR5MXhBRE4z?= =?utf-8?B?dmUvdDdaZG9CQ20rWU5iVEYyaEZSakVsSURvNWhWWlpTWHo4K1hZZ2RUeXI2?= =?utf-8?B?Q3lRTitXNytWM2FlVnJUWDhtblNzaDJCeUw2YjZkMDAycndoaUZxWFIvRXVo?= =?utf-8?Q?Qd8rpI?= X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2360; 6:lMR+wSMwrO8vQ24DeFpKAtjZDKpqF2btS1yaU3/tn7BCukKOjavWanOZtACFv8+rXOSNpHmrSGeMVienmOMtfZw8PyimBAYd13aw8aEbBXCw+HVvUTtXwABS+QVQqPYcVzi6eT793bwPjMKRAENb4e0jqj3yFp5A++m4mOSkFWmCltaVU932CWvCQ94TXg8IZnsEdtdZp8O+nLC2hyQeMyurCgRDqdNX0/Ov3YvfEMLkQkHavU1tXX/u6R4XWETw8Knyzc7tNLcpKjmR7ufu6kCjNXUFVMoAjSdItnTbwPZwMVbv3kAV/x3Pbrnsc7WKnwl6kYK+HdwVilsNBAd9Sw==; 5:kMCdhczNPDwCA8HvJf05Mpr89pCr0wCoPVQf1rELq5N4BqNdoi+iwZnO2T6k2OBjMEKiYDZJmsW27pG+Mh/QlhzYP+tGFnzXUA75SW++pjI6h6S40zjaeRPHKmAl6uRZdX1+ORvpce6IkfWRbrWZ3w==; 24:E5TNbRtVaSiSW0qvnF2TacS2ljRiOuHfH2qOr/fn7VdirbwP/U78S7b9PTaf7ygyKqIl7uaIXP01bTeH8PahWnOsQOKHin1ijIgmy2OMeJ0=; 7:B/sPChb/jEdwurtKxpEBXG6mh/jfXz2NmI8b1zEeUVRXTdOvLh63ZTARf6hr94IN8y6lh+GXT5VnwUo0piv1UYoHaR9JPRSt3YAHGhh+Zg48SDk/lMLSfBCyNrvPZGpawHh07HVyV4w0p7qSbjq4UPTveGViN1D7QI2SqBFWZFMZEWKXSlLSUab8YT07zkUz5gYV0LU/dOzFtL1Rf5orzl4IkWosH1tl65JRdtJ+J2Q= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2017 11:08:06.3725 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 29a38cb9-b264-41cd-d9f3-08d51b98ab4f X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR03MB2360 Subject: Re: [dpdk-dev] [PATCH v5 01/11] lib/rte_security: add security library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2017 11:08:08 -0000 Hi Thomas, On 10/25/2017 2:17 AM, Thomas Monjalon wrote: > Hi, > > I am waiting the crypto subtree to be ready before getting this series. > > Some last comments below, > > 24/10/2017 16:15, Akhil Goyal: >> +Security API - EXPERIMENTAL >> +M: Akhil Goyal >> +M: Declan Doherty >> +F: lib/librte_security/ >> +F: doc/guides/prog_guide/rte_security.rst >> >> Networking Drivers >> ------------------ > > An additional blank line is missing. > > >> +# build flags >> +CFLAGS += -O3 >> +CFLAGS += $(WERROR_FLAGS) > > As said by Pablo, please fix the build with LDLIBS. > > >> +/** >> + * @file rte_security.h >> + * >> + * RTE Security Common Definitions >> + * >> + */ > > You should add this line: > > @b EXPERIMENTAL: this API may change without prior notice > > >> --- /dev/null >> +++ b/lib/librte_security/rte_security_version.map >> @@ -0,0 +1,13 @@ >> +DPDK_17.11 { > > The name of this block should be EXPERIMENTAL > >> + global: >> + >> + rte_security_attach_session; >> + rte_security_capabilities_get; >> + rte_security_capability_get; >> + rte_security_session_create; >> + rte_security_session_destroy; >> + rte_security_session_stats_get; >> + rte_security_session_update; >> + rte_security_set_pkt_metadata; >> + >> +}; > > I think you need this line: > local: *; > > Will Correct all this in v6. Thanks, Akhil