From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id D1C3ADE0
 for <dev@dpdk.org>; Mon, 23 Oct 2017 18:31:35 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by orsmga105.jf.intel.com with ESMTP; 23 Oct 2017 09:31:32 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.43,423,1503385200"; d="scan'208";a="1234196397"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.136])
 ([10.241.225.136])
 by fmsmga002.fm.intel.com with ESMTP; 23 Oct 2017 09:31:32 -0700
To: Jasvinder Singh <jasvinder.singh@intel.com>, dev@dpdk.org
Cc: cristian.dumitrescu@intel.com, john.mcnamara@intel.com
References: <20171023103600.89883-1-jasvinder.singh@intel.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <9dc9d7ef-f238-08cc-c970-819419185d90@intel.com>
Date: Mon, 23 Oct 2017 09:31:32 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171023103600.89883-1-jasvinder.singh@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] examples/qos_sched: fix uninitialized scalar
 variable
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Oct 2017 16:31:36 -0000

On 10/23/2017 3:36 AM, Jasvinder Singh wrote:
> Fix problem with uninitialized rx/tx deferred_start flags of the struct
> rte_eth_rxconf/txconf by initializing with 0 value (deferred start of
> the rx/tx queues is turned off). This setting allows device rx/tx
> queues to start with rte_eth_dev_start().
> 
> CID 194999 (#1 of 1): Uninitialized scalar variable (UNINIT)
> CID 195009 (#1 of 1): Uninitialized scalar variable (UNINIT)

Is this Coverity ID? If so we have a defined format for it:

    Coverity issue: xxxxxx
    Fixes: yyyyyyyyyyyy ("..................")
    Cc: stable@dpdk.org [if required]

    Signed-off-by: .....

Thanks,
ferruh

> 
> Fixes: de3cfa2c9823 ("sched: initial import")
> 
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> ---
>  examples/qos_sched/init.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/examples/qos_sched/init.c b/examples/qos_sched/init.c
> index 004ac54..038f042 100644
> --- a/examples/qos_sched/init.c
> +++ b/examples/qos_sched/init.c
> @@ -118,6 +118,7 @@ app_init_port(uint16_t portid, struct rte_mempool *mp)
>  	rx_conf.rx_thresh.wthresh = rx_thresh.wthresh;
>  	rx_conf.rx_free_thresh = 32;
>  	rx_conf.rx_drop_en = 0;
> +	rx_conf.rx_deferred_start = 0;
>  
>  	tx_conf.tx_thresh.pthresh = tx_thresh.pthresh;
>  	tx_conf.tx_thresh.hthresh = tx_thresh.hthresh;
> @@ -125,6 +126,7 @@ app_init_port(uint16_t portid, struct rte_mempool *mp)
>  	tx_conf.tx_free_thresh = 0;
>  	tx_conf.tx_rs_thresh = 0;
>  	tx_conf.txq_flags = ETH_TXQ_FLAGS_NOMULTSEGS | ETH_TXQ_FLAGS_NOOFFLOADS;
> +	tx_conf.tx_deferred_start = 0;
>  
>  	/* init port */
>  	RTE_LOG(INFO, APP, "Initializing port %"PRIu16"... ", portid);
>