From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7791E45822; Tue, 20 Aug 2024 10:31:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5D21A4026C; Tue, 20 Aug 2024 10:31:28 +0200 (CEST) Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by mails.dpdk.org (Postfix) with ESMTP id 1D1B2400D6 for ; Tue, 20 Aug 2024 10:31:26 +0200 (CEST) Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5bed72ff443so4331632a12.1 for ; Tue, 20 Aug 2024 01:31:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1724142686; x=1724747486; darn=dpdk.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9PZAZD9lcUW8t6VBbxmmoiPzvMwalgcj0JnWlffQPUc=; b=pj0axVItklipn2HxOxd13w+qQN7IPgeDI07gXKbbLfVYYSuSwP8M4CSyHtxKEKr8/3 8FEh/rVgO4SQnEWBN4U+kbgvq1NxPg6ozklXqv0UOkdGGCPGU4NUC4F6yvDOZ2hGIGfp UgeKqKiwwCre1taSk8db4ipmWE1AJ+SOMAGMjlZDZV6q1klwmOhCaFQrW0gcyt7Nni1G 5n9lQNrD45meP1r7vjxsNCGABlW4CYuLmmwgMPUEbeSnfkLb4BDTBTxFifU147+NV+Fo hcnMsHnqj3i2mAXSLYCSb4+w6gtiyriIkmfjFam2vk74SYg7B8cANYWDwMk2JS6tzqvK BRLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724142686; x=1724747486; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9PZAZD9lcUW8t6VBbxmmoiPzvMwalgcj0JnWlffQPUc=; b=MPKq4rej+7LjkX2pvNKJJdr/qe5n6YBcW7oVtB458CjZGrJFlBkG+atQJNGV0b4CWB FdNpYINt/EyNyjq4NB7ie8AIoQk5oCyp68bTQ4Q3Fg6JwcVl9G9GUxXC8O9lDm3WOiwx /pM2g7MTdiNSOSxaRX0gDm+mt3zLhaJdP+OSTn3rbiO2AtqLF73GwssBFJFeco9HCphe q1VjXbd0RRoVNzcuYD5jQWw/86G+Qy6D/2MTsMSRq0PgeRBTgRa24Rqc/qisOL2GN/yi gkuJdcjKY6o4012QEor+6t9R1pSy7/oqFSvShXmDUn/G4DxV46gViZCiZbyLYl/SJ2Hn wlqQ== X-Forwarded-Encrypted: i=1; AJvYcCXWqevvszxNEvqjLkJEXtF5AZupRRA/4phaTdSOSQYswVkCFN32jw9UpQCk3DdTUSXgk1s=@dpdk.org X-Gm-Message-State: AOJu0Yz85mLcBUcVDHtot1KF0r6z2TfWYFateu7rGblviXvoSZgcbHAw 3GROBNOrnB2z9ffIa3a+gVBDSzQFrvTByMWCV3IKL0SIqWNNwurOpWm7cL8OLWM= X-Google-Smtp-Source: AGHT+IE4Egp121+C3jtG8Zw2aEzYtHXmMp7jShSOaM2LHcLKZCBoHKkDKF3B1OzEeRhKItl5jziawA== X-Received: by 2002:a05:6402:358d:b0:5be:ea9c:5fe7 with SMTP id 4fb4d7f45d1cf-5beea9c6316mr5678254a12.16.1724142685499; Tue, 20 Aug 2024 01:31:25 -0700 (PDT) Received: from [10.12.0.236] (81.89.53.154.host.vnet.sk. [81.89.53.154]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5bebbde5a83sm6552492a12.36.2024.08.20.01.31.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Aug 2024 01:31:25 -0700 (PDT) Message-ID: <9de4f267-36f6-4da9-a09f-c5318a110822@pantheon.tech> Date: Tue, 20 Aug 2024 10:31:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v17 5/5] dts: add API doc generation To: Dean Marx Cc: thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, bruce.richardson@intel.com, jspewock@iol.unh.edu, probb@iol.unh.edu, paul.szczepanek@arm.com, Luca.Vizzarro@arm.com, npratte@iol.unh.edu, dev@dpdk.org References: <20231115133606.42081-1-juraj.linkes@pantheon.tech> <20240814150535.239547-1-juraj.linkes@pantheon.tech> <20240814150535.239547-6-juraj.linkes@pantheon.tech> Content-Language: en-US From: =?UTF-8?Q?Juraj_Linke=C5=A1?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 19. 8. 2024 19:53, Dean Marx wrote: > On Mon, Aug 19, 2024 at 10:37 AM Dean Marx > wrote: > > I ran into some dependency issues while testing that I figured I'd > mention here. My build failed while running meson setup with the > -Denable_docs=true option since I didn't have the sphinx-build > module installed, This one is on your end, sphinx is a dependency that must be installed. > then my compilation failed while running ninja -C > because I didn't have a package called tomli installed. I ran a > final time where compilation failed again because my system couldn't > find the yaml package. This, on the other hand, isn't. The build should work without non-sphinx dependencies. I'll address these two in the next version. Thanks for catching this. > It seems like nobody else ran into this so > I'm a little confused if it's something on my end, but I tried > running the optional poetry install --with docs mentioned in the > cover letter and that didn't seem to work either. I was also able to > build and compile without -Denable_docs. Thought I'd bring it up > because compilation takes a fairly long time, and if a user runs > into this I could see it being frustrating. > > Reviewed-by: Dean Marx > > > > Just worked this out with Jeremy, I was running the poetry install > --with docs in the DPDK directory instead of the DTS subdirectory. > However, while that fixes almost everything, the yaml module is never > imported Does this happen after running poetry install? Pyyaml is in poetry dependencies, so this shouldn't be a problem. But in any case, both builds (either with -Denable_docs=true or with the ninja build target ("doc")) should work without installing DTS runtime dependencies (the doc build dependencies are still needed). I'm going to try building in a fresh environment to test this more thoroughly. > and was throwing errors for me until I installed pyyaml > manually, so this might have been missed in the dependency list