From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF540A328D for ; Tue, 22 Oct 2019 09:04:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 622E74C74; Tue, 22 Oct 2019 09:04:05 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 6C66E44C7 for ; Tue, 22 Oct 2019 09:04:03 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 0F390780071; Tue, 22 Oct 2019 07:04:02 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 22 Oct 2019 08:03:55 +0100 To: Ciara Power , , , , CC: References: <20191021122238.58852-1-ciara.power@intel.com> <20191021122238.58852-2-ciara.power@intel.com> From: Andrew Rybchenko Message-ID: <9dedc804-c3c4-768e-f907-7c4868fcde05@solarflare.com> Date: Tue, 22 Oct 2019 10:03:52 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191021122238.58852-2-ciara.power@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24994.003 X-TM-AS-Result: No-0.839100-8.000000-10 X-TMASE-MatchedRID: zGP2F0O7j/u8rRvefcjeTfZvT2zYoYOwC/ExpXrHizzHoLp1yJ83GNLt JpTFd0Iya8dzyZlF6/Uv299lGYEvfjzCn0Lg6DUsdhnFihmbnwXImecPUV56jsj0QMA/92m2WOW LMlqL93uHO5R18UiQLOU+TkP/ENmGsKdz/6U+6KmqNnzrkU+2mtGOcAfHKa6uIFWQH/JudNj+ez fog1uF08W9Hv1VMZJ6kZOl7WKIImrvXOvQVlExsFw7rmOs2WXz2bNx1HEv7HAqtq5d3cxkNc7+d HPzMYRhDnDe/OVy7Ds3QWlEuriwtjyJYhQkmYM59c7dwYu2U3ZS9CGjA3RyH+R/Hd+8dJtol6Cp /cTv5NevcXFRNYT2pNyS5IITWzgwBsRAh8WmTAcG2WAWHb2qekrMHC7kmmSWJy4DmWREnADvdCU IFuasqw== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10-0.839100-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24994.003 X-MDID: 1571727842-c32Q4lYqCZPk Subject: Re: [dpdk-dev] [PATCH v2 1/2] ethdev: add check for device promiscuous state X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/21/19 3:22 PM, Ciara Power wrote: > The promiscuous enable and disable functions now check the > promiscuous state of the device before checking if the dev_ops > function exists for the device. > > This change is necessary to allow sample applications run on > virtual PMDs, as previously -ENOTSUP returned when the promiscuous > enable function was called. This caused the sample application to > fail unnecessarily. > > Signed-off-by: Ciara Power Many thanks, Reviewed-by: Andrew Rybchenko