From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0055.outbound.protection.outlook.com [104.47.42.55]) by dpdk.org (Postfix) with ESMTP id 0783456AB for ; Thu, 29 Sep 2016 16:35:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=zwZmlujGwL13//aakT9KifPxmV822pve2NqfZzYqVLE=; b=k9Rhm74onbutXQdUVZk2fDPaQ27icDEzqcV1iCL2cTiINFE5Vea50Pjr7yyVLiSOGR5bjLEtbAgfW7qWrp3OWrQnd5wDjytFdkvin03MbXSPZ0pVLiH71OMmmo+ai1nokWeRQr+GMZY5KbPk1QczrxMt+kiE1AiBsnFIxkfkASY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Maciej.Czekaj@cavium.com; Received: from [10.0.0.58] (31.172.191.173) by BN6PR07MB2883.namprd07.prod.outlook.com (10.173.28.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.639.5; Thu, 29 Sep 2016 14:35:39 +0000 To: Ferruh Yigit , Kamil Rytarowski , References: <1472230448-17490-1-git-send-email-krytarowski@caviumnetworks.com> <1472230448-17490-8-git-send-email-krytarowski@caviumnetworks.com> <30b54539-0ccf-65b3-c158-3f55a40a274b@intel.com> CC: , , , , Kamil Rytarowski From: Maciej Czekaj Message-ID: <9e05e879-5b3a-e2c9-328d-ed19300bc93d@caviumnetworks.com> Date: Thu, 29 Sep 2016 16:35:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <30b54539-0ccf-65b3-c158-3f55a40a274b@intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [31.172.191.173] X-ClientProxiedBy: AM3PR04CA0116.eurprd04.prod.outlook.com (10.163.180.170) To BN6PR07MB2883.namprd07.prod.outlook.com (10.173.28.141) X-MS-Office365-Filtering-Correlation-Id: 4153bd71-e71a-404f-9b7b-08d3e875e30d X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB2883; 2:nl7UGrHnd2EgOT4v1t8YfQhyIOVUKA47pREywZWAIjo01AQ3g9SPArhA46Ry+d+ejYqgylQ8MEhpPby2+CTyE+XO+Y+AAYIRExtDRLPthqbC0sefAdMFG9LAX/ikzNpQ5sKGnefVjztZzNaBu6pu3wX/yAa2JAt1tkhhULSe/Vra4w6O/O+JEBYMuP4MLtU7; 3:N3hqTzvgHCTzmW/UX6oNS/bl05bRDtBQllgoYDblSptAZ0u/F+wdqIx8Bvrp9QNuTs5WT268tTiOUu74TEgXIHv+Dus65zksucRrBTt+sf7yLG/+wmBKbgRlO5NyHk+6; 25:T7d2sdfHty7gMa3JOb7YfmRyYJcESxQLwqc8u9zXtTC6okCIxeVbX3hx5j7YkQmpOZo7nA55wS0uDuqBmb1edFBr3nHlmrlAjezCjzkqB7UGt3hN/5tVI4C+jVbqY6GsXcuv/PEbu2ZC+K36/SdoPbUdPJALU+cfQNBKn9gIV2vM/PweVwerl+wQ+c4XglITC+IhiJLlodJv43jjGHTTOEgVJH0492kQbLI5Ihel2UWl7YJG2OwhRztICR7lQf2ksSqdIMyRGjDu1twr2lLDI4WQIKIHSO9p+KcrHeFGX4LhNtU2+zABMm076HS47/lLuwHZud8c+qa+UOGs0nzjFVfJoppdnptkpoovcwRqTEn7RSgmgcwLhEft43wPEREXTPPq75HsOoqJ85DO9b9CopPWXaog5pv/OthSYY0yvTw= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN6PR07MB2883; X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB2883; 31:PwJ4DpSyrmBFQmF7d9+WzXhqcyAdiBeMoXNl4j7MZunwNxYSUOhixP8XIv4guWdwXtz9q8oYkRdkFH1KS3mSxy6/3EtmGh2DSSWUubB0GEH1pd55vuPaNngcTlYtHK+/19ZuAN5cnT6Dm4mxwtKYfz74QR+2Sltcc+/ga29BucwcN3oHz6KspcgmwlBqCPCDYAijlG212yDHamhYWjeLyzW+rTHNagcMT3QTK1N7YdU=; 20:6XB4EPJ9rEDRJEtw/oxYN//tsTwF2jebDp2E3Gz6H2doMCPaTjZnPEvZ7/fXujlWBhjaBW9MXubLbWbqY/UwPcX0NFefaMv9qO7RC5XePyxkOCkjd92GVhvw+fziqziJF7oZRM05vwHQshrMbL3gTOH1GzOIYSj9nQDGX0JtRc1wUNVdyiii8Baj5BNMfKdyuSfyjhpF29/ouk9jODVYqWScrj4y0Tkd9mMpdxpIRCBytcp/oiWr2STMAu1lV7wuib+3+bWjP58jhHB7a8nB9cExMCgm9ssQ+31aV4lOqVMTx9A+8lZ8ye/vEKlsxIGl1l2AqQesRMloWJaM9JdSPwb+mhyf00FM1YSlXAqZxcZ9qNR81L8VqxgM56MnsVpNisClIaRY8GnIEHa/j02TCgSrYfS9nLfnOe3APsL1TUR++SH37cA/zbCd7yeU8YZKHyAv0mbnQHrq4XNKhVd8xKSriwbLjCsfcMoTCyZqJhC3CJgOQzMRzZqeSEbSmqi1P79x/bvxTYJpCZPxf5YIM56kQqtM3yELaxzalEFbNrVDnPETW+bK9s9wXDqXEeCrFyiRAKFfuvPTa2j6dPB1lDHRlC0/qEYbh8u+gKU0ATE= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001); SRVR:BN6PR07MB2883; BCL:0; PCL:0; RULEID:; SRVR:BN6PR07MB2883; X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB2883; 4:w03qC7qSlEtkbgNpWTEFnp5oYYgTU/+64KTpuUH7VTfwu0fNytbitP9Tyiev/lsidlpQNk8Wse6QHyOy/Cq8VCl004QkK7ZmVSFWuyZuu1K8v7hSPNDIe0vMWlt2TNctL8PCJ7HRAjcAsEjSi/5mc2Pj/Uc1SSVwvakK540aBz5e58TIidqcfj+H7mQ8tR/xi3i5FHGe7fhHBRtRFxJ3WjbSiBuvJd/tkwcMWFrUgAiiqC+KYf9zgRnv/f+605PrH7VjcgeK3ezCa4yHLOAtU1xEwdbQt4Ozo/DyRJwmEhMYkJvkjg2+ZjeLwI6QUkFR0vXO3GRofnhKcv82oG1w9NLrn9fLYDWrbx9XNp99R8qlI1kh3FZZSeQTetHRmI8upA7BAw6Tm/W/G3SsvnuPrw== X-Forefront-PRVS: 00808B16F3 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6049001)(6009001)(7916002)(189002)(24454002)(377454003)(199003)(3846002)(50466002)(586003)(6116002)(101416001)(81156014)(77096005)(8676002)(6666003)(81166006)(64126003)(23746002)(33646002)(36756003)(65956001)(7736002)(230700001)(92566002)(47776003)(66066001)(4001430100002)(305945005)(7846002)(50986999)(65806001)(76176999)(54356999)(5001770100001)(83506001)(97736004)(106356001)(5660300001)(42882006)(42186005)(31686004)(2950100002)(65826007)(2906002)(19580395003)(68736007)(19580405001)(107886002)(4326007)(105586002)(31696002)(4001350100001)(189998001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR07MB2883; H:[10.0.0.58]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BN6PR07MB2883; 23:gFQ6GBqx0N7NadIgMllKbaetpleQaAHXUJkir?= =?Windows-1252?Q?g9RE+eGa6/16/nyVzoZbJtRHNcvJP3QJ+8zDrxY/A4G45Dmiuef4E0KI?= =?Windows-1252?Q?KMRvcHiSFqg6QG3+Z8dYhMw7Ap8ELDRv+z/jCFGE97ICfIcFYSvxnlL5?= =?Windows-1252?Q?/G34TATG1t4kLwdRDdC1hEKV4WRnww+ijcA3Slg/QgNeZvCZ03ijc+n2?= =?Windows-1252?Q?2NdksqzyImuwISRjsJrHv+qg1xNrtok0OHH7sfTlkaVB6dU65n8yjw7m?= =?Windows-1252?Q?BftROqNgmkzBS7KWr4lGO3ifAVvgn5V+LZTyKxn/CS/96G8E8TavAt7F?= =?Windows-1252?Q?zdXc7m4UTN0lMi4VJpglTrME2zLTbCOsomtU9iDZdwOSH+JcGvPEUh8X?= =?Windows-1252?Q?oLorK/HiNmqtEfSCUyuMbsDoaDmbM1o2dKMC9kdO1bSPzInO2gjHw1AZ?= =?Windows-1252?Q?QVd/we4OBJRoLc4T7Ao9Y4vyvv4VeKmMiaF4jRUrXXwmR0L7ueXoK1iD?= =?Windows-1252?Q?+ti/pRpY0z8A4Fj2hJ4bVN/wDNFEX4SEXKQTWsUpR9Vyv5WTcYqk9oej?= =?Windows-1252?Q?iuapgRiKCoDQVCxv9v9EaGlQ10ckI34VV+0wVj5+yqm//GgxTb+0UFqH?= =?Windows-1252?Q?PbqwXznmA2trTiiJWIhOAewidaR8xSUDWjCCw+r9XBBg7vWYSnDjUaoM?= =?Windows-1252?Q?PMJPe9St+78m455rciwzplg+a2mjYvqJU+pKONlxkPcRD2H+fDsH7VRW?= =?Windows-1252?Q?KUUJ+MCf9PAn1EUOjDkIEC09JdI8cPh7OHXS9AeI/B+piTONQQjRLdcS?= =?Windows-1252?Q?iX4hpkgYBgSmoK5Q5CcDmcLUabo/cI6Dw4Gy6at0w1jnB2ur15PBSamh?= =?Windows-1252?Q?JElgKYkY/0AYdeMfaX223wusPTqacRrdoPcY5UBZx/rwlsfrda+UQfn7?= =?Windows-1252?Q?2oy+2TeUYHT+dz9YLDKXU9UZny6Ec5T568cgr/RugWr3L3vo/DOaJhU7?= =?Windows-1252?Q?6o5MaZVIJPin66+zb9TP+wwi2Tt4Suq3wybcANL6K25ccnL+IgyZoVRO?= =?Windows-1252?Q?uuW+m15ZLLVjPiV1CHOJbUo5UFpUsQpUpVEpHYGJvo7bAE4YlI72MQ5q?= =?Windows-1252?Q?Z6ra9P81VCePcHXuyTCrSpnSQayu/qLnDMlbNIBD0R5dNv5wLPR9MP58?= =?Windows-1252?Q?+G/hJD55AKl/kDGURKjNmZBkBLjENcOqevuEOPBqg74ZJ0OSyqSCEp7S?= =?Windows-1252?Q?EUqCyxv+B37sESnpjazN/114G1yTSAzpxs9Klc9i0M8Zb6cTsqwnyreW?= =?Windows-1252?Q?U7wL7pA0+YXGl57JvALpULBQTEIlR5aUOlE9bR4c4RObsjo2KPq3ubsk?= =?Windows-1252?Q?Qd1S6TmAbKS3VUYWCoBtHk23tJMzgOEKAmziPcNBklNRH2lT4FQvYjn2?= =?Windows-1252?Q?jmDatUQec6k3aZtGhXGnasI+egRlx7cjJex/3M1T782SO8xasTPtbDAW?= =?Windows-1252?Q?EQvTgE=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB2883; 6:wR5OfCI7acL1S/90cBJVbRK6s+uPZmELyez6kSGof5CaN36wsiudibyU+29GlDF9OzYYEPD2a/EGr0qj3Pild3EXkww3ivogD0sqmygEqAqAODK54W7vfPYhwoGuXcicADnHJCrXLSrZiYNwjTpneZbIsuyMnHiX2dCOaUsNqBEEGaNv7nPgPzavbGx6iE/WmAOeJRsHG3n/UfjbkH95MKsh8Ve9dOYjOrLrpF5iWQWyVDSZfnUnGFt1qNYXkWJ3nPa6kUB7432B4lbnEJfXWM0KvFc63c/R9GS2zdib4bQ=; 5:5/Mp2evZcyI9TIaNDiLdWlU+MSC3zfwKarFFtb576lU8sB6p5ubRw4kdCltNruFRjqjkhVUzEvX91H0efZAVRAynHtDKgk7ELEl6opmy9gNYjFizhqcdmRGQVWezeWxcCOKSoWTXoakqXhwb4RhkRQ==; 24:KgxwYzgtspHq1+4bx04Mbp/g/SeVOqlEObxJh0jUWrbI7ZeqtmVrBZno/ns9vVY6IQwg91HXFmTB2KhopB5TPuamOgvd3mV5nFLFMRIMbwo=; 7:Gg78CzjLzyTlqNoUTP9EAcDW0FcsuCqSBFAuWqEMrjAtpDdqTozYqTH+4v8Qfh8zEptkUVKiVSX/PRcdhrxdWUIOSwo5h0CfX3O/xOu+0w+c00p276sA2F4+pszTt/CRD70oEh2vi+tZ1wGcDZIwiLspsuMugRciCKT8nN2DwuCjSSso3Czf06uKHnli52rzug3FAsMmCcnO0ZbU4xxhimHPyrJHBBPUg5QvkX3HVMgq7d4q03iz/6kKGVPEm4ciH9jsKV4zCeh92gextz/3QzUx1iqXJgXLQXUiAP5uQ4iQzFFBnOIlbawhoExGKfEx SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2016 14:35:39.5919 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR07MB2883 Subject: Re: [dpdk-dev] [PATCH 07/13] net/thunderx: fix multiprocess support in stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Sep 2016 14:35:44 -0000 > On 8/26/2016 5:54 PM, Kamil Rytarowski wrote: >> From: Kamil Rytarowski >> >> In case of the multiprocess mode a shared nicvf struct between processes >> cannot point with the eth_dev pointer to master device, therefore remove it >> allong with references to it refactoring the code where needed. > > Patch subject says fix multiprocess support in stat, but it seems doing > more than just for stats fix. > > Overall eliminates private_data->eht_dev link. > > I guess this is because eth_dev->data is shared for primary and > secondary processes, and this makes impossible to use separate > private_data for primary and secondaries. > > So this patch looks like keeping separate copy of private_data (nic) and > using eth_dev and nic structs for functions instead of using > eth_dev->data->private_data. > > If above correct, can you please updated patch subject? > > Also another approach can be allocating "data" independently and > overwrite eth_dev->data with this per each process, this also makes > eth_dev->data->private_data usable for each process. > >> >> Fixes: 7413feee662d ("net/thunderx: add device start/stop and close") >> >> Signed-off-by: Maciej Czekaj >> Signed-off-by: Kamil Rytarowski >> Signed-off-by: Zyta Szpak >> Signed-off-by: Slawomir Rosek >> Signed-off-by: Radoslaw Biernacki >> Signed-off-by: Jerin Jacob >> --- > > > Yes, this patch enables multi-process support for primary and secondary functions by eliminating the pointer from private struct to eth_dev. Will extend the comment in v2.