From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 1517058FE for ; Wed, 25 Apr 2018 12:45:06 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Apr 2018 03:45:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,326,1520924400"; d="scan'208";a="36306063" Received: from rhorton-mobl1.ger.corp.intel.com (HELO [163.33.230.83]) ([163.33.230.83]) by orsmga008.jf.intel.com with ESMTP; 25 Apr 2018 03:45:04 -0700 To: Thomas Monjalon References: <20180328135433.20203-1-declan.doherty@intel.com> <1794949.DGStqB9iLD@xps> <76bc7493-f8cf-0d74-961c-800665744ebe@intel.com> <3613685.kkaEeRXftQ@xps> Cc: Declan Doherty , dev@dpdk.org, Adrien Mazarguil , Ferruh Yigit , Shahaf Shuler From: Remy Horton Organization: Intel Shannon Limited Message-ID: <9e515f40-759c-1d98-5fcc-6e2628484879@intel.com> Date: Wed, 25 Apr 2018 11:45:03 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <3613685.kkaEeRXftQ@xps> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v7 6/9] ethdev: add common devargs parser X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 10:45:07 -0000 On 25/04/2018 11:06, Thomas Monjalon wrote: > 25/04/2018 11:40, Remy Horton: >> >> On 24/04/2018 20:53, Thomas Monjalon wrote: [..] > OK > Please can you add it as a comment in the parsing code? > > We will need one or two examples in the commit message too. Docs are being updated, so it should be in the v8 patchset.