From: Paul Szczepanek <paul.szczepanek@arm.com>
To: "Morten Brørup" <mb@smartsharesystems.com>,
dev@dpdk.org, "Frank Du" <frank.du@intel.com>
Cc: nd@arm.com, Ferruh Yigit <ferruh.yigit@amd.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
"Loftus, Ciara" <ciara.loftus@intel.com>
Subject: Re: [PATCH v12 2/6] mempool: add functions to get extra mempool info
Date: Wed, 29 May 2024 17:18:14 +0100 [thread overview]
Message-ID: <9e668808-f76e-4ea0-8147-8df1efb102f2@arm.com> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F4CA@smartserver.smartshare.dk>
On 29/05/2024 14:56, Morten Brørup wrote:
>> From: Paul Szczepanek [mailto:paul.szczepanek@arm.com]
>> Sent: Wednesday, 29 May 2024 12.23
>>
>> Add two functions:
>> - rte_mempool_get_mem_range - get virtual memory range
>> of the objects in the mempool,
>> - rte_mempool_get_obj_alignment - get alignment of
>> objects in the mempool.
>>
>> Add two tests that test these new functions.
>>
>> Signed-off-by: Paul Szczepanek <paul.szczepanek@arm.com>
>> Reviewed-by: Jack Bond-Preston <jack.bond-preston@foss.arm.com>
>> Reviewed-by: Nathan Brown <nathan.brown@arm.com>
>> ---
>>
>> +/**
>> + * @warning
>> + * @b EXPERIMENTAL: this API may change without prior notice.
>> + *
>> + * Get information about the memory range used by the mempool.
>> + *
>> + * @param[in] mp
>> + * Pointer to an initialized mempool.
>> + * @param[out] mem_range_start
>> + * Returns lowest address in mempool.
>> + * @param[out] mem_range_length
>> + * Returns the length of the memory range containing all the addresses
>> + * in the memory pool.
>> + * @return
>> + * 0 on success, -EINVAL if arguments are not valid.
>> + *
>> + **/
>> +__rte_experimental
>> +int rte_mempool_get_mem_range(struct rte_mempool *mp,
>> + void **mem_range_start, size_t *mem_range_length);
>
> Paul,
>
> Could you please add one more output parameter "bool *mem_range_contiguous" to this function, returning true if the memory chunks are contiguous.
>
> It will be useful instead of implementing get_memhdr_info() locally in this other patch series:
> https://inbox.dpdk.org/dev/MW4PR11MB58724AC82A34A3EEFEF78E898EF22@MW4PR11MB5872.namprd11.prod.outlook.com/
>
> Please coordinate this change directly with Frank Du <frank.du@intel.com>.
>
> -Morten
>
Does this work for you?
int rte_mempool_get_mem_range(struct rte_mempool *mp,
void **mem_range_start, size_t *mem_range_length,
bool *contiguous)
{
if (mp == NULL)
return -EINVAL;
void *address_low = (void *)UINTPTR_MAX;
void *address_high = 0;
size_t address_diff = 0;
size_t mem_total_size = 0;
struct rte_mempool_memhdr *hdr;
/* go through memory chunks and find the lowest and highest addresses */
STAILQ_FOREACH(hdr, &mp->mem_list, next) {
if (address_low > hdr->addr)
address_low = hdr->addr;
if (address_high < RTE_PTR_ADD(hdr->addr, hdr->len))
address_high = RTE_PTR_ADD(hdr->addr, hdr->len);
mem_total_size += hdr->len;
}
/* check if mempool was not populated yet (no memory chunks) */
if (address_low == (void *)UINTPTR_MAX)
return -EINVAL;
address_diff = (size_t)RTE_PTR_DIFF(address_high, address_low);
if (mem_range_start != NULL)
*mem_range_start = address_low;
if (mem_range_length != NULL)
*mem_range_length = address_diff;
if (contiguous != NULL)
*contiguous = (mem_total_size == address_diff) ? true : false;
return 0;
}
next prev parent reply other threads:[~2024-05-29 16:18 UTC|newest]
Thread overview: 141+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 15:08 [RFC 0/2] add pointer compression API Paul Szczepanek
2023-09-27 15:08 ` [RFC 1/2] eal: add pointer compression functions Paul Szczepanek
2023-10-09 15:54 ` Thomas Monjalon
2023-10-11 13:36 ` Honnappa Nagarahalli
2023-10-11 16:43 ` Paul Szczepanek
2023-10-11 12:43 ` [RFC v2 0/2] add pointer compression API Paul Szczepanek
2023-10-11 12:43 ` [RFC v2 1/2] eal: add pointer compression functions Paul Szczepanek
2023-10-11 12:43 ` [RFC v2 2/2] test: add pointer compress tests to ring perf test Paul Szczepanek
2023-10-31 18:10 ` [PATCH v3 0/3] add pointer compression API Paul Szczepanek
2023-10-31 18:10 ` [PATCH v3 1/3] eal: add pointer compression functions Paul Szczepanek
2023-10-31 18:10 ` [PATCH v3 2/3] test: add pointer compress tests to ring perf test Paul Szczepanek
2023-10-31 18:10 ` [PATCH v3 3/3] docs: add pointer compression to the EAL guide Paul Szczepanek
2023-11-01 7:42 ` [PATCH v3 0/3] add pointer compression API Morten Brørup
2023-11-01 12:52 ` Paul Szczepanek
2023-11-01 12:46 ` [PATCH v4 0/4] " Paul Szczepanek
2023-11-01 12:46 ` [PATCH v4 1/4] eal: add pointer compression functions Paul Szczepanek
2023-11-01 12:46 ` [PATCH v4 2/4] test: add pointer compress tests to ring perf test Paul Szczepanek
2023-11-01 12:46 ` [PATCH v4 3/4] docs: add pointer compression to the EAL guide Paul Szczepanek
2023-11-01 12:46 ` [PATCH v4 4/4] test: add unit test for ptr compression Paul Szczepanek
2023-11-01 18:12 ` [PATCH v5 0/4] add pointer compression API Paul Szczepanek
2023-11-01 18:12 ` [PATCH v5 1/4] eal: add pointer compression functions Paul Szczepanek
2024-02-11 15:32 ` Konstantin Ananyev
2023-11-01 18:12 ` [PATCH v5 2/4] test: add pointer compress tests to ring perf test Paul Szczepanek
2023-11-01 18:13 ` [PATCH v5 3/4] docs: add pointer compression to the EAL guide Paul Szczepanek
2023-11-01 18:13 ` [PATCH v5 4/4] test: add unit test for ptr compression Paul Szczepanek
2024-02-22 8:15 ` [PATCH v5 0/4] add pointer compression API Paul Szczepanek
2024-02-22 16:16 ` Konstantin Ananyev
2024-03-01 11:16 ` Morten Brørup
2024-03-01 16:12 ` Patrick Robb
2024-03-01 19:57 ` Honnappa Nagarahalli
2024-03-02 10:33 ` Morten Brørup
2024-03-06 22:31 ` Paul Szczepanek
2024-03-07 2:13 ` Honnappa Nagarahalli
2024-03-04 14:44 ` Konstantin Ananyev
2024-05-15 17:00 ` Paul Szczepanek
2024-05-15 22:34 ` Morten Brørup
2024-05-16 8:25 ` Paul Szczepanek
2024-05-16 8:40 ` Konstantin Ananyev
2024-05-24 8:33 ` Paul Szczepanek
2024-05-24 9:09 ` Konstantin Ananyev
2024-05-28 19:29 ` Paul Szczepanek
2024-05-29 10:28 ` Paul Szczepanek
2024-06-06 13:33 ` Konstantin Ananyev
2024-02-29 16:03 ` [PATCH v6 " Paul Szczepanek
2024-02-29 16:03 ` [PATCH v6 1/4] eal: add pointer compression functions Paul Szczepanek
2024-02-29 16:03 ` [PATCH v6 2/4] test: add pointer compress tests to ring perf test Paul Szczepanek
2024-02-29 16:03 ` [PATCH v6 3/4] docs: add pointer compression to the EAL guide Paul Szczepanek
2024-02-29 16:03 ` [PATCH v6 4/4] test: add unit test for ptr compression Paul Szczepanek
2024-03-01 10:21 ` [PATCH v7 0/4] add pointer compression API Paul Szczepanek
2024-03-01 10:21 ` [PATCH v7 1/4] eal: add pointer compression functions Paul Szczepanek
2024-03-07 11:22 ` David Marchand
2024-03-01 10:21 ` [PATCH v7 2/4] test: add pointer compress tests to ring perf test Paul Szczepanek
2024-03-07 11:27 ` David Marchand
2024-03-01 10:21 ` [PATCH v7 3/4] docs: add pointer compression to the EAL guide Paul Szczepanek
2024-03-01 10:21 ` [PATCH v7 4/4] test: add unit test for ptr compression Paul Szczepanek
2024-03-07 11:30 ` David Marchand
2024-03-07 20:39 ` [PATCH v7 0/4] add pointer compression API Paul Szczepanek
2024-03-07 20:39 ` [PATCH v8 1/4] ptr_compress: add pointer compression library Paul Szczepanek
2024-03-07 20:39 ` [PATCH v8 2/4] test: add pointer compress tests to ring perf test Paul Szczepanek
2024-03-07 20:39 ` [PATCH v8 3/4] docs: add pointer compression guide Paul Szczepanek
2024-03-07 20:39 ` [PATCH v8 4/4] test: add unit test for ptr compression Paul Szczepanek
2024-03-08 8:27 ` [PATCH v7 0/4] add pointer compression API David Marchand
2024-03-10 19:34 ` Honnappa Nagarahalli
2024-03-11 7:44 ` David Marchand
2024-03-11 14:47 ` [PATCH v9 0/5] " Paul Szczepanek
2024-03-11 14:47 ` [PATCH v9 1/5] lib: allow libraries with no sources Paul Szczepanek
2024-03-11 15:23 ` Bruce Richardson
2024-03-15 8:33 ` Paul Szczepanek
2024-03-11 14:47 ` [PATCH v9 2/5] ptr_compress: add pointer compression library Paul Szczepanek
2024-03-11 14:47 ` [PATCH v9 3/5] test: add pointer compress tests to ring perf test Paul Szczepanek
2024-03-11 14:47 ` [PATCH v9 4/5] docs: add pointer compression guide Paul Szczepanek
2024-03-11 14:47 ` [PATCH v9 5/5] test: add unit test for ptr compression Paul Szczepanek
2024-03-11 20:31 ` [PATCH v10 0/5] add pointer compression API Paul Szczepanek
2024-03-11 20:31 ` [PATCH v10 1/5] lib: allow libraries with no sources Paul Szczepanek
2024-03-15 9:14 ` Bruce Richardson
2024-03-11 20:31 ` [PATCH v10 2/5] ptr_compress: add pointer compression library Paul Szczepanek
2024-03-11 20:31 ` [PATCH v10 3/5] test: add pointer compress tests to ring perf test Paul Szczepanek
2024-03-11 20:31 ` [PATCH v10 4/5] docs: add pointer compression guide Paul Szczepanek
2024-03-11 20:31 ` [PATCH v10 5/5] test: add unit test for ptr compression Paul Szczepanek
2024-05-24 8:36 ` [PATCH v11 0/6] add pointer compression API Paul Szczepanek
2024-05-24 8:36 ` [PATCH v11 1/6] lib: allow libraries with no sources Paul Szczepanek
2024-05-24 8:36 ` [PATCH v11 2/6] mempool: add functions to get extra mempool info Paul Szczepanek
2024-05-24 12:20 ` Morten Brørup
2024-05-28 19:33 ` Paul Szczepanek
2024-05-24 8:36 ` [PATCH v11 3/6] ptr_compress: add pointer compression library Paul Szczepanek
2024-05-24 12:50 ` Morten Brørup
2024-06-06 13:22 ` Konstantin Ananyev
2024-05-24 8:36 ` [PATCH v11 4/6] test: add pointer compress tests to ring perf test Paul Szczepanek
2024-05-24 8:36 ` [PATCH v11 5/6] docs: add pointer compression guide Paul Szczepanek
2024-05-24 8:36 ` [PATCH v11 6/6] test: add unit test for ptr compression Paul Szczepanek
2024-05-29 10:22 ` [PATCH v12 0/6] add pointer compression API Paul Szczepanek
2024-05-29 10:22 ` [PATCH v12 1/6] lib: allow libraries with no sources Paul Szczepanek
2024-05-29 10:22 ` [PATCH v12 2/6] mempool: add functions to get extra mempool info Paul Szczepanek
2024-05-29 11:47 ` Morten Brørup
2024-05-29 13:56 ` Morten Brørup
2024-05-29 16:18 ` Paul Szczepanek [this message]
2024-05-30 0:56 ` Du, Frank
2024-05-29 10:22 ` [PATCH v12 3/6] ptr_compress: add pointer compression library Paul Szczepanek
2024-05-29 11:52 ` Morten Brørup
2024-05-29 10:22 ` [PATCH v12 4/6] test: add pointer compress tests to ring perf test Paul Szczepanek
2024-05-29 10:22 ` [PATCH v12 5/6] docs: add pointer compression guide Paul Szczepanek
2024-05-29 10:22 ` [PATCH v12 6/6] test: add unit test for ptr compression Paul Szczepanek
2024-05-30 9:40 ` [PATCH v13 0/6] add pointer compression API Paul Szczepanek
2024-05-30 9:40 ` [PATCH v13 1/6] lib: allow libraries with no sources Paul Szczepanek
2024-05-30 9:40 ` [PATCH v13 2/6] mempool: add functions to get extra mempool info Paul Szczepanek
2024-05-31 9:32 ` Morten Brørup
2024-06-06 12:28 ` Konstantin Ananyev
2024-06-07 15:12 ` Paul Szczepanek
2024-05-30 9:40 ` [PATCH v13 3/6] ptr_compress: add pointer compression library Paul Szczepanek
2024-05-30 9:40 ` [PATCH v13 4/6] test: add pointer compress tests to ring perf test Paul Szczepanek
2024-05-30 9:40 ` [PATCH v13 5/6] docs: add pointer compression guide Paul Szczepanek
2024-05-30 9:40 ` [PATCH v13 6/6] test: add unit test for ptr compression Paul Szczepanek
2024-06-04 9:06 ` Paul Szczepanek
2024-06-04 9:07 ` Paul Szczepanek
2024-05-30 13:35 ` [PATCH v13 0/6] add pointer compression API Paul Szczepanek
2024-06-04 9:04 ` Paul Szczepanek
2023-09-27 15:08 ` [RFC 2/2] test: add pointer compress tests to ring perf test Paul Szczepanek
2023-10-09 15:48 ` Thomas Monjalon
2024-06-07 15:09 ` [PATCH v14 0/6] add pointer compression API Paul Szczepanek
2024-06-07 15:09 ` [PATCH v14 1/6] lib: allow libraries with no sources Paul Szczepanek
2024-06-07 15:09 ` [PATCH v14 2/6] mempool: add functions to get extra mempool info Paul Szczepanek
2024-06-10 14:24 ` Konstantin Ananyev
2024-06-11 13:06 ` Paul Szczepanek
2024-06-07 15:09 ` [PATCH v14 3/6] ptr_compress: add pointer compression library Paul Szczepanek
2024-06-10 15:18 ` David Marchand
2024-06-10 15:37 ` Morten Brørup
2024-06-11 13:16 ` Paul Szczepanek
2024-06-07 15:09 ` [PATCH v14 4/6] test: add pointer compress tests to ring perf test Paul Szczepanek
2024-06-07 15:09 ` [PATCH v14 5/6] docs: add pointer compression guide Paul Szczepanek
2024-06-07 15:10 ` [PATCH v14 6/6] test: add unit test for ptr compression Paul Szczepanek
2024-06-11 12:59 ` [PATCH v15 0/6] add pointer compression API Paul Szczepanek
2024-06-11 12:59 ` [PATCH v15 1/6] lib: allow libraries with no sources Paul Szczepanek
2024-06-11 12:59 ` [PATCH v15 2/6] mempool: add functions to get extra mempool info Paul Szczepanek
2024-06-11 12:59 ` [PATCH v15 3/6] ptr_compress: add pointer compression library Paul Szczepanek
2024-06-11 12:59 ` [PATCH v15 4/6] test: add pointer compress tests to ring perf test Paul Szczepanek
2024-06-11 12:59 ` [PATCH v15 5/6] docs: add pointer compression guide Paul Szczepanek
2024-06-11 12:59 ` [PATCH v15 6/6] test: add unit test for ptr compression Paul Szczepanek
2024-06-14 10:28 ` [PATCH v15 0/6] add pointer compression API David Marchand
2024-06-17 10:02 ` David Marchand
2024-06-17 13:46 ` Paul Szczepanek
2024-06-17 13:57 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e668808-f76e-4ea0-8147-8df1efb102f2@arm.com \
--to=paul.szczepanek@arm.com \
--cc=anatoly.burakov@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=frank.du@intel.com \
--cc=mb@smartsharesystems.com \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).