From: Declan Doherty <declan.doherty@intel.com>
To: Chas Williams <3chas3@gmail.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/bond: change link status check to no-wait
Date: Wed, 28 Jun 2017 10:13:30 +0100 [thread overview]
Message-ID: <9e864265-ac0c-bbdc-5648-449f74be74b3@intel.com> (raw)
In-Reply-To: <1498510425.1841.0.camel@gmail.com>
On 26/06/2017 9:53 PM, Chas Williams wrote:
> On Mon, 2017-06-26 at 16:13 +0100, Declan Doherty wrote:
>> In the 802.3ad periodic callback function the link status of all slaves
>> is checked using rte_eth_link_get function. Depending on the slave
>> device this function can block for up to 9 seconds and therefore
>> could cause issues with the LACP Daemon state machine and control
>> patches handling. This patch changes to the no-wait version of
>> the link get function.
>>
>> Fixes: 46fb4368 ("bond:add mode 4")
>>
>> Signed-off-by: Declan Doherty <declan.doherty@intel.com>
>> ---
...
>
> It seems like this should be done in bandwidth_left() as well.
>
Yep, your right. I'll make that change in the v2.
Thanks
Declan
next prev parent reply other threads:[~2017-06-28 9:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-26 15:13 Declan Doherty
2017-06-26 20:53 ` Chas Williams
2017-06-28 9:13 ` Declan Doherty [this message]
2017-06-28 10:15 ` [dpdk-dev] [PATCH v2] " Declan Doherty
2017-06-29 11:34 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e864265-ac0c-bbdc-5648-449f74be74b3@intel.com \
--to=declan.doherty@intel.com \
--cc=3chas3@gmail.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).