From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 3E1032C13 for ; Wed, 28 Jun 2017 11:13:32 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jun 2017 02:13:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,274,1496127600"; d="scan'208";a="102228760" Received: from dwdohert-mobl1.ger.corp.intel.com (HELO [163.33.228.173]) ([163.33.228.173]) by orsmga004.jf.intel.com with ESMTP; 28 Jun 2017 02:13:31 -0700 To: Chas Williams <3chas3@gmail.com>, dev@dpdk.org References: <20170626151347.16680-1-declan.doherty@intel.com> <1498510425.1841.0.camel@gmail.com> From: Declan Doherty Message-ID: <9e864265-ac0c-bbdc-5648-449f74be74b3@intel.com> Date: Wed, 28 Jun 2017 10:13:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1498510425.1841.0.camel@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/bond: change link status check to no-wait X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jun 2017 09:13:35 -0000 On 26/06/2017 9:53 PM, Chas Williams wrote: > On Mon, 2017-06-26 at 16:13 +0100, Declan Doherty wrote: >> In the 802.3ad periodic callback function the link status of all slaves >> is checked using rte_eth_link_get function. Depending on the slave >> device this function can block for up to 9 seconds and therefore >> could cause issues with the LACP Daemon state machine and control >> patches handling. This patch changes to the no-wait version of >> the link get function. >> >> Fixes: 46fb4368 ("bond:add mode 4") >> >> Signed-off-by: Declan Doherty >> --- ... > > It seems like this should be done in bandwidth_left() as well. > Yep, your right. I'll make that change in the v2. Thanks Declan