From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15CF542BF7; Wed, 31 May 2023 15:57:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A6B3140A89; Wed, 31 May 2023 15:57:21 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2078.outbound.protection.outlook.com [40.107.220.78]) by mails.dpdk.org (Postfix) with ESMTP id 294B940A82 for ; Wed, 31 May 2023 15:57:20 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ll4X6s0+UUaIAMieF2/aRI6vNa5FwzCsO36Vnfk5yNZgRLdbv3WvNd8x5lxGy5GzgSE3q4/rQv2ABaBGn/J8WbeY4QIE+2J8LdpjwEOxQV2dvVD55mTgvqQ4msd8jBp9k1aJWQIjkx//KuAglIj1UHF7tQlJMgv5BRUINruLMFIOnX+Gi6Kpk9rJTku2Km/GPGIW7q4rDUqwQsdGibtHQJMiOhnEBmbQLpZSrLzYexgL2hIFbdVuxlqkMOQzObo0JPjavf8D5s5XZQ/Y5PhMuY/8oOtV//MzApDci/863zQaj+DuWbdu160vOsZyCRK5oUKPJc3Epjc0KwUmlShrjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KFpVA9ti2RTFmJSplr9zdkcA0/pZSMar7H4A8ugDUiQ=; b=McCOh/XsRWPHElrtziU/jqOigzVjMRy36oUGw/Fz7dw6UjvIqbtfpjVcBJl8iW9lXiZga8i3oc35j2t32dvuyr12XIQGRHEADpKexOm9gW3yJLJcWlfATO7EuTu7UHBlthrLwAxeuP+rJOu6kfAAWGzFMJkSGI9x3XMNNjveZEVpKtvv/EDJdnto9Yvck6zknTCXxGWrqKCfMC06Ie6YPmdhXEvvjlSrFX8pS00+Bx+mIOzcW0Z0Y1ZTaa9G550RvlWpKbYrH8h0gfnf9xSW4bcFQBXEM3dWHOxfx1h5g2Qk5qwA5qS4+7p5tkGoivTs7Xt3k5HSNVVq8jItLOrpTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KFpVA9ti2RTFmJSplr9zdkcA0/pZSMar7H4A8ugDUiQ=; b=ha9xVBCiQXde9lQLR4Ig8ojSmBktDIlOohhu0Hg8BW0CUb6SYofqssS+0ejj2sy34TGLkd5hl+LL0oMwwTMHesw7WWGFAMUsxvG+N3mPgCbGmoHIIaSG8Ija8Pz9eRa6sHxiaR5DjRIc7neWdZF+GT1VarDdXgXcWmG5WEL1hlQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by BY1PR12MB8446.namprd12.prod.outlook.com (2603:10b6:a03:52d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.23; Wed, 31 May 2023 13:57:17 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a%4]) with mapi id 15.20.6433.022; Wed, 31 May 2023 13:57:16 +0000 Message-ID: <9e9a1834-a8ef-12b5-71e5-409ed7bffe76@amd.com> Date: Wed, 31 May 2023 14:57:09 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH] ethdev: fix indirect action convert Content-Language: en-US To: Ori Kam , Suanming Mou , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Andrew Rybchenko Cc: "dev@dpdk.org" References: <20230526031800.913744-1-suanmingm@nvidia.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP265CA0080.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:76::20) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|BY1PR12MB8446:EE_ X-MS-Office365-Filtering-Correlation-Id: c11091ef-f21f-4d5b-d0e9-08db61def137 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QCF2JtorTHacf4H1JGrSDNv2tuqhb0sIp98mX3H+L7POMgh07wkOrg38N+clAeERqcLVGFoRkNM8mAe4d7Iyu3ASq1AKl2A1KCFqCbfoX5cfDTJtKmfy3UXDPVYOJf0MjpxEMZD5+6Zpdy39qJVJmGxeoUiKXmOxoxkcV9CCR+PGgewCP5Dix7ElMJuB1pgL9HrMi9jUmIZb1+cXgD1f6meAZcghHdGn4gBNpFeY8t0Hy1pDz9GF+bn0rLMEDAnfNwdbJ5rY14Ef53hnG+qyPygO1NecVioyX0Cy6aIdQk+rxFzUe6Ha9W9agmeHuvhsLVfJoamE1Eb2YAS/j0+bApzUdtgtoRD43pnywIE2zUE2jWdK+8BL/2hBrt6SRZ8hKtRJoU8YBrn/LXFo0RBAt06sgVKUvnIEm5tydMQB8gZcRa1srI1I3Kvw7XEC+1JTeZKcPYGTU4M0YX+elVpdebqiWwmEdtuyTQZARNsjbcKFOHt1T0zwaAEqhiQOXsnsf1hPTkymdV4L42/mSfdhjb3T6W3664eRYPNbvBq6ujsybtW01DGTSN5S5fRWB/zBawHie3JxG5zWHBze/q51VjxmbpweHnptCShCF03XYL9xzUUwMhIVG37SNHhHQ9DerkdVIs82wejwj7dwjZG2Rg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(396003)(346002)(136003)(376002)(366004)(451199021)(31686004)(86362001)(38100700002)(83380400001)(2616005)(66946007)(66476007)(66556008)(31696002)(110136005)(4326008)(478600001)(2906002)(6666004)(53546011)(6486002)(186003)(316002)(26005)(6506007)(6512007)(8676002)(41300700001)(36756003)(44832011)(5660300002)(8936002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d1YvcDdubHZqc2tFbmp2djd5VU9uQkNNcHJlR1UxbFVYeWE4S01MMTh6ckNh?= =?utf-8?B?a1dXdU5QWGRwY1l3enRSREpvMGZ4YnR0VC9ic3ZzRmx4NWZaNnh0NWpneXBN?= =?utf-8?B?dEYzblI3dEVpRnlJZEpHUXQyekhhT3FLSEJPaFJObWRJc1JjNm9QRWttbGxF?= =?utf-8?B?SzR4L0d0RlViWHZCODBmYm9aLzhwYmtVejB0N0o5ZjYrcUVWZHhrWld2NDZZ?= =?utf-8?B?VE0wNWZRRDI3YUFTQkNPR01xdVZuQy8zbTJUcHFFTTJqM0pQMHlPVmxCRThz?= =?utf-8?B?c0hXc0dGK3ppYTFSSjFxVnFUcC8zZ3dzQVVhemtFdi9SZy91K1cyY0d3QmhD?= =?utf-8?B?KzdGQlB3MExlZFNXM2U2dHRob1hRbGpUR0tPd0FKL2huanZUMkRRQnJvQ0F2?= =?utf-8?B?SzNiUUVCdXRrK0NaRFB6TFkwSWtkV2ZhbGZwUndWdUNnZVVkWlkzVUEvU3RW?= =?utf-8?B?RnpqQmdmQ21oc0wySVQva082OWRiZzBVTFp2Ukg0MlV1NHZaL0FUbDcvSzU5?= =?utf-8?B?cVA3VXIrTzVaVTdqNjZkUkFmc2xJL3NJcC9sVzNyUGNGMlNpbXBJRFJIRU9L?= =?utf-8?B?ZVpYczlQSTc3UWEydFZ6QWpMQmVmSGJrTXlvbldVMThIdE0yNjh6aVN2cXlB?= =?utf-8?B?QTR4bHdKVVF1aGtnV0VEd3h3akJ6RlRnOVM1NTJZc3lvSVVNM2s0WUowRTFD?= =?utf-8?B?VmhPajlXTmE1S0xEMkZMZjgybzdtb2hNQ2M0cno0bnMrSDJpUHhEWVliQTlh?= =?utf-8?B?anpHZmpSekNUVGNUaHFjbWpzVWVhNlVYa2o2K3E4U1YwZjhNS0lwY0JvS0Jw?= =?utf-8?B?VDgwaXBLTTNKcVFBV2VNYy9OV011NTM0TW9RZTRjWXhEQ2w0STh4bklwOGxP?= =?utf-8?B?V2ozK0NQOVhGTFZOMFRFUGovaVZVQXRnUXBZN2l0Wk5ENEl4amJ2YlBDU1JO?= =?utf-8?B?b3QxQ0RHUEJhMHNIM1doUUM1cDIvQTlnb0JVS3VlOFdOTUhKOENpUGNVaUpZ?= =?utf-8?B?Rmd2TVltaDRCZUVKeWtHZHVVSklqNjNGai9qcVllWVh3aXZqTkxTOG5kZXU4?= =?utf-8?B?N2o1WS9sRHFzMzFlUGExYmdjNk94UUpWREJCTTl0emRIL3duRVg0SWtrZGMy?= =?utf-8?B?Q2dVTDFjQ2lZNVBqc3k1aDdqWlFSa1BlV3Jnc0lRSkR4ZCtUd2RramdmSmRx?= =?utf-8?B?V2tpSW44eWIzT1VESkZrQnRXR0V3bk1PMHVBY1pYczlHUXY1WkR5Z1EranVO?= =?utf-8?B?THl0ZHoxUUNqdGhnaUh4VlhwQ1BQejBsYWhoTFNwZHlUbHdSRVVoV2ZjK291?= =?utf-8?B?eFI2enVhM1UzdWtLV0NQVDFNc29UaSt0ZEhPWmhwYVd0UGNQNWRvSTJnaDNy?= =?utf-8?B?a3ZUMk04UitZM00zaGJ4NWZCY1RSR1VJcnFmcGhzeFlBMkhBa1dCTzR3QUJC?= =?utf-8?B?UGEyeVpRS2dRVWpxMFhXVGhtSFNxeFFKWExQaFUzcGw4bjVZd1dtcjRyWmts?= =?utf-8?B?OUlLREhGTGZPSWVMWENyNUtWTkRrb0NxM0JPQXJYU21PdGdtY3A0TTZkMk9q?= =?utf-8?B?Sm1nRmFmWmwrcEk2RjQwOTcyS3FPcWlwOC9PV3JzTmxhYSszMVNqbDFaYmNu?= =?utf-8?B?VlFmanJiTlpKUUo2V3h6REk4Z3c4VlNYRVJQK2dJemI0VnhNZU5hdXdvK2N4?= =?utf-8?B?a3ZsLzNuN3ZPbEpYVUdQOC9yY0VvbGFlNmFKRHI4QXN5dXdpa3ZBcmRsUjA2?= =?utf-8?B?clRhU0h5cWpPcmhhcHZNemdJK3FHSnhxd1gvc2FWNXA5OVB4RjR2MWhaekZJ?= =?utf-8?B?MmlYdmtmVFh1dkJCQkgrb0FBN3JqVHJZTnNWK2J2eGRVNDNhQ28xeVVhTm1U?= =?utf-8?B?T1gzdUpDOGtMZVlxS0lFMzU4S3RZMUVHYXlUMFFnY01STFNrVjU4YjdEWTVX?= =?utf-8?B?MFBCbiticCtIbWhmM3lTVUxVSGphY2NmRFpKdldIaXE3UXY4Tm1iRUlJd2Nv?= =?utf-8?B?cDNraldZbTlTSHlYMS9vL0hmSk84VVFhSUVMQktZZkxwMFlod091QUZVKy8x?= =?utf-8?B?ZHZ4cHN1TVFQK00vb3p4bCtVNWpjQ0lYUURmZlc5QUY0SHVFakJyQkxNVXRQ?= =?utf-8?Q?XGkmOaFkbvQE039yRsEirZ9Hx?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c11091ef-f21f-4d5b-d0e9-08db61def137 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2023 13:57:16.4384 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1TOdg8AnqtK78uVlC/89ZLSp6EcyEBSG45KcC1uzOcbpfV1J0Ks7xvDK8DjEAiFg X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR12MB8446 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/29/2023 7:12 AM, Ori Kam wrote: > Hi Suanming, > >> -----Original Message----- >> From: Suanming Mou >> Sent: Friday, May 26, 2023 6:18 AM >> >> As indirect action conf fills the indirect action handler, while >> converting indirect action, the action conf(action handler) should >> be copied from original indirect action conf instead of duplicating >> the action handler memory. >> >> Fixes: 4b61b8774be9 ("ethdev: introduce indirect flow action") >> >> Signed-off-by: Suanming Mou >> --- >> lib/ethdev/rte_flow.c | 10 +++++++++- >> 1 file changed, 9 insertions(+), 1 deletion(-) >> >> diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c >> index 69e6e749f7..ff740f19a4 100644 >> --- a/lib/ethdev/rte_flow.c >> +++ b/lib/ethdev/rte_flow.c >> @@ -889,7 +889,15 @@ rte_flow_conv_actions(struct rte_flow_action *dst, >> src -= num; >> dst -= num; >> do { >> - if (src->conf) { >> + if (src->type == RTE_FLOW_ACTION_TYPE_INDIRECT) { >> + /* >> + * Indirect action conf fills the indirect action >> + * handler. Copy the action handle directly instead >> + * of duplicating the pointer memory. >> + */ >> + if (size) >> + dst->conf = src->conf; >> + } else if (src->conf) { >> off = RTE_ALIGN_CEIL(off, sizeof(double)); >> ret = rte_flow_conv_action_conf >> ((void *)(data + off), >> -- >> 2.25.1 > > Acked-by: Ori Kam > Applied to dpdk-next-net/main, thanks.