From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id D9CC43257 for ; Thu, 3 Aug 2017 11:37:57 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 195D6356D8; Thu, 3 Aug 2017 09:37:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 195D6356D8 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=maxime.coquelin@redhat.com Received: from [10.36.112.16] (ovpn-112-16.ams2.redhat.com [10.36.112.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C8A0C60610; Thu, 3 Aug 2017 09:37:55 +0000 (UTC) To: Steven , yliu@fridaylinux.org Cc: dev@dpdk.org References: <20170801161736.83502-1-sluong@cisco.com> From: Maxime Coquelin Message-ID: <9eaa32ce-a6b8-e8bf-42ce-ef4cba093189@redhat.com> Date: Thu, 3 Aug 2017 11:37:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170801161736.83502-1-sluong@cisco.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 03 Aug 2017 09:37:57 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] net/virtio-user: send kick to tx queue to notify backend on initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2017 09:37:58 -0000 Hi Steven, On 08/01/2017 06:17 PM, Steven wrote: > Acccording to the spec, https://fossies.org/linux/qemu/docs/specs/vhost-user.txt > > client must start ring upon receiving a kick (that is, detecting that file > descriptor is reachable) on the descriptor specified by > VHOST_USER_SET_VRING_KICK. > > The code sends a kick to the rx queue. It is missing sending a kick for the > tx queue. This patch is to add the missing code to comply with the spec. > > Signed-off-by: Steven > --- > drivers/net/virtio/virtio_ethdev.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > index 00a3122..6362e14 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -1747,6 +1747,11 @@ virtio_dev_start(struct rte_eth_dev *dev) > virtqueue_notify(rxvq->vq); > } > > + for (i = 0; i < dev->data->nb_tx_queues; i++) { > + txvq = dev->data->tx_queues[i]; > + virtqueue_notify(txvq->vq); > + } > + I'm not sure to get why we would need to send Txq notification whereas no packet have been enqueued. That said, I don't think it hurts. Steven, does it solve a real problem you are facing with virtio-user? Yuanhan, what's your opinion on this? Cheers, Maxime