From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C95A6A0352; Mon, 14 Feb 2022 18:33:14 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 687D140DDA; Mon, 14 Feb 2022 18:33:14 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id B0E5D4067E for ; Mon, 14 Feb 2022 18:33:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644859992; x=1676395992; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=Qehs/xyMn7EUwz+O8cTo7v4zrZcFH5U7rlLtrLE+Yqg=; b=SRdZ67Cn06ru+C/C2J1CyN37LthkBd4O6Mne7phqi4qFgaSdjq20XtUA ErGbKicPI6cYIL41E2H+vouc75hTQXJ11oDk1YmQYGZun7JHi1bGX2Iqk oZO7RFXOcxc6BIkpF1cW9U69ujh0v6tc1PcglYl5Alp40C0BiH2heEo5Y uyDHmF1FeokJ4/nLVSH75AKH2+vUO4fkrMTlh7Whjzng2UO2y2cz/DVba 2GKmfTmf4N9IJpglbIJmK+H+u1PkVtadytNlD0kVcqzIoQZUarXf8ILGH saMEahNxXqvnD9IjL1DQYFpB2MAKJ/Kr08P4aVkuj3ZHwHw4EOFKIrVMx w==; X-IronPort-AV: E=McAfee;i="6200,9189,10258"; a="230779290" X-IronPort-AV: E=Sophos;i="5.88,368,1635231600"; d="scan'208";a="230779290" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2022 09:33:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,368,1635231600"; d="scan'208";a="528311316" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga007.jf.intel.com with ESMTP; 14 Feb 2022 09:33:11 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 14 Feb 2022 09:33:10 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 14 Feb 2022 09:33:10 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 14 Feb 2022 09:33:10 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.170) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 14 Feb 2022 09:33:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q+a+T6C+7YPlDoR8V8FTmRd+jUkO2jsjXErE/7BsWXtuvS4r9OWmJELqEAwDWna7OmpYiArBGz7S5UpPWjMEZ5bpb/f+la7YghcVgLkFHHh1gjSfyyS3gVM5vgNx4cKF4QiYh8Hqtz1A8Or3AxfrDjGRN12FZnE/08wYIxs2k2R5vUI0F3acHBxwchFgaNRXu3d6DIUxNDF+KYAlTDehCVw8mmtQFbS7MDK343Jtd27OIf7Wvf5Miiu/lY/v4qtQ+llterbYt+j+OrxOnfpW5vF+qzJ383l/TwmgbUXCQ5BCuqMgpd/OCbDXr2suc9mFU7SUZ5cTZdwf0/Sl7yoSxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nLawKQRjfMaflZGGWenKa/W6+NSV5ghAUIUbC6Ya2AE=; b=mef43rb8+cley41rY615IbLWHdLhe3iQ5C28ssP5C6hbQ4cZ6mEhf6ELw2R6fa3akMd4Yp/824KRiv4PAHwiQiOnJQEHQxsrOe25D41Tg+N7AYgF7phQg3jjarT43XpOKMD4yPzChtFR+LLaiKx0lm/yr5qvbwHcze9xUXqQxtmxkW14jipfyoIZ7plRxL4Fk9zLL6Yl5enY0DZG8lD/nXdCb/8HnT6AbUVOii3RIDedznNz3tAjYfb3qBtdV46OBG2Uex7V/syWgXE3wUmnO/FXFr0a4iTyoSH+w8nGK2pnJ19VTNSfDPHiSbqppNwcKxKnpzwTeuwaMYUE8MGgOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BL0PR11MB3011.namprd11.prod.outlook.com (2603:10b6:208:7d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Mon, 14 Feb 2022 17:33:08 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.019; Mon, 14 Feb 2022 17:33:08 +0000 Message-ID: <9eb28ee2-5d76-c93f-2844-f754db4747a5@intel.com> Date: Mon, 14 Feb 2022 17:33:03 +0000 Subject: Re: [PATCH] devargs: Fix crash due to global devargs uninitailization from secondary process Content-Language: en-US To: CC: , Gaetan Rivet , Thomas Monjalon , David Marchand References: <20220214170811.1192-1-madhuker.mythri@oracle.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20220214170811.1192-1-madhuker.mythri@oracle.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0495.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1ab::14) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1309b851-3608-48dd-9855-08d9efe010dd X-MS-TrafficTypeDiagnostic: BL0PR11MB3011:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5236; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oNvRTeXASrUWJe8P8FJwSMNufdmsOKn/3rbAsGEgojRTI1E6SHzJ7WzMB0YBowawkDpMs+DhT0HN94pCaTrFBRIlFvuH1Cdl8+PwGsntTox03ZFZ1xFJOlxsk276r6gmxOCUv6bZRHYI5C88XYL3wktqCYmcKmjn+gvzWQSmqOBLxNcLiP5zaw97vKD3dQXhaOIFlM1WIOLExWj9x9QCKL0vkm1DHOtWfPbCszhpuS9xloNpF2/yoFfXH1Ikc0Vuq8IF93sPE80go8PS2+5F0WVZyayXyNNwJBcz3DsiVyjZNTzSpbUg8Q5sVvcQ8rc3Vr+xara80s5eT94gopciUUcwef6WsKUiG8mXcMORjco64SVLCgy/2qaBIvFjUsfhK614hzbsJ98BbUF4a4adPm7EPIZsipISGGPvEC20o60wzyEcMR2bP0VVo5C4goxba6yKEOR9Gt3MH4BuY3ecRftxPHYi3F5BLd9BBt4S4k2PtuaKBfsCt2Hu0uhYb5yZeWUtzvpx5UkiVcwECyFD2X5krZ0ajiaT5v0IiGEgwOA2JRe9cERxAFQXYyE3a7tTGWjHSdnyBdLpuhHnyhYD9hFGp4iNDMpNkatnNdeRnJWR0Z/sbcSsfwWeoauxnpIiV5e+4PIrOa/eWV8D6IU1TC1KOdvqZhnX4IYwYBMNtvxbHj9PmwjMNZrTFx220yVKQm48WfDnAC1UTTWv85UsOffsPZZCnEN5TBn95qMhYeBTtkU28M+TbwogReGtzQOvi8rfwn+FXw7ck5lWKF7hMSef36Wvowf6IhUKdZEo95M= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(82960400001)(38100700002)(2906002)(8936002)(5660300002)(8676002)(66476007)(66556008)(66946007)(31686004)(4326008)(316002)(508600001)(6486002)(966005)(31696002)(6666004)(53546011)(6506007)(86362001)(6512007)(83380400001)(36756003)(44832011)(54906003)(6916009)(2616005)(26005)(186003)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZjhGMmRvUDBmSVhsZHI1cklrcVhUVnh2ZFIzS0QyV204MXZMQTR5K0dRL3Q5?= =?utf-8?B?eWxMVjBRRHNzTER4dWNtazNTeExGVmZZUnlOWjNpOXpLOWJKaTl1Sm9hYThN?= =?utf-8?B?UXhJNGRzOGtFbmpCK1JUMW01NVh1MmJJWmQ1REM0RWVEUml2UytKWUxVZHBn?= =?utf-8?B?WlZLSmtZOXVWZVBpUWVYM3JBeWN6cWYzcjRIcTFnY3NQQ01YRVlGUU0razMv?= =?utf-8?B?VUp6S21ucGJSam1QVmk5WXF5bVk4QU1GNll6M0dSTFNIVmVhVk94N20vTE1J?= =?utf-8?B?bHBlSmR4ZjFKUklhZUxXa1piUzNQN250enlJT2FTM0wwNDhtZzVBbW5GSjJy?= =?utf-8?B?azQ4THlueWFBakZDZFhITE1pOE1rUnZpM1d2QzhNeWJ1ODByVUhhRUpCZ29z?= =?utf-8?B?SEoxL0RSL2E1bkk1U0k1RWNHeVhpS0RiNVp5Mzlqc2JGM2FvREZ5SDZPQWdU?= =?utf-8?B?M2RmQUdMVHl2ZDRzcXFPUG1lZUZ6dkE4cTlacUtpdVRTOEZZcjRXb2xlVW1a?= =?utf-8?B?a2VTNEpBaUJIaXhuclFnMnNNNVpFb0ZrOGxuS055VDdqek9xNDZYdUswK1gz?= =?utf-8?B?ZlRaVlE1NWMwOW9QNTI1VTBjWE1TQkVVbFdFWUxXZitwb01paE9VTE1Yd2RQ?= =?utf-8?B?TkgwZ1NJM2RqYmViUmJiNzZaQjlxR2lQOENoK3dXNjhuUFo1TC9FR0s1cWlj?= =?utf-8?B?ekZ0dHFiSklZaFNsS3pWNkpuWENpbkJkLzIwK1VkSGplWDcyQ2l4b2FvNkRN?= =?utf-8?B?eDB5emRnNldrZlZjRVI3Z2VmTWpiK0ppeElwQ202OWpPY3JVeHZxTGI0dzFi?= =?utf-8?B?QWswM3pWYzdTRnBiQWFjc2lXenZLMTVuVjNtT3g5azErenRZL05QUHQ0K01n?= =?utf-8?B?RWY2Q2hhV1Z3b2JNeS9UNFdpUEFhRGY3MmpvcWhhUzdhWGRtN2U3OGM2N2JL?= =?utf-8?B?ZjhKM2ZFNUxRRk9ndldENXh1UUpEMkxHa2E2MC94VWFPNWhSL0QwU3FsWTJm?= =?utf-8?B?ZWRwRmtqMEd5eFN2UE1KVXcwMDR4QnJ4cEFOZU5ad25EQURxVktJSmNDeXcz?= =?utf-8?B?K3VWZjNCQ0szNWtJMjlMU0IwRGlwa3E0Y1ZQVDNrdmQxM2gxQmoyUEVHYnJQ?= =?utf-8?B?aHJDejJOUnlQUVZldmtndlZrK0lwanFZOFMwSjNPQTh2eGorTGovdEgwNEha?= =?utf-8?B?ckswcFdhSlp0c0l3WGxMSE5UbHdmb2NldkRudzhSUW50cHl3dzZVR291U0xW?= =?utf-8?B?K1lVOFovZ0dhOTlCeHNoUnhXTTBGRTM5RjZzdjd0UlB2SzkwVitDSzNSVjYx?= =?utf-8?B?SFhDT01INm4wYTUwdEE2aHUrTFhjd21PSUd3aHdpT0N1VE1DZXpTek11akR0?= =?utf-8?B?Y1dHWFZwVDBFT0pDNkxBaXNEYlFXamQxQ3hwWmVjNkFqcDg2RG41NjQ0S05l?= =?utf-8?B?NEdUU21TQjRSTHhUMU5HNm9ZMmI3VTZnNWpQV1R4RWhWSlFVRHZqZDJXazZs?= =?utf-8?B?Sy9DYXV4cTdvZVo3aFJjZmo3OE10ZUkzMHV1NkZNMm9VUVVqOE5zeGl1Y1BD?= =?utf-8?B?MWlYZ2pQbHlrcHlsRWNNem13RXZEcWVXeHJVUHhaOC9xRmNKOTFnUVRTWS93?= =?utf-8?B?ZGduWlhqZ3pQaVB2Tjlaa25wWkpNeStCeG1uZDQ0YmRGNDdWVGg1QXNXaENj?= =?utf-8?B?TkpCcWpNQlZ4aExKUEpjZ1U0NUk3S2Rua1pkWTlmN1RzQUphNEE1a1BWMDN4?= =?utf-8?B?M1kyQWxWL0owb0ZrQ04wRmVHMHEwREx5UmxOYWx5bjZOdmd2SnJCMENwaTBv?= =?utf-8?B?blpzWGZwdFl6bGRXUGMvMjNudjJJY3E5TUh3NFVoVzdQdWtyQW93TTUyL0Jx?= =?utf-8?B?RWFnZExIeGUzaU51OUlQZzltMEpOUitpNVVaRUpiN2V0ZmdEWTdZdzluUnZD?= =?utf-8?B?RDZuTUN1VlQ4cjNlSlE3TkZjZU9tT0ZOVFF3YmZSYUE2WVZzcVpqRFFEZlUv?= =?utf-8?B?dDZ6a1cxUTBha2QycTZZd2RNVTlSdjMxZThIR2JXdEcrUUxFRkZGK044bXcx?= =?utf-8?B?ZGtQZjhYRXZ1OGFDc1pTM1ZqMWZHVmdYWEZFQkxhV0RmNFM1ZUJ1cUNsWGs4?= =?utf-8?B?SWRrcWdPV2tRMUw2SG5UVUZ6MDQ5MXgrNGtuTTVhMHBWOVpTa3dZM2FNMkhS?= =?utf-8?Q?5JGgnkIJYtBGaW1G1/HRBs4=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1309b851-3608-48dd-9855-08d9efe010dd X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 17:33:08.7274 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DUtsIshEp8ZGvzcnchBrD5crcA4JkHaixFrWYRB2H77bJOGiGfVHjsuZUWym5iHn0keugXn+WKhvfgt9j0IbXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3011 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/14/2022 5:08 PM, madhuker.mythri@oracle.com wrote: > From: Madhuker Mythri > > Failsafe pmd started crashing with global devargs syntax as devargs is > not memset to zero. Access it to in rte_devargs_parse() resulted in a > crash when called from secondary process. > > Bugzilla Id: 933 > > Signed-off-by: Madhuker Mythri This is duplication of Gaetan's patch: https://patches.dpdk.org/project/dpdk/patch/20220210170131.2199922-1-grive@u256.net/ > --- > lib/eal/common/eal_common_devargs.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/eal/common/eal_common_devargs.c b/lib/eal/common/eal_common_devargs.c > index 69004b0a2d..ad60febad9 100644 > --- a/lib/eal/common/eal_common_devargs.c > +++ b/lib/eal/common/eal_common_devargs.c > @@ -190,6 +190,7 @@ rte_devargs_parse(struct rte_devargs *da, const char *dev) > > if (da == NULL) > return -EINVAL; > + memset(da, 0, sizeof(*da)); > > /* First parse according global device syntax. */ > if (rte_devargs_layers_parse(da, dev) == 0) {