From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nbfkord-smmo01.seg.att.com (nbfkord-smmo01.seg.att.com [209.65.160.76]) by dpdk.org (Postfix) with ESMTP id 18292590E for ; Mon, 21 Nov 2016 16:17:36 +0100 (CET) Received: from unknown [193.34.186.16] (EHLO webmail.solarflare.com) by nbfkord-smmo01.seg.att.com(mxl_mta-7.2.4-7) with ESMTP id 01013385.2ba7e720a940.878524.00-2483.1871244.nbfkord-smmo01.seg.att.com (envelope-from ); Mon, 21 Nov 2016 15:17:36 +0000 (UTC) X-MXL-Hash: 58331010704e141c-ed74dc7a25fc70392ed90e7e1a2195672d3c20c7 Received: from unknown [193.34.186.16] (EHLO webmail.solarflare.com) by nbfkord-smmo01.seg.att.com(mxl_mta-7.2.4-7) over TLS secured channel with ESMTP id 8cc03385.0.877601.00-2349.1868966.nbfkord-smmo01.seg.att.com (envelope-from ); Mon, 21 Nov 2016 15:03:37 +0000 (UTC) X-MXL-Hash: 58330cc9218f043a-7dcaa645fb4200cc4276eb69141304ba1bb8b223 Received: from [192.168.38.17] (84.52.89.52) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Mon, 21 Nov 2016 15:03:31 +0000 To: Ferruh Yigit , Thomas Monjalon References: <1695254.J03lBVJQtY@xps13> <2e666e61-bc4e-1a37-f26a-a0fc18a4d988@solarflare.com> <2553236.UbBGAtvXhx@xps13> CC: From: Andrew Rybchenko Message-ID: <9ebf317d-648d-68ac-6d51-eb4e5cdd4e81@solarflare.com> Date: Mon, 21 Nov 2016 18:03:26 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [84.52.89.52] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.000.1202-22712.003 X-TM-AS-Result: No--9.342900-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-AnalysisOut: [v=2.1 cv=P5Y8830u c=1 sm=1 tr=0 a=8P+NB+fYZDP74ap4g4d9Kw==] X-AnalysisOut: [:17 a=RB3BGLmKESwA:10 a=N659UExz7-8A:10 a=L24OOQBejmoA:10 ] X-AnalysisOut: [a=8rWy6zfcAAAA:8 a=IYwW_LfttL7zX3uorM8A:9 a=pILNOxqGKmIA:1] X-AnalysisOut: [0 a=YjdVzJdQTyZRADMV7wFX:22] X-Spam: [F=0.2000000000; CM=0.500; S=0.200(2015072901)] X-MAIL-FROM: X-SOURCE-IP: [193.34.186.16] Subject: Re: [dpdk-dev] Solarflare PMD submission question X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Nov 2016 15:17:36 -0000 On 11/21/2016 01:30 PM, Ferruh Yigit wrote: > On 11/21/2016 8:59 AM, Thomas Monjalon wrote: >> 2016-11-21 11:46, Andrew Rybchenko: >>> On 11/21/2016 11:19 AM, Thomas Monjalon wrote: >>>>> Before submitting 56 patches I'd like to double-check that checkpatch.pl >>>>> errors (for example, because of assignments in the 'if' condition, >>>>> parenthesis around return value) is not a show-stopper for base driver >>>>> import. >>>> You can run checkpatches.sh or send the patches to checkpatch@dpdk.org. >>>> The script check-git-log.sh can also guide you for the expected formatting. >>> Yes, I did it and it helped me to find and fix some coding standard >>> violations. >>> >>> The problem with libefx (base driver) is that it is existing code which >>> follows FreeBSD and illumos coding conventions which contradict to >>> checkpatches.sh sometimes (e.g. require parenthesis around return >>> value). Other example of error produced by checkpatches.sh is assign in >>> if. It is widely used in the code to assign return code value and >>> compare it vs 0 in one line. It is not a coding standard conflict, but >>> it is very wide-spread in the code (so changing it will produce too many >>> changes not strictly required/useful). >>> >>> So, may I repeat my question if it is a show-stopper for base driver or >>> acceptable. >> I would vote to accept these minor style warnings for the base driver. >> Ferruh, any comment? >> > For _base driver_, I am also OK for having checkpatch warnings. In term of checkpatshes.sh return value in parenthesis is an error (not warning). Hopefully it changes nothing. Andrew.