DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] net/hns3: fix build warning
@ 2023-04-04  6:55 jerinj
  2023-04-04  8:22 ` Dongdong Liu
  0 siblings, 1 reply; 3+ messages in thread
From: jerinj @ 2023-04-04  6:55 UTC (permalink / raw)
  To: dev, Dongdong Liu, Yisen Zhuang, Huisong Li, Min Hu (Connor)
  Cc: thomas, david.marchand, ferruh.yigit, andrew.rybchenko,
	Jerin Jacob, stable

From: Jerin Jacob <jerinj@marvell.com>

aarch64 gcc 12.2.0 build complain with below warning[1].
Move the new_link initialization upwards to fix the warning.

Compiling C object drivers/libtmp_rte_net_hns3.a.p/net_hns3_hns3_ethdev.c.o
drivers/net/hns3/hns3_ethdev.c: In function ‘hns3_dev_link_update’:
drivers/net/hns3/hns3_ethdev.c:2249:1: warning: ‘new_link’ may be
used uninitialized [-Wmaybe-uninitialized]

Fixes: 64308555d5bf ("net/hns3: fix link status when port is stopped")
Cc: stable@dpdk.org

Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
 drivers/net/hns3/hns3_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c
index 36896f8989..a872cb8dd7 100644
--- a/drivers/net/hns3/hns3_ethdev.c
+++ b/drivers/net/hns3/hns3_ethdev.c
@@ -2257,6 +2257,7 @@ hns3_dev_link_update(struct rte_eth_dev *eth_dev, int wait_to_complete)
 	struct rte_eth_link new_link;
 	int ret;
 
+	memset(&new_link, 0, sizeof(new_link));
 	/* When port is stopped, report link down. */
 	if (eth_dev->data->dev_started == 0) {
 		new_link.link_autoneg = mac->link_autoneg;
@@ -2280,7 +2281,6 @@ hns3_dev_link_update(struct rte_eth_dev *eth_dev, int wait_to_complete)
 		rte_delay_ms(HNS3_LINK_CHECK_INTERVAL);
 	} while (retry_cnt--);
 
-	memset(&new_link, 0, sizeof(new_link));
 	hns3_setup_linkstatus(eth_dev, &new_link);
 
 out:
-- 
2.40.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net/hns3: fix build warning
  2023-04-04  6:55 [PATCH] net/hns3: fix build warning jerinj
@ 2023-04-04  8:22 ` Dongdong Liu
  2023-04-07 17:08   ` Ferruh Yigit
  0 siblings, 1 reply; 3+ messages in thread
From: Dongdong Liu @ 2023-04-04  8:22 UTC (permalink / raw)
  To: jerinj, dev, Yisen Zhuang, Huisong Li, Min Hu (Connor)
  Cc: thomas, david.marchand, ferruh.yigit, andrew.rybchenko, stable

Hi Jerin

Many thanks for fixing the warning.
On 2023/4/4 14:55, jerinj@marvell.com wrote:
> From: Jerin Jacob <jerinj@marvell.com>
>
> aarch64 gcc 12.2.0 build complain with below warning[1].
> Move the new_link initialization upwards to fix the warning.
>
> Compiling C object drivers/libtmp_rte_net_hns3.a.p/net_hns3_hns3_ethdev.c.o
> drivers/net/hns3/hns3_ethdev.c: In function ‘hns3_dev_link_update’:
> drivers/net/hns3/hns3_ethdev.c:2249:1: warning: ‘new_link’ may be
> used uninitialized [-Wmaybe-uninitialized]
It looks like a false positive from the logic of the code.
Anyway, this warning can be fixed by this patch, so
Acked-by: Dongdong Liu <liudongdong3@huawei.com>

Thanks,
Dongdong
>
> Fixes: 64308555d5bf ("net/hns3: fix link status when port is stopped")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> ---
>  drivers/net/hns3/hns3_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c
> index 36896f8989..a872cb8dd7 100644
> --- a/drivers/net/hns3/hns3_ethdev.c
> +++ b/drivers/net/hns3/hns3_ethdev.c
> @@ -2257,6 +2257,7 @@ hns3_dev_link_update(struct rte_eth_dev *eth_dev, int wait_to_complete)
>  	struct rte_eth_link new_link;
>  	int ret;
>
> +	memset(&new_link, 0, sizeof(new_link));
>  	/* When port is stopped, report link down. */
>  	if (eth_dev->data->dev_started == 0) {
>  		new_link.link_autoneg = mac->link_autoneg;
> @@ -2280,7 +2281,6 @@ hns3_dev_link_update(struct rte_eth_dev *eth_dev, int wait_to_complete)
>  		rte_delay_ms(HNS3_LINK_CHECK_INTERVAL);
>  	} while (retry_cnt--);
>
> -	memset(&new_link, 0, sizeof(new_link));
>  	hns3_setup_linkstatus(eth_dev, &new_link);
>
>  out:
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net/hns3: fix build warning
  2023-04-04  8:22 ` Dongdong Liu
@ 2023-04-07 17:08   ` Ferruh Yigit
  0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2023-04-07 17:08 UTC (permalink / raw)
  To: Dongdong Liu, jerinj, dev, Yisen Zhuang, Huisong Li, Min Hu (Connor)
  Cc: thomas, david.marchand, andrew.rybchenko, stable

On 4/4/2023 9:22 AM, Dongdong Liu wrote:
> Hi Jerin
> 
> Many thanks for fixing the warning.
> On 2023/4/4 14:55, jerinj@marvell.com wrote:
>> From: Jerin Jacob <jerinj@marvell.com>
>>
>> aarch64 gcc 12.2.0 build complain with below warning[1].
>> Move the new_link initialization upwards to fix the warning.
>>
>> Compiling C object
>> drivers/libtmp_rte_net_hns3.a.p/net_hns3_hns3_ethdev.c.o
>> drivers/net/hns3/hns3_ethdev.c: In function ‘hns3_dev_link_update’:
>> drivers/net/hns3/hns3_ethdev.c:2249:1: warning: ‘new_link’ may be
>> used uninitialized [-Wmaybe-uninitialized]
> It looks like a false positive from the logic of the code.
> Anyway, this warning can be fixed by this patch, so
> Acked-by: Dongdong Liu <liudongdong3@huawei.com>
> 

Agree that it looks false positive.
Moving memset upwards does unnecessary memset for some case but this can
be OK for control path function.

Applied to dpdk-next-net/main, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-04-07 17:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-04  6:55 [PATCH] net/hns3: fix build warning jerinj
2023-04-04  8:22 ` Dongdong Liu
2023-04-07 17:08   ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).