From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alln-iport-8.cisco.com (alln-iport-8.cisco.com [173.37.142.95]) by dpdk.org (Postfix) with ESMTP id 01C1F2BFA for ; Wed, 6 Apr 2016 15:49:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2858; q=dns/txt; s=iport; t=1459950571; x=1461160171; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=LyyJExWHiG2TC3+gyzoKEj2rdQXcTbboHiYy+wquJ+o=; b=QngHfzpc4e9uy1sKVGYo/ffhJY48miFNsWFNm5c2e3NfpuWIfslRRWlh XvWPtfGuqDvHsDGWWO0ZLBGGJmi4ELcrwPPcBtgbSe4XyzB5U2tu/arwt x0D5jLv0bhQd7FpxIL2JSLPIXyi3Iocpghr2Mqe/OTPfc6IVBpH3dQhfM w=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0D2AQDEEgVX/5tdJa1cgzdTfQa4PIIPA?= =?us-ascii?q?Q2BciGFbAKBRzgUAQEBAQEBAWUnhEEBAQEDAScTNAsMBAIBCBEEAQEfCQcyFAk?= =?us-ascii?q?IAgQOBQgMiAsIDsBZAQEBAQEBAQEBAQEBAQEBAQEBAQEBFYYhhEuKFQWTGIRpA?= =?us-ascii?q?YV1gi6FYII8jFmPIAEeAQFCggQZgUpsAQEBAYdxfgEBAQ?= X-IronPort-AV: E=Sophos;i="5.24,447,1454976000"; d="scan'208";a="258011999" Received: from rcdn-core-4.cisco.com ([173.37.93.155]) by alln-iport-8.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Apr 2016 13:49:29 +0000 Received: from XCH-ALN-018.cisco.com (xch-aln-018.cisco.com [173.36.7.28]) by rcdn-core-4.cisco.com (8.14.5/8.14.5) with ESMTP id u36DnT05009401 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 6 Apr 2016 13:49:29 GMT Received: from xch-rcd-016.cisco.com (173.37.102.26) by XCH-ALN-018.cisco.com (173.36.7.28) with Microsoft SMTP Server (TLS) id 15.0.1104.5; Wed, 6 Apr 2016 08:49:28 -0500 Received: from xch-rcd-016.cisco.com ([173.37.102.26]) by XCH-RCD-016.cisco.com ([173.37.102.26]) with mapi id 15.00.1104.009; Wed, 6 Apr 2016 08:49:28 -0500 From: "David Harton (dharton)" To: Thomas Monjalon , "Van Haaren, Harry" CC: "dev@dpdk.org" , "Tahhan, Maryam" , "olivier.matz@6wind.com" Thread-Topic: [dpdk-dev] [PATCH] doc: announce xstats api change for 16.07 Thread-Index: AQHRj2TCHVaDodkcJkq/Ch/b/fs4Fp98C8wAgADvZICAAAVvAIAAIAKAgAAQHID//8VNIA== Date: Wed, 6 Apr 2016 13:49:28 +0000 Message-ID: <9edf0e7ca1854e7cbb013359cb6423a8@XCH-RCD-016.cisco.com> References: <1459879089-3430-1-git-send-email-harry.van.haaren@intel.com> <27546869.TpcjJvEkXE@xps13> <23174662.vdJtoqjRUU@xps13> In-Reply-To: <23174662.vdJtoqjRUU@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.82.246.152] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: announce xstats api change for 16.07 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2016 13:49:31 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, April 06, 2016 8:14 AM > To: Van Haaren, Harry > Cc: David Harton (dharton) ; dev@dpdk.org; Tahhan, > Maryam ; olivier.matz@6wind.com > Subject: Re: [dpdk-dev] [PATCH] doc: announce xstats api change for 16.07 >=20 > 2016-04-06 11:16, Van Haaren, Harry: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > > The issue we are going to fix is that currently PMDs copy strings > > > > when retrieving > > > statistics, which causes unnecessary overhead. The implementation is > > > not decided yet, but using an int->value mapping seems logical. > > > > > I am not sure performance is so much critical when retrieving > statistics. > > > > In the previous discussion David was concerned about performance > > impact of string copies, are those concerns still present David? > > > > > The extended stats can be infinitely extended. So a string > > > identifier seems a lot more natural. > > > > I'm not suggesting that the string identifier is removed totally. > > > > > I do not agree to add a new numeric identifier in the API each time > > > a driver wants to report a specific statistic for debugging purpose. > > > > And I agree - the ints are just an index to xstats arrays, no eth-dev > wide enums here. Yes, I abandoned the idea of a set of stats ids. I can see where registrat= ion will be problematic and cumbersome to driver developers. > > The proposal is to make the API more flexible, see example: > > http://thread.gmane.org/gmane.comp.networking.dpdk.devel/31728/focus=3D= 3 > > 2795 > > > > This more flexible API would allow other types of information about > > statistics be retrieved too. I have prototyped this. If there is interest/acceptance I can work on maki= ng an official patch to share back to the community. Using this method still gives the flexibility the current API desires while= giving the user the control to only obtain the counters. This of course a= ssumes that the counters per device are static but that seems a safe bet. >=20 > OK I think I start to understand. >=20 > > For now, the sent patch announces that the API/ABI may change, and we > > can discuss details of API as development starts. >=20 > This should not be the normal process. > It is important to understand what should be the changes to decide of > announcing or not a deprecation. > In the case of the mempool reworks, the patch have been sent and discusse= d > on the mailing list. > Given the previous explanations (and knowing you did good job on stats), = I > give my > Acked-by: Thomas Monjalon Thanks for considering this. Regards, Dave