From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id D70E7DE0 for ; Mon, 4 Jun 2018 16:32:40 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4E35440267CB; Mon, 4 Jun 2018 14:32:40 +0000 (UTC) Received: from [10.36.112.47] (ovpn-112-47.ams2.redhat.com [10.36.112.47]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 86D091C726; Mon, 4 Jun 2018 14:32:39 +0000 (UTC) To: Tiwei Bie Cc: zhihong.wang@intel.com, dev@dpdk.org References: <20180601124758.22652-1-maxime.coquelin@redhat.com> <20180601124758.22652-4-maxime.coquelin@redhat.com> <20180604115903.GB21406@debian> From: Maxime Coquelin Message-ID: <9efa2c4c-a391-49d1-2444-7c1a70468a71@redhat.com> Date: Mon, 4 Jun 2018 16:32:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180604115903.GB21406@debian> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Mon, 04 Jun 2018 14:32:40 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Mon, 04 Jun 2018 14:32:40 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH 3/4] net/virtio: don't use simple Rx path if TCP LRO requested X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jun 2018 14:32:41 -0000 On 06/04/2018 01:59 PM, Tiwei Bie wrote: > On Fri, Jun 01, 2018 at 02:47:57PM +0200, Maxime Coquelin wrote: >> Signed-off-by: Maxime Coquelin >> --- >> drivers/net/virtio/virtio_ethdev.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c >> index 5730620ed..d481b282e 100644 >> --- a/drivers/net/virtio/virtio_ethdev.c >> +++ b/drivers/net/virtio/virtio_ethdev.c >> @@ -1893,7 +1893,8 @@ virtio_dev_configure(struct rte_eth_dev *dev) >> } >> >> if (rx_offloads & (DEV_RX_OFFLOAD_UDP_CKSUM | >> - DEV_RX_OFFLOAD_TCP_CKSUM)) >> + DEV_RX_OFFLOAD_TCP_CKSUM | >> + DEV_RX_OFFLOAD_TCP_LRO)) > > Maybe we also need to consider not using simple Rx > when DEV_RX_OFFLOAD_VLAN_STRIP is requested. I think that makes sense. Thanks, Maxime > Best regards, > Tiwei Bie > >> hw->use_simple_rx = 0; >> >> if (tx_offloads & (DEV_TX_OFFLOAD_TCP_CKSUM | >> -- >> 2.14.3 >>