DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: "Wang, Yinan" <yinan.wang@intel.com>,
	"Ding, Xuan" <xuan.ding@intel.com>,
	 "Wang, Zhihong" <zhihong.wang@intel.com>,
	"Ye, Xiaolong" <xiaolong.ye@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] vhost: zero_copy incompatible with client mode
Date: Wed, 29 Apr 2020 10:46:25 +0200	[thread overview]
Message-ID: <9f1579ee-a4fd-106f-10e6-bb414b324cbf@redhat.com> (raw)
In-Reply-To: <aed49368a922487b96057a58f09f7674@intel.com>

Hi Yinan,

On 4/29/20 10:33 AM, Wang, Yinan wrote:
> Tested-by: Yinan Wang <yinan.wang@intel.com>

Thanks for running tests on Vhost patches, that's much appreciated.

Could you provide more information on the test run?
Does it consist in reproducing the issue the patch is aiming to fix,
apply patch and check issue is fixed?
Or does it consist in running a generic Vhost/Virtio test suite?

Regards,
Maxime

>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Xuan Ding
>> Sent: 2020年4月29日 11:00
>> To: maxime.coquelin@redhat.com; Wang, Zhihong <zhihong.wang@intel.com>;
>> Ye, Xiaolong <xiaolong.ye@intel.com>
>> Cc: dev@dpdk.org; Ding, Xuan <xuan.ding@intel.com>
>> Subject: [dpdk-dev] [PATCH] vhost: zero_copy incompatible with client mode
>>
>> In server mode, virtio-user inits under the assumption that vhost-user supports a
>> list of features. However, this could be problematic when in_order feature is
>> negotiated but not supported by vhost-user when enables dequeue_zero_copy
>> later.
>>
>> Add handling when vhost-user enables dequeue_zero_copy as client.
>>
>> Signed-off-by: Xuan Ding <xuan.ding@intel.com>
>> ---
>>  lib/librte_vhost/socket.c | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c index
>> 7c8012179..bb8d0d780 100644
>> --- a/lib/librte_vhost/socket.c
>> +++ b/lib/librte_vhost/socket.c
>> @@ -926,6 +926,12 @@ rte_vhost_driver_register(const char *path, uint64_t
>> flags)
>>  			ret = -1;
>>  			goto out_mutex;
>>  		}
>> +		if (!vsocket->is_server) {
>> +			VHOST_LOG_CONFIG(ERR,
>> +			"error: zero copy is incompatible with vhost client
>> mode\n");
>> +			ret = -1;
>> +			goto out_mutex;
>> +		}
>>  		vsocket->supported_features &= ~(1ULL <<
>> VIRTIO_F_IN_ORDER);
>>  		vsocket->features &= ~(1ULL << VIRTIO_F_IN_ORDER);
>>
>> --
>> 2.17.1
> 


  reply	other threads:[~2020-04-29  8:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29  2:59 Xuan Ding
2020-04-29  8:33 ` Wang, Yinan
2020-04-29  8:46   ` Maxime Coquelin [this message]
2020-04-29 11:48 ` Maxime Coquelin
2020-04-30  8:13 ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9f1579ee-a4fd-106f-10e6-bb414b324cbf@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=dev@dpdk.org \
    --cc=xiaolong.ye@intel.com \
    --cc=xuan.ding@intel.com \
    --cc=yinan.wang@intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).