From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB8D043A35; Thu, 1 Feb 2024 11:56:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6F14B402A7; Thu, 1 Feb 2024 11:56:27 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2068.outbound.protection.outlook.com [40.107.220.68]) by mails.dpdk.org (Postfix) with ESMTP id D88AF40299 for ; Thu, 1 Feb 2024 11:56:25 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oRx3JgTR2f9LMoz9CdUpWIiI8uZ55FazGcnhG+xmkB+ytT5Qwvi+bZa8LvrS1RGdyczvFfqwyE0PyoZbAXwZMVWzXHkDOXThd7Yn/me43iH+LqtyCMQ4LFCxiBXBAFbhuQXzpxsGGLDmS4N9MGGxRHwE6pzTeI1dnii/7WuedIOspsM2jD/OfLh/vY9b6iXgJgmr8fdr4lkQv0DwrWF/id9Fu4gEgAILIPpIMLpkaSxDUi965vcw5UtqP74nH/nwZU7m1FxxbAIp+zy//BNO8ftWQN4dfSOByReigdvAZhHYHgUHDNm7HN3F70ugy5Imj9xHuJmxAJJzLhJ0CqaVHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qI2vOC5gwTPAu5BnrU+LOR3YF3UgAFtdQl+y5Ds5zwk=; b=aSi3KPoe3AF3cCeoUP9xHNnNdKT9A4KSZ2jCvbNU+f4aEqp9ge78zOT9vWAD+0xN3n1LoXJmj2xNH7WSwHuC8Tm7YSxIMMbAQvwVYmYQflo1EhIq9uv4pygKxIHFFKGOkk1j/7cOMwSAWy/IyKVgArwH+zSRxErszXRbVvYxdV3tHPGV9bSsohGzLLflqZFoGScKzcSWMDxH33aL28T6BMpivnOqTTSGt89duij6AAYgGV3/A6Cn29PSLg39/goqZPyAdd+oOGB+Xog260ZK41EJSG2WFKmh4Y2sHYi+6O7hujwMMszivNcnGqbLtVVMOoeRACAmSB3t7C1pVQs0MA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qI2vOC5gwTPAu5BnrU+LOR3YF3UgAFtdQl+y5Ds5zwk=; b=TzqgLqQhj2MCRHX5MrRqxg1e0ROhCHIjArhzhWXrJOcpV9UTuNSm2JMVUzHJXpd4x3I9dNUY/bWaw8Vx2PAYslOR9r+m4mQcRV6X/DHmKZlOlI6/LYtL/IA9kTO/LgT+QUKHylmPGobelfr0gyl5nXxfiCED7lqxzs0zGSU3cn0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA1PR12MB7319.namprd12.prod.outlook.com (2603:10b6:806:2b5::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.24; Thu, 1 Feb 2024 10:56:22 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7270.010; Thu, 1 Feb 2024 10:56:22 +0000 Message-ID: <9f2c9c9a-9a7f-404a-859e-ce68f2a56c15@amd.com> Date: Thu, 1 Feb 2024 10:56:16 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] ethdev: rename action modify field data structure Content-Language: en-US To: Suanming Mou , Ori Kam , Aman Singh , Yuying Zhang , Dariusz Sosnowski , Slava Ovsiienko , Matan Azrad , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Andrew Rybchenko Cc: "dev@dpdk.org" References: <20231219013337.531548-1-suanmingm@nvidia.com> <20240115091318.1053433-1-suanmingm@nvidia.com> <20240115091318.1053433-2-suanmingm@nvidia.com> <9e38221e-285c-4cf6-a170-c3ee2f8b1786@amd.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0166.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:312::10) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA1PR12MB7319:EE_ X-MS-Office365-Filtering-Correlation-Id: e80fae9e-a194-4714-2d9d-08dc23146d90 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Rmt4j/kTPbFOBVLg8cnFOFSS5DTeRBGFVuNxvI6rGlfOxs84nAlTu9Yx9YM8BJJK4E2d2X9MYieuWIR+hnfa6E13IMPM9Zj23zokXBIJEbIPptLykOO9mjvbMyepDFswGVPEu7veXop0fZFeqkGRs4T7uPZqqq6SivfI20pBHq7k+hz+9lK2WjjJfLyak+uiX8WDb61jMkytGDXt20Ve2EK9F8+ncwJOysyJbIZTAK3hEKWSTRIbx5ZqRyVCu8x5ZRUKY4nzlTn6fAjN7lGd334ogcr4jm94cW7NG5D/Vfa5p/fCE0e8trcAGz1UKm0I5W9M/eJVV6sMiLGfHV2C0EkqzNfIabCJwQg4g1Jj3C8HjmBh2XO6v2LNEoNVoK0ZS0gykaHqknPXz9LKPFyQpIQUV7Up7HcQj2eSvtW3BckAKjeTLIExFnNwk0CwHVCL3vtdsoz88f8nfbJmSK1KZE1YVwYhh5baI6/Hhr63orGnYEv5ZsuxYGhQlJJ5rPeTtQtvmgPNh5s6RTQTqC/Ihyzx6X7+H6AoCcwmg0gbpS+HS0QsdN80I4ZyV4QmKNZek0jcRN4mBo6op3hfJ7oQ8vKnlU7tu5S9MUhoSoVf12PALcylcpl3ng2aGXbkiK13InaCZc0lmtHrwpJ446AUCPYN53flgPcWNuI4VPXPLA0ObLggO7v02miQbnf6TKW+ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(346002)(39860400002)(366004)(376002)(396003)(230922051799003)(230173577357003)(230273577357003)(1800799012)(451199024)(186009)(64100799003)(66556008)(7416002)(44832011)(2906002)(5660300002)(31696002)(86362001)(6486002)(38100700002)(36756003)(6506007)(478600001)(53546011)(41300700001)(6512007)(83380400001)(26005)(2616005)(6666004)(8936002)(316002)(8676002)(4326008)(66946007)(110136005)(31686004)(66476007)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TGxTVUJoTzZNdE5iM0lvZWp1SEdGQ0lpREhTUTFORFpLQklXRC9tQitmY0NN?= =?utf-8?B?K1JrM3N1N0VtbExnYW5aZEtRZjdkT0RrVUdvYm54RzVzbVgzRDJPM3BtVGxY?= =?utf-8?B?VHYyWXF5RkRpcTdkOWd2dlRBNDFnUmRSOWlrYk50c1Nxd3h4amw4NlUyd0VZ?= =?utf-8?B?bXJXTTRqUHM2MTY1Mkw1OTBkeE4wY0lCZXJwYlhvcm9OZWtHL2FRTHdQWmpK?= =?utf-8?B?VmpXN2pJZ3hyNWtndDJuNE90cnFMcVBiUC84VXBZYnpJU0twZlJiR1dXeUE1?= =?utf-8?B?M1ZKSEpMMlZWVUxZSnluQVl5SGlpblVYRU9FY0tSSURSaGgxVjVaeDFYbUs5?= =?utf-8?B?K2JFNnp0a3FxNkh6WUFlb3JaL2V4aDEzWG5rUkJZMFJXWURKdWRsOWhGd2RK?= =?utf-8?B?SlhZUjBDYnNYWS9mcTRvU3ZMbkprdTBHcloxeEJ4VnZIY3R1TzlLaVduRzg2?= =?utf-8?B?MzJYMy92V3d4MXRsUjkwMDkvVXlmaTVtdVYrdjhUeE5MbEk1V1g5WVNBQzhJ?= =?utf-8?B?NmliUVBNQkVNaGZlR0ZMbGRqL3JHaEJQbk1EeGN1T2ZSWlBJdFYrZU9ML2F2?= =?utf-8?B?Z2NURDJValBBT1Rlem1CSEhjWDhZRERUZjluQ3REMnYvRlZmTG9FOE9ReHQw?= =?utf-8?B?U1dFazhERzJxZDNScVdvY2IrZS9saVpJemg1YXBVUHRVOHVTclJBS09KT3Er?= =?utf-8?B?dllleEl2OW8vUVNjazF4R0pSRlU0TU9uUGJQc1RucERMYjBnUm84UTJQWjVS?= =?utf-8?B?MVFDbjY3Y2V6QTZaQWZESWtwOVZ2T0ppaWw0T28xYldzd1RZSmZQTXc0Mk9Y?= =?utf-8?B?Y0N3Zy90MlZDTU5FV2c1anJways3UE4zWE50VitOQWhCYkI1U3dsZ053Q1p3?= =?utf-8?B?dEQzMkZ2KzdFZGhSZGVSVmh0SzljUHJTc2wzVGtZRDdBbXhMdGFBeGJwQVhk?= =?utf-8?B?ckNwWHNTdHhza1pWRmNwd0JLL1BndjhRc3hlWkhzUjdmUTZGaEdVY2lKV3BY?= =?utf-8?B?bWdoOGhneHNWeTk0TjlwKzBVSFM0Z1JQZXRIZnRQZlJhdGs2cGY3L1d0ZEEy?= =?utf-8?B?bEpMUHFtWEhlbHJJbkdqZnBEbzBTQmRaSGVTK3RWeXg4ZG1GRWFQMGRqQ0xw?= =?utf-8?B?VUtVbGNBZlB3cStYRzhLUXp3NXZPWnhyZkM0Qlh2YjFnMVRwcCsvc2p5T2l2?= =?utf-8?B?cG9sMlZJdGUreVYxT0M5OFVPc0dUWitXQVJWZkxyYllMY0x6alRGTkJ4cmk0?= =?utf-8?B?VFdBRHZvNzhyR0NKbXNDZW1PaGtzY0duMHFpbWo4NmVYNk1KUnh3cG9kNXZ6?= =?utf-8?B?elkxekI0ZG5pbWhXbFVjY1V4N1B2WWtob0VIeVJUOHVIMEhPWlA1L2FOQkJr?= =?utf-8?B?K3hmaE4vRmlSNzFac2xydW4rSlB0NUx1V3ZYTkRLMVBqQktSOXZvS2JKMDlG?= =?utf-8?B?dGlobDRod2Zya3ArNGZZMVd6REhCUXBHUk1GeFZwc3QwRjNoL3RhYVpDQTcz?= =?utf-8?B?ZlNkV0RIVGFGbW56c2U4VXg3T1o5UkZrQWlsb2RnekFMQXVNU3JHVDl5TFIx?= =?utf-8?B?QTcveE5UZ2lOQzBLWEw2R1cwVytVT1grWUNUanl0OXRPSngxWGxPR3ZBTzM5?= =?utf-8?B?MnlDSytxNWdPYVNBUVJPM0E1MURRTXVWTDQya1VIRVRjUFFWb09Sc3IrQTUz?= =?utf-8?B?M01zOURNRFZOZGFZbzFFbWJJajY4MU1jZmRQQmpBUVBlZm1iVG1QYlNoeWJx?= =?utf-8?B?RHJlbkFGeXdWSlV6K0E4dnNQQWNwUTkzNHU2TGR4V2FHTHNQd000Y0dPQWE5?= =?utf-8?B?dkVBWU1rdEhVZEl1U2pFM0xVWWhaWUl5dzJhZS9tL0tsS1NTZmJ2ZTZNZUhH?= =?utf-8?B?RStaUVlpQ29zaHNNSWNKUm85S2Zob1FTTDArenFvYWhBK25UdStPTjRkNFRM?= =?utf-8?B?N3dWNkZmcTdOZDRlbWdWc3JzNmoyVFl0ZCs1T3RmTUVzVzZIRG55eG1CTlZG?= =?utf-8?B?N3Ftd0pRTS90aVM3YWkvQUExWlAweVdpeVNKK24xSkVEUHhpWklCQk5xOFJ5?= =?utf-8?B?bTlxT0QxZ1M4MTZNWTdiQjlzTTZUUjU3VkdJSThnZXcwVTByWUIyMFhGbEpN?= =?utf-8?Q?SyPHFWUO+o22y/+5aecn30vPP?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: e80fae9e-a194-4714-2d9d-08dc23146d90 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2024 10:56:22.6673 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VL/QvJgxxniQ67uNVopPbZ9MSiCvt7xc6aYoL13ZnBYDbLsyoknDaKF/lSW+2NPE X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7319 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/31/2024 2:57 AM, Suanming Mou wrote: > Hi, > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Wednesday, January 31, 2024 1:19 AM >> To: Suanming Mou ; Ori Kam ; >> Aman Singh ; Yuying Zhang >> ; Dariusz Sosnowski ; Slava >> Ovsiienko ; Matan Azrad ; NBU- >> Contact-Thomas Monjalon (EXTERNAL) ; Andrew >> Rybchenko >> Cc: dev@dpdk.org >> Subject: Re: [PATCH v3 1/3] ethdev: rename action modify field data structure >> >> On 1/15/2024 9:13 AM, Suanming Mou wrote: >>> Current rte_flow_action_modify_data struct describes the pkt field >>> perfectly and is used only in action. >>> >>> It is planned to be used for item as well. This commit renames it to >>> "rte_flow_field_data" making it compatible to be used by item. >>> >> >> ack to rename struct to use in pattern. >> >>> Signed-off-by: Suanming Mou >>> Acked-by: Ori Kam >>> Acked-by: Andrew Rybchenko >>> --- >>> app/test-pmd/cmdline_flow.c | 2 +- >>> doc/guides/prog_guide/rte_flow.rst | 2 +- >>> doc/guides/rel_notes/release_24_03.rst | 1 + >>> drivers/net/mlx5/mlx5_flow.c | 4 ++-- >>> drivers/net/mlx5/mlx5_flow.h | 6 +++--- >>> drivers/net/mlx5/mlx5_flow_dv.c | 10 +++++----- >>> lib/ethdev/rte_flow.h | 8 ++++---- >>> 7 files changed, 17 insertions(+), 16 deletions(-) >>> >>> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c >>> index ce71818705..3725e955c7 100644 >>> --- a/app/test-pmd/cmdline_flow.c >>> +++ b/app/test-pmd/cmdline_flow.c >>> @@ -740,7 +740,7 @@ enum index { >>> #define ITEM_RAW_SIZE \ >>> (sizeof(struct rte_flow_item_raw) + ITEM_RAW_PATTERN_SIZE) >>> >>> -/** Maximum size for external pattern in struct >>> rte_flow_action_modify_data. */ >>> +/** Maximum size for external pattern in struct rte_flow_field_data. >>> +*/ >>> #define ACTION_MODIFY_PATTERN_SIZE 32 >>> >> >> What do you think to update 'ACTION_MODIFY_PATTERN_SIZE' here too, instead >> of next patch? > > Agree. > >> >> <...> >> >>> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index >>> affdc8121b..40f6dcaacd 100644 >>> --- a/lib/ethdev/rte_flow.h >>> +++ b/lib/ethdev/rte_flow.h >>> @@ -3910,9 +3910,9 @@ enum rte_flow_field_id { >>> * @warning >>> * @b EXPERIMENTAL: this structure may change without prior notice >>> * >>> - * Field description for MODIFY_FIELD action. >>> + * Field description for packet field. >>> >> >> New note is not very helpful, how can we make it more useful? >> >> Does it make sense to keep 'MODIFY_FIELD' and add 'COMPARE ITEM' in next >> patch, to clarify the intended usage for the struct, otherwise it is too generic. > > OK, sorry, the purpose is to make it generic. So next time if other ITEM or ACTION need that field, it can be used directly. > Otherwise, it feels like it can only be used by 'MODIFY_FIELD' and 'COMPARE_ITEM', what do you think? > I don't have an intention to limit its usage, but to clarify usage for whoever checks the document. "Field description for packet field." doesn't say what exactly it is and cause confusion. Perhaps wording can be changed to say two possible usages are for 'MODIFY_FIELD' and 'COMPARE_ITEM'?