From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <declan.doherty@intel.com> Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 9FF261B10C for <dev@dpdk.org>; Tue, 11 Dec 2018 18:25:59 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2018 09:25:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,343,1539673200"; d="scan'208";a="97926118" Received: from dwdohert-mobl.ger.corp.intel.com (HELO [163.33.176.66]) ([163.33.176.66]) by orsmga007.jf.intel.com with ESMTP; 11 Dec 2018 09:25:48 -0800 To: Konstantin Ananyev <konstantin.ananyev@intel.com>, dev@dpdk.org Cc: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com> References: <1543596366-22617-2-git-send-email-konstantin.ananyev@intel.com> <1544110714-4514-6-git-send-email-konstantin.ananyev@intel.com> From: "Doherty, Declan" <declan.doherty@intel.com> Message-ID: <9f33412e-9c4c-6e98-758e-072a3640a0e7@intel.com> Date: Tue, 11 Dec 2018 17:25:46 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.3 MIME-Version: 1.0 In-Reply-To: <1544110714-4514-6-git-send-email-konstantin.ananyev@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 5/9] ipsec: add SA data-path API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 11 Dec 2018 17:26:00 -0000 On 06/12/2018 3:38 PM, Konstantin Ananyev wrote: > Introduce Security Association (SA-level) data-path API > Operates at SA level, provides functions to: > - initialize/teardown SA object > - process inbound/outbound ESP/AH packets associated with the given SA > (decrypt/encrypt, authenticate, check integrity, > add/remove ESP/AH related headers and data, etc.). > > Signed-off-by: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com> > Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com> > --- ... > +#ifndef _RTE_IPSEC_H_ > +#define _RTE_IPSEC_H_ > + > +/** > + * @file rte_ipsec.h > + * @b EXPERIMENTAL: this API may change without prior notice > + * > + * RTE IPsec support. > + * librte_ipsec provides a framework for data-path IPsec protocol > + * processing (ESP/AH). > + * IKEv2 protocol support right now is out of scope of that draft. > + * Though it tries to define related API in such way, that it could be adopted > + * by IKEv2 implementation. > + */ I think you can drop the IKE note from the header as key exchange is covered under a complete different RFC to the base IPsec one. > + > +#include <rte_ipsec_sa.h> > +#include <rte_mbuf.h> > + ... > Acked-by: Declan Doherty <declan.doherty@intel.com>