From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F78FA04B5; Mon, 11 Jan 2021 22:29:27 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C5F61140CFC; Mon, 11 Jan 2021 22:29:26 +0100 (CET) Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by mails.dpdk.org (Postfix) with ESMTP id 8901D140CFB; Mon, 11 Jan 2021 22:29:25 +0100 (CET) Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 10BL2TT5120829; Mon, 11 Jan 2021 16:29:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=KJRml53FqIFmEsW4vNCpI3sMyywqqHmytJPr3lRZhUk=; b=dZb64pm3928BetatsEAQSo+tV55Gy3H/m/0syNhMQfRh+MDFIA7LDCUXHr+y4R0cyP7/ mmfSMDlc+/4PGNJEEyl4ZX7qXDrCjocCyPGaSLoa3WBW2Q7m9b67e/oLA2OHBxV9QCo0 OOUaacS0O9/t+su1AFt7wSWEfH+VdZgj2DuSX4AKeqKmrm3bSHfuXrTejM8daffgP4sD /+MXd+SHgO+4DRwaSKQDj8zkietYkZnzYekiaHgncm3QE6oMPDaEdkFqOSZH47KZrX62 M3u+MRz+I+TjUvf26SIBe8i733Ox83uqv0MrhVrKPk0empFrZnYiebTxYBhLY6eXZo2I BQ== Received: from ppma02dal.us.ibm.com (a.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.10]) by mx0a-001b2d01.pphosted.com with ESMTP id 360x4j8tda-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 11 Jan 2021 16:29:21 -0500 Received: from pps.filterd (ppma02dal.us.ibm.com [127.0.0.1]) by ppma02dal.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 10BLC1FM020563; Mon, 11 Jan 2021 21:29:21 GMT Received: from b03cxnp08026.gho.boulder.ibm.com (b03cxnp08026.gho.boulder.ibm.com [9.17.130.18]) by ppma02dal.us.ibm.com with ESMTP id 35y4495sk8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 11 Jan 2021 21:29:21 +0000 Received: from b03ledav006.gho.boulder.ibm.com (b03ledav006.gho.boulder.ibm.com [9.17.130.237]) by b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 10BLTKVW20644264 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 11 Jan 2021 21:29:20 GMT Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 171E3C6059; Mon, 11 Jan 2021 21:29:20 +0000 (GMT) Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 75D3EC6057; Mon, 11 Jan 2021 21:29:19 +0000 (GMT) Received: from Davids-MBP.randomparity.org (unknown [9.163.92.50]) by b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTP; Mon, 11 Jan 2021 21:29:19 +0000 (GMT) To: Ruifeng Wang , Bruce Richardson , Vladimir Medvedkin , Chao Zhu , Gowrishankar Muthukrishnan Cc: dev@dpdk.org, nd@arm.com, jerinj@marvell.com, honnappa.nagarahalli@arm.com, stable@dpdk.org References: <20210108082127.1061538-1-ruifeng.wang@arm.com> <20210108082127.1061538-4-ruifeng.wang@arm.com> From: David Christensen Message-ID: <9f3ebbdb-8843-9f36-5b70-5e5c0d2e374d@linux.vnet.ibm.com> Date: Mon, 11 Jan 2021 13:29:18 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210108082127.1061538-4-ruifeng.wang@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2021-01-11_30:2021-01-11, 2021-01-11 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 clxscore=1011 malwarescore=0 impostorscore=0 mlxlogscore=999 adultscore=0 suspectscore=0 spamscore=0 mlxscore=0 bulkscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101110115 Subject: Re: [dpdk-dev] [PATCH 3/4] lpm: fix vector lookup for ppc64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/8/21 12:21 AM, Ruifeng Wang wrote: > rte_lpm_lookupx4 could return wrong next hop when more than 256 tbl8 > groups are created. This is caused by incorrect type casting of tbl8 > group index that been stored in tbl24 entry. The casting caused group > index truncation and hence wrong tbl8 group been searched. > > Issue fixed by applying proper mask to tbl24 entry to get tbl8 group index. > > Fixes: d2cc7959342b ("lpm: add AltiVec for ppc64") > Cc: gowrishankar.m@linux.vnet.ibm.com > Cc: stable@dpdk.org > > Signed-off-by: Ruifeng Wang > --- > lib/librte_lpm/rte_lpm_altivec.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/lib/librte_lpm/rte_lpm_altivec.h b/lib/librte_lpm/rte_lpm_altivec.h > index 228c41b38..4fbc1b595 100644 > --- a/lib/librte_lpm/rte_lpm_altivec.h > +++ b/lib/librte_lpm/rte_lpm_altivec.h > @@ -88,28 +88,28 @@ rte_lpm_lookupx4(const struct rte_lpm *lpm, xmm_t ip, uint32_t hop[4], > if (unlikely((pt & RTE_LPM_VALID_EXT_ENTRY_BITMASK) == > RTE_LPM_VALID_EXT_ENTRY_BITMASK)) { > i8.u32[0] = i8.u32[0] + > - (uint8_t)tbl[0] * RTE_LPM_TBL8_GROUP_NUM_ENTRIES; > + (tbl[0] & 0x00FFFFFF) * RTE_LPM_TBL8_GROUP_NUM_ENTRIES; > ptbl = (const uint32_t *)&lpm->tbl8[i8.u32[0]]; > tbl[0] = *ptbl; > } > if (unlikely((pt >> 32 & RTE_LPM_VALID_EXT_ENTRY_BITMASK) == > RTE_LPM_VALID_EXT_ENTRY_BITMASK)) { > i8.u32[1] = i8.u32[1] + > - (uint8_t)tbl[1] * RTE_LPM_TBL8_GROUP_NUM_ENTRIES; > + (tbl[1] & 0x00FFFFFF) * RTE_LPM_TBL8_GROUP_NUM_ENTRIES; > ptbl = (const uint32_t *)&lpm->tbl8[i8.u32[1]]; > tbl[1] = *ptbl; > } > if (unlikely((pt2 & RTE_LPM_VALID_EXT_ENTRY_BITMASK) == > RTE_LPM_VALID_EXT_ENTRY_BITMASK)) { > i8.u32[2] = i8.u32[2] + > - (uint8_t)tbl[2] * RTE_LPM_TBL8_GROUP_NUM_ENTRIES; > + (tbl[2] & 0x00FFFFFF) * RTE_LPM_TBL8_GROUP_NUM_ENTRIES; > ptbl = (const uint32_t *)&lpm->tbl8[i8.u32[2]]; > tbl[2] = *ptbl; > } > if (unlikely((pt2 >> 32 & RTE_LPM_VALID_EXT_ENTRY_BITMASK) == > RTE_LPM_VALID_EXT_ENTRY_BITMASK)) { > i8.u32[3] = i8.u32[3] + > - (uint8_t)tbl[3] * RTE_LPM_TBL8_GROUP_NUM_ENTRIES; > + (tbl[3] & 0x00FFFFFF) * RTE_LPM_TBL8_GROUP_NUM_ENTRIES; > ptbl = (const uint32_t *)&lpm->tbl8[i8.u32[3]]; > tbl[3] = *ptbl; > } > Tested-by: David Christensen