From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 14E394594F;
	Tue, 10 Sep 2024 02:50:56 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id D34FF4021F;
	Tue, 10 Sep 2024 02:50:55 +0200 (CEST)
Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32])
 by mails.dpdk.org (Postfix) with ESMTP id 32FD340151
 for <dev@dpdk.org>; Tue, 10 Sep 2024 02:50:53 +0200 (CEST)
Received: from mail.maildlp.com (unknown [172.19.163.17])
 by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4X2lVy2PH8z1xxC7;
 Tue, 10 Sep 2024 08:50:50 +0800 (CST)
Received: from dggpeml500024.china.huawei.com (unknown [7.185.36.10])
 by mail.maildlp.com (Postfix) with ESMTPS id D4F1A1A0188;
 Tue, 10 Sep 2024 08:50:51 +0800 (CST)
Received: from [10.67.121.161] (10.67.121.161) by
 dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2507.39; Tue, 10 Sep 2024 08:50:51 +0800
Subject: Re: [PATCH v4 1/6] dpdk: do not force C linkage on include file
 dependencies
To: =?UTF-8?Q?Mattias_R=c3=b6nnblom?= <mattias.ronnblom@ericsson.com>,
 <dev@dpdk.org>
CC: <hofors@lysator.liu.se>, Heng Wang <heng.wang@ericsson.com>, Stephen
 Hemminger <stephen@networkplumber.org>, Tyler Retzlaff
 <roretzla@linux.microsoft.com>, =?UTF-8?Q?Morten_Br=c3=b8rup?=
 <mb@smartsharesystems.com>, Jack Bond-Preston
 <jack.bond-preston@foss.arm.com>, David Marchand <david.marchand@redhat.com>
References: <20240812124930.604796-2-mattias.ronnblom@ericsson.com>
 <20240909145743.697342-1-mattias.ronnblom@ericsson.com>
 <20240909145743.697342-2-mattias.ronnblom@ericsson.com>
From: fengchengwen <fengchengwen@huawei.com>
Message-ID: <9f430520-3ded-d7bc-42a6-87dd9443dabe@huawei.com>
Date: Tue, 10 Sep 2024 08:50:51 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <20240909145743.697342-2-mattias.ronnblom@ericsson.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.67.121.161]
X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To
 dggpeml500024.china.huawei.com (7.185.36.10)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 2024/9/9 22:57, Mattias Rönnblom wrote:
> diff --git a/lib/dmadev/rte_dmadev.h b/lib/dmadev/rte_dmadev.h
> index 5474a5281d..11b72b0f2d 100644
> --- a/lib/dmadev/rte_dmadev.h
> +++ b/lib/dmadev/rte_dmadev.h
> @@ -149,10 +149,6 @@
>  #include <rte_bitops.h>
>  #include <rte_common.h>
>  
> -#ifdef __cplusplus
> -extern "C" {
> -#endif
> -
>  /** Maximum number of devices if rte_dma_dev_max() is not called. */
>  #define RTE_DMADEV_DEFAULT_MAX 64

There are many C functions declaration in this region, we should wrap it
by extern "C" {}, so let's keep or add like:

#include "rte_dmadev_core.h"
#ifdef __cplusplus
    }
#endif

#include "rte_dmadev_trace_fp.h"

#ifdef __cplusplus
    extern "C" {
#endif

>  
> @@ -775,6 +771,10 @@ struct rte_dma_sge {
>  #include "rte_dmadev_core.h"
>  #include "rte_dmadev_trace_fp.h"
>  
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
>  /**@{@name DMA operation flag
>   * @see rte_dma_copy()
>   * @see rte_dma_copy_sg()