* [dpdk-dev] [PATCH] app/testpmd: fix potential memory leak
@ 2017-11-02 10:13 Kirill Rybalchenko
2017-11-07 7:06 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Kirill Rybalchenko @ 2017-11-02 10:13 UTC (permalink / raw)
To: dev; +Cc: kirill.rybalchenko, andrey.chilikin, jingjing.wu
Fix potential memory leak in cmd_ddp_info_parsed() function.
Fixes: a8e005696c7b ("app/testpmd: get ddp profile protocol info")
Signed-off-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
---
app/test-pmd/cmdline.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 3b691fe..eb044e7 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -14362,7 +14362,7 @@ cmd_ddp_info_parsed(
uint32_t dev_num = 0;
struct rte_pmd_i40e_ddp_device_id *devs;
uint32_t proto_num = 0;
- struct rte_pmd_i40e_proto_info *proto;
+ struct rte_pmd_i40e_proto_info *proto = NULL;
uint32_t pctype_num = 0;
struct rte_pmd_i40e_ptype_info *pctype;
uint32_t ptype_num = 0;
@@ -14541,9 +14541,10 @@ cmd_ddp_info_parsed(
free(ptype);
printf("\n");
- free(proto);
ret = 0;
no_print_return:
+ if (proto)
+ free(proto);
#endif
if (ret == -ENOTSUP)
printf("Function not supported in PMD driver\n");
--
2.5.5
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] app/testpmd: fix potential memory leak
2017-11-02 10:13 [dpdk-dev] [PATCH] app/testpmd: fix potential memory leak Kirill Rybalchenko
@ 2017-11-07 7:06 ` Ferruh Yigit
2017-11-07 7:07 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2017-11-07 7:06 UTC (permalink / raw)
To: Kirill Rybalchenko, dev; +Cc: andrey.chilikin, jingjing.wu
On 11/2/2017 3:13 AM, Kirill Rybalchenko wrote:
> Fix potential memory leak in cmd_ddp_info_parsed() function.
Coverity issue: 195044
> Fixes: a8e005696c7b ("app/testpmd: get ddp profile protocol info")
>
> Signed-off-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] app/testpmd: fix potential memory leak
2017-11-07 7:06 ` Ferruh Yigit
@ 2017-11-07 7:07 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-11-07 7:07 UTC (permalink / raw)
To: Kirill Rybalchenko, dev; +Cc: andrey.chilikin, jingjing.wu
On 11/6/2017 11:06 PM, Ferruh Yigit wrote:
> On 11/2/2017 3:13 AM, Kirill Rybalchenko wrote:
>> Fix potential memory leak in cmd_ddp_info_parsed() function.
>
> Coverity issue: 195044
>
>> Fixes: a8e005696c7b ("app/testpmd: get ddp profile protocol info")
>>
>> Signed-off-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-07 7:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-02 10:13 [dpdk-dev] [PATCH] app/testpmd: fix potential memory leak Kirill Rybalchenko
2017-11-07 7:06 ` Ferruh Yigit
2017-11-07 7:07 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).