From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3EB5841B7B; Thu, 12 Oct 2023 14:53:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A15B7402E9; Thu, 12 Oct 2023 14:53:24 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id CDF254028A for ; Thu, 12 Oct 2023 14:53:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697115203; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RW994Vv87UzQJrczAu400N9WTFlO5eAV2YFN0ppwv5Y=; b=Ga4aaFvrP1Rnn7gK6s9KA7PdWCNJ2P8Y++ZrXzJFKuR7RNv+53zn9m7ziCjtKlfGG9AWE/ xM5/bR9eEjtxC6S8CcfcfyOcVKCb+mwNrcEzLVNeO9zrjgwBgnt+6PsCYfHI4lwm4gwQG3 gBbLNimym4F1Alb+UUEoxfQqqyXA4qo= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-75-pmIO1wyrMd636VZd1VUcIg-1; Thu, 12 Oct 2023 08:53:17 -0400 X-MC-Unique: pmIO1wyrMd636VZd1VUcIg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 67C293C1E9CA; Thu, 12 Oct 2023 12:53:16 +0000 (UTC) Received: from [10.39.208.36] (unknown [10.39.208.36]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 62F08492B01; Thu, 12 Oct 2023 12:53:15 +0000 (UTC) Message-ID: <9f7890a8-33b0-ddf4-67f2-7c2d6268c091@redhat.com> Date: Thu, 12 Oct 2023 14:53:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v6 00/12] VRB2 bbdev PMD introduction To: Nicolas Chautru , dev@dpdk.org Cc: hemant.agrawal@nxp.com, david.marchand@redhat.com, hernan.vargas@intel.com References: <20231010202049.771959-1-nicolas.chautru@intel.com> From: Maxime Coquelin In-Reply-To: <20231010202049.771959-1-nicolas.chautru@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/10/23 22:20, Nicolas Chautru wrote: > v6: removed one empty line typo. > Thanks > > v5: missed a line in v4 patch 2/12. > change to 9/12 with suggested refactor. > > v4: updates based on Maxime's suggestions: > - FFT windowing exposure tweaked to show number of windows > as well in capacity to be more generic and future-proof. > - few code refactor notably to avoid code duplication > - cosmetic and doc update > > v3: updates based on v2 review: > - split into smaller incremental commits > - FFT windowing exposed through a more generic structure > - refactor using wrapper functions to manage device variants > - removed custom dump function > - consider the request unsupport SO option as an error > instead of fall-back. > - cosmetic and doc update. > Thanks > > v2: doc, comments and commit-log updates. > > This serie includes changes to the VRB BBDEV PMD for 23.11. > > This allows the VRB unified driver to support the new VRB2 > implementation variant on GNR-D. > > This also include minor change to the dev_info to expose FFT version > flexibility to expose information to the application on what windows > LUT is configured dynamically on the device. > > Nicolas Chautru (12): > bbdev: add FFT window width member in driver info > baseband/acc: add FFT window width in the VRB PMD > baseband/acc: remove the 4G SO capability for VRB1 > baseband/acc: allocate FCW memory separately > baseband/acc: add support for MLD operation > baseband/acc: refactor to allow unified driver extension > baseband/acc: adding VRB2 device variant > baseband/acc: add FEC capabilities for the VRB2 variant > baseband/acc: add FFT support to VRB2 variant > baseband/acc: add MLD support in VRB2 variant > baseband/acc: add support for VRB2 engine error detection > baseband/acc: add configure helper for VRB2 > > doc/guides/bbdevs/features/vrb2.ini | 14 + > doc/guides/bbdevs/index.rst | 1 + > doc/guides/bbdevs/vrb1.rst | 4 - > doc/guides/bbdevs/vrb2.rst | 206 ++++ > doc/guides/rel_notes/release_23_11.rst | 3 + > drivers/baseband/acc/acc100_pmd.h | 2 + > drivers/baseband/acc/acc_common.h | 185 ++- > drivers/baseband/acc/rte_acc100_pmd.c | 6 +- > drivers/baseband/acc/rte_vrb_pmd.c | 1571 +++++++++++++++++++++--- > drivers/baseband/acc/vrb1_pf_enum.h | 17 +- > drivers/baseband/acc/vrb2_pf_enum.h | 124 ++ > drivers/baseband/acc/vrb2_vf_enum.h | 121 ++ > drivers/baseband/acc/vrb_cfg.h | 16 + > drivers/baseband/acc/vrb_pmd.h | 173 ++- > lib/bbdev/rte_bbdev.h | 2 + > lib/bbdev/rte_bbdev_op.h | 2 + > 16 files changed, 2258 insertions(+), 189 deletions(-) > create mode 100644 doc/guides/bbdevs/features/vrb2.ini > create mode 100644 doc/guides/bbdevs/vrb2.rst > create mode 100644 drivers/baseband/acc/vrb2_pf_enum.h > create mode 100644 drivers/baseband/acc/vrb2_vf_enum.h > Applied to next-baseband/for-main. Thanks, Maxime