Re: [PATCH] lib: add get/set link settings interface

[Ferruh Yigit <ferruh.yigit@amd.com>]

On 4/4/2024 12:38 AM, Stephen Hemminger wrote:
> On Thu, 4 Apr 2024 00:08:41 +0200
> Marek Pazdan <mpazdan@arista.com> wrote:
> 
>> I can remove this part (rte_eth_config), but the new API provides other
>> link information which is not available from the existing API, like
>> supported/advertising/partner_advertising link modes.
>> Additionally from what I see, rte_eth_confg is available from
>> rte_eth_dev_conf_get API and it's copy of requested configuration:
>> `memcpy(dev_conf, &dev->data->dev_conf, sizeof(struct rte_eth_conf));`
> 
> 
> Then the new info should go in the rte_eth_config in a future version
> of DPDK. Having bits in different places makes the API confusing.
>

Hi Marek,

Not able to get enough justification for the new set of ethdev APIs for
the link.

It can be an option to extend existing APIs, and have a more focused API
for the missing part. This depends on what is missing.

I am marking this patch and two relevant patches [1] as change
requested, if the functionality is still relevant please start with a
new RFC in next release with one of the above approaches to enable
discussion again.

Thanks,
ferruh

[1]
-
https://patches.dpdk.org/project/dpdk/patch/20240403135953.7209-1-mpazdan@arista.com/
-
https://patches.dpdk.org/project/dpdk/patch/20240403225333.16260-1-mpazdan@arista.com/