From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A34D345681; Mon, 22 Jul 2024 16:55:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8AFCB406B7; Mon, 22 Jul 2024 16:55:40 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2084.outbound.protection.outlook.com [40.107.237.84]) by mails.dpdk.org (Postfix) with ESMTP id 3F38B402B1 for ; Mon, 22 Jul 2024 16:55:37 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YgU1TIMBiCuHb0LXWxw/cniyVNxbFf++RrM684/kBHBm43IaskqHUwmLJRAMM4+fg7QKMnqqf6JgJhSdlnj2ak0K4UyXDdEsCgLyiWYAnuSQhzZbXTXnjlNTbD6e2Pd6NX2k0N2IFvCgJsMqJsbbABUfqkhpyNejudHzZz9fWGG8af7qSGcS/MycsMRdFvfFufBFkdGJT8EKsEJpz6Bpb7oR2+agqDNFyK0NGeYxcjk1YC9axw1/6ryanWOcmU4Z5/BS9POBbNu9w19bguGNpHWK43s/Qx9h8oMsyuk9Cj8lLShfDBOOyA4423kpBxfmXJyKXMY5Er898urY2tZk6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/6x/stWInVcS1Tz/h2QQzLLSx9AQwFlVg9AGHKdnWKM=; b=fovAD+AEP3fL8ZTV6rfTHg3438pULD3FBl745kY0UHBy1vnGijO/J9yj3vxBvVm2R+3deyPyapTsC+5ahuT09n+V5vcUIRgdkamgzBJD0+roZIe6Fwcexq62U9nAVeMLDetEcCkf7GxvM5XYZjLytM1FC8QXrdkDgLbo2Jnp1wgCrU5f9K2a3dKkUJXza5Hud/+hoKjzUgpfjrI/bogrfKLH/5lpvRYumIeEE+sdSvT1o5Tqe1QSXyhxqI0cuNPuB9Y9zKG2iHZfl5W0KQ0cvcD9n4k8XrO76knPQPRVRxqB2VUCB3n958GGMPOWoaN6hY2XHx9GmGc9Ph7gSAOkkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/6x/stWInVcS1Tz/h2QQzLLSx9AQwFlVg9AGHKdnWKM=; b=FyuVeW/iMuA2MjWdA94GiUVaKpRD0rFmRp174Eg0ztHmu4u0OCSZWfy6+e6F6gjvt0+FUHzLmAVPV+9tlzGlX5RY+SHB76u2dD95ruILxpEKsZwjFtI8ick0GBQ/FZcD44E7/7oavGG6nR9Yn+eng6Szpwcp8VOKvcnVIBfgrgI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA1PR12MB7661.namprd12.prod.outlook.com (2603:10b6:208:426::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.32; Mon, 22 Jul 2024 14:55:33 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd%4]) with mapi id 15.20.7784.017; Mon, 22 Jul 2024 14:55:33 +0000 Message-ID: <9f7a4593-83d3-40a8-8cf3-2098bca17f8d@amd.com> Date: Mon, 22 Jul 2024 15:55:28 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] lib: add get/set link settings interface To: Stephen Hemminger , Marek Pazdan Cc: Thomas Monjalon , Andrew Rybchenko , dev@dpdk.org References: <20240326235909.25276-1-mpazdan@arista.com> <20240403135953.7209-1-mpazdan@arista.com> <1924573.MyG8hOvIyE@thomas> <20240403102302.6b700690@hermes.local> <20240403163846.7ed3ff4a@hermes.local> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240403163846.7ed3ff4a@hermes.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0140.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::8) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA1PR12MB7661:EE_ X-MS-Office365-Filtering-Correlation-Id: acfcb0ad-96a5-4201-dd44-08dcaa5e568b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bUdGaFJFYkM2NFVPM0RWbXFNQURmV2JFSnVFb3pZRHZtNHRFZUZ0Wk1GNE15?= =?utf-8?B?bUNhcGQ1MDJuNFpQby9WMzFxUzVmejdIV1NZYk1rakg4azlKUlJRclpKOFJx?= =?utf-8?B?YjZGa3pTR01nWEhBTWt0LzFIUkcrYmN0UVV4N0lIWjAxTFZmSFVqMlVTTDJl?= =?utf-8?B?dnhkZ0VHeUR5a1psZzd0czdTcTN6RXhra3Jpd3VnK1czQW9GYllxOFcxcFJG?= =?utf-8?B?Zm8zWGhDbGM1Y3VGTEpIbmpFVW8xNHpZdmptWTV5RnpvSHNEakhIbXdCaVJl?= =?utf-8?B?cXhSUGFnVXJBZXFwTGNzdkNFRnlhc2xVQS8rQUp5aUViR25oazNxTnIvb2tB?= =?utf-8?B?TCtXZDhBZzVuaEtFMlZHV3EvS2oxc2JDZG0rRFNDdVhBZmpRTUZRSHFLZWtY?= =?utf-8?B?STBlN2ZncjNvOE9wWHpZOWlEZUNFMVpNZkhGN283ZHR4dERxZVVXem92M0Mz?= =?utf-8?B?cmxhWHBDUERUOWYzdGZIcUV5dGRuQ2pWV1BvUWFZWmFGbkErTzB5T3hraGtw?= =?utf-8?B?SWlnZ0VFcjBKY2JlSWxUdWVZYVd4WEpZVUZyOUdsMkZLb1NiVTB3Vnk4Y3ZZ?= =?utf-8?B?Z1dDYTVVcHUybVdMK1RUd3JLWlYzbFNBeVBxclFzdGNkaDh3TDlWZ2xDclZj?= =?utf-8?B?VU9GeFZEd3F3enlDM1pkYXJmQUEzb25rRGJLWFQzSjcyZzVBUG1wL3ZUV2pa?= =?utf-8?B?b3BhZmsvRTFWYmNiaGR4Ry9WcVJkb2VpWnVjVHV0NEovWUtDbXVGQ3pqbnNB?= =?utf-8?B?N1VMRlA5eUs2MFBvY1ljRHFUTERhRkp6QUwxelRPdVdnYkt1ZDhaUWs1STN2?= =?utf-8?B?bktrRzVXUUhYNFRFTnVXUllpaWNhWVFkTVFyNVNQcmJCUHkxVjk5MEEvY1A5?= =?utf-8?B?Mk5WTTRYVXNNZnI2eHVlMEZPTm5hRC8ySFlrR0ZOSDBIOFJKS1pRb2JhTlph?= =?utf-8?B?R1h3eWRzSi9aaGZ4Yk1WczljdnJ2Y3RSbEsvdy9lZ0NsVFY4QTk0b3l1WUlT?= =?utf-8?B?SE54QmdkYTBXSENDNThoZWJHeGRZTWJmbUhJZGh2SDdXdFFtVGRIS3hER29w?= =?utf-8?B?RTQyTUg1M0duMU9ySDVWUjZUKzM0WVUxbGcwMHdHYU9GSE4wT21RQXVZU0pz?= =?utf-8?B?YURhUWt4ckpEZXRlK0ZyWUoweXlFR3dxT29zV09jWkVhQWk2b3VHMUhXZE5K?= =?utf-8?B?dnNrc0pqcWs2RW1lb0xxclZWdWl4amxKWHdwcVFBWENUVXVpY3kvbHVjZDJV?= =?utf-8?B?dFVBNXJwSGpRc1VWb1NQY3F0RWlRQks1dGI3bjBrVFhtdmlGUXRmbDFtSEMz?= =?utf-8?B?dGttMFR2SG43RTcyUmlCak03R20xWEdxUzRlZkYzcjcrdFNYMEM4aHo1aVFK?= =?utf-8?B?Tk5na2NIcGFUYjU4aVQwQzV2RklPT1BGbVJtTjM3VDFCTnhsUFhWUmYyVm5z?= =?utf-8?B?TE9lZzIwSDYvTHB1Yk12RlRPMnNPRE5ZRDJadGE3M3BibHhmZjc0bHF5UFNH?= =?utf-8?B?eFBOc1R1TWcyQXVTZ0JHbVVwNktRQlVXbjB3RjlaL2ZLdmh0SmVRUEw3L2p0?= =?utf-8?B?ME1tOEpJOWVtUWlKTDJaZTFOTEQ0TDdlNWhmMXk1MnRVZDd1Z3BjQTVpVVRa?= =?utf-8?B?WDVYSTg5VXdaOTg5MzNvRThDS2xLYTROK2JYbis3dGtYQjg0TjlqV1paMjhC?= =?utf-8?B?azlZKzhneEJoVHNWQ2VBQjhMWjV1UjRjT0pFekpLRUlrL2FFR1c3Qlc0Wllj?= =?utf-8?Q?5DoUb822f8u1vY4bzY=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aXN2UFVuVnU4NG5xbWFiMWdXaGN0WEoremY3SlJJUVVxZWFhb0NleTZDK05M?= =?utf-8?B?enNudTM0RDBWVC91V2hLdjBaL2tmRjhoVUdMd1Y2Q0tRMyt5aUlKUU11WUxC?= =?utf-8?B?a3JPYmhHSXhnM1BVNDJDR29icGxTZy9DM09pbllqVTFwQzFnVm52Tlh3V2p4?= =?utf-8?B?U2RydlVVRDhHOHN1OTIra29uM1VHd1pxRmIweHVZdUIzZ1ZHZDNITm5QN3VM?= =?utf-8?B?dWxJNzQ3bXdmZUYxZU1FMnh4WkVZV3FFSHZWNDIzdTMzeWFWd0hZTmJHMkNK?= =?utf-8?B?dW9iMkpiTnUrVW94cFVISlBUM1A0dmJWTXp0OWNINy9TV1lBZlQ3M2pqeExG?= =?utf-8?B?UHVZQXVqNlUrSGpDb3Bob3Y5UDJkVnFuQ3Z5VWpJQVFmblBGaWE3RHBJTU9R?= =?utf-8?B?WTZDcnA0bGNWNWxvRE9XODdrdHlYNk5FcUVrcHdrb1AzZVoxQXhFbXZwbXhx?= =?utf-8?B?OThxQk1vMW90N2tlMWtxMjBiZGdUMTJaL1ExendTN0d2YVQ0NjlQZ0Rkc3pC?= =?utf-8?B?WTBCeUFkN2xnUk1sTVp5dENScGJJcDR6NFAzUE8rNFFrdllXa1V0UG9selhJ?= =?utf-8?B?YzdJdVRNeU45OFZDMWZ0L2NkSEtMdmp3SWw2ZktuOFFLSFBxSHA2K3BmZXlT?= =?utf-8?B?bCtqdzZkMXhyaWhKV0FHQmo3R3Z2Vy95Q1JoS0cvTkthdEE4NFFkMzFVZjBQ?= =?utf-8?B?Y29SMkpWU05PdnptSUVIN1pWN3N3cXczZGpSQ3NXT2RvSUpWUXFGcTIzbEt4?= =?utf-8?B?SEh0dHpFSzhFUWVrWWs2QUYwaXExQlZkWUs5cDA0Tlg0cmY1SGg1UEZjeGo4?= =?utf-8?B?UlpKRzR1TnBDMDN5Ymdtb2hTM3pRUlF2bTNwSFpQWFlYYm5qRlB0TEtUWlow?= =?utf-8?B?VW8zYUhIZXBIc0RrWlVKOXVRTWYxYUxwUDNXZXVPNC84Y1U2SXA2a0huZkhj?= =?utf-8?B?ZURSNCs2QjlvQVlnUkhPdDJtNTJtaXI0dVhKTlcxWUl2R09WQk53YXlLbkFD?= =?utf-8?B?NUZUc0JHcXdpdERwMUJPcGpJd0xNMDRGVjhuRGp3V3YrbnQ2ZjRTS0Q3R2tm?= =?utf-8?B?ZWl1dmJOdVRtNllIaU1sYkZteHNlWHlLOXRnWWxDRG1SQ1p0M0NJbk15VXlD?= =?utf-8?B?bGRzSXptMmg0M0h2dE9RUWwxVThTbjhJbmMwUGM3YThYMWQrSDBSZnlQcnV2?= =?utf-8?B?SHpRTGp6dlpzWTlEYURlcXErajJUa21sZi9PRTdua2ZmZkR3dGpLcWptS3ll?= =?utf-8?B?OHY5QXM2SnVUVTdrU3BnZGNhRUxaUjBacEpvOUw5dWdUTGoyZHNWSnZLREZV?= =?utf-8?B?YStzeTRQUlVLSnJjVm9Ib1dEN2hyd3lGdG9FSno2c25WTUpnSDNSRHhiOTdO?= =?utf-8?B?cENVSGdkalN2VWcxTVE3VnYydnFWekovcWl6RUQwQ1p2OGZ4SURieHh1cFlw?= =?utf-8?B?b0xrb2V1eEU4dGhvVWxjUFJHV3dQdVR6aE9YamFoN3FFeTJ1aW41aExkWXN5?= =?utf-8?B?S3IwY0tMU3BFNWNVenNPME1sVm5INFZ6clpMM3ZEQ1pINElwU0NnNVlhd09R?= =?utf-8?B?MEtMRTNxOHBEd3VyY2ZxaG5XUm1HcUJldDRHYStVS3ZmK0llb0N1R2dSRnVH?= =?utf-8?B?MGFwckt6TFBQUHQzbDRxWndUbUwvUE9nUzd4YlZhOWxJZjJuQkZkVVFQaG0v?= =?utf-8?B?V3FhZTZINjZaZXpneUhRcmpLQ1VNTG9Xa2lwRWlYZVhyN2NWeDlRWkkxRnI1?= =?utf-8?B?Y1JIcloxcDA5K3JyMmRmY3pVN3VrWkthWjRGdzRQZkhwbndabUlTWEhTb3Qx?= =?utf-8?B?WndpbEhpdUZab0s5cjJXeXkxTUR3L2huOEh5azNiVGdnTHNTejVDVnllMEhY?= =?utf-8?B?aFJlTitMTWsyYWZvSXdUekRZYzNwU1NubHI5QWUwMzZibHBwWEdLR3hVbU15?= =?utf-8?B?emZPaCtQNHBXdk81NDJ2Y0lTam9MOCs5VzBjUHFYY3RmMUJub0pLQXJiNzZy?= =?utf-8?B?WGtqbFFTaHNrR0Y2VkxpYkdHSEtCWHIzaU90NVhaSWF2dG92RjkzbU5xWFlu?= =?utf-8?B?cCsrQUo3UmxCOVlnV0hnME43WmRRaG8xVVZoOE1McjUwRUc2ZWkxVjZBZERv?= =?utf-8?Q?vHc3e8G7FLcXKha4NnC2j+NsJ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: acfcb0ad-96a5-4201-dd44-08dcaa5e568b X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2024 14:55:33.7609 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gxdWjZxspzJucZ2bum93yan2dOpUP2QGui5tvvhS/zXq8QzH4hwcwqYFVS9Hm+pP X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7661 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/4/2024 12:38 AM, Stephen Hemminger wrote: > On Thu, 4 Apr 2024 00:08:41 +0200 > Marek Pazdan wrote: > >> I can remove this part (rte_eth_config), but the new API provides other >> link information which is not available from the existing API, like >> supported/advertising/partner_advertising link modes. >> Additionally from what I see, rte_eth_confg is available from >> rte_eth_dev_conf_get API and it's copy of requested configuration: >> `memcpy(dev_conf, &dev->data->dev_conf, sizeof(struct rte_eth_conf));` > > > Then the new info should go in the rte_eth_config in a future version > of DPDK. Having bits in different places makes the API confusing. > Hi Marek, Not able to get enough justification for the new set of ethdev APIs for the link. It can be an option to extend existing APIs, and have a more focused API for the missing part. This depends on what is missing. I am marking this patch and two relevant patches [1] as change requested, if the functionality is still relevant please start with a new RFC in next release with one of the above approaches to enable discussion again. Thanks, ferruh [1] - https://patches.dpdk.org/project/dpdk/patch/20240403135953.7209-1-mpazdan@arista.com/ - https://patches.dpdk.org/project/dpdk/patch/20240403225333.16260-1-mpazdan@arista.com/