DPDK patches and discussions
 help / color / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Myers, Charles" <Charles.Myers@spirent.com>,
	Yong Wang <yongwang@vmware.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [dpdk-dev] [PATCH v3] net/vmxnet3: Added mtu_set() function to allow setting MTU.
Date: Fri, 13 Sep 2019 19:47:54 +0100
Message-ID: <9f7a6d64-9d54-f57d-3c82-9df0c11f4f33@intel.com> (raw)
In-Reply-To: <1566353778-14774-1-git-send-email-charles.myers@spirent.com>

On 8/21/2019 3:16 AM, Myers, Charles wrote:
> From: Charles Myers <charles.myers@spirent.com>
> When the mtu_set() function is not implemented, rte_eth_dev_set_mtu()
> fails with -ENOTSUP and mtu is not stored in the mtu field in the
> rte_eth_dev_data.  This causes the mtu in Vmxnet3_MiscConf which is
> shared with hypervisor to always be set to 1500.
> This may cause issues receiving jumbo frames on Enhanced Data Path
> N-VDS.
> Signed-off-by: Charles Myers <charles.myers@spirent.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.

> @@ -1205,6 +1209,18 @@ vmxnet3_dev_supported_ptypes_get(struct rte_eth_dev *dev)
>  }
>  static int
> +vmxnet3_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
> +{

'mtu' is unused and giving build error:
error: unused parameter ‘mtu’ [-Werror=unused-parameter]

Fixed while merging:
 +vmxnet3_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu __rte_unused)

  parent reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-17  4:53 [dpdk-dev] [PATCH] " Myers, Charles
2019-08-20  4:06 ` [dpdk-dev] [PATCH v2] " Myers, Charles
2019-08-20 15:12   ` Stephen Hemminger
2019-09-03 20:10   ` Yong Wang
2019-08-21  2:16 ` [dpdk-dev] [PATCH v3] " Myers, Charles
2019-08-21  4:43   ` Stephen Hemminger
2019-08-21  5:19     ` Myers, Charles
2019-09-13 18:47   ` Ferruh Yigit [this message]
2019-09-13 18:59     ` Ferruh Yigit

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9f7a6d64-9d54-f57d-3c82-9df0c11f4f33@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=Charles.Myers@spirent.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=yongwang@vmware.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
	public-inbox-index dev

Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/ public-inbox