From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 9A21AA046B
for <public@inbox.dpdk.org>; Fri, 23 Aug 2019 18:07:28 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 2E9531BFF4;
Fri, 23 Aug 2019 18:07:27 +0200 (CEST)
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
by dpdk.org (Postfix) with ESMTP id 0942A1BF3F;
Fri, 23 Aug 2019 18:07:24 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga005.jf.intel.com ([10.7.209.41])
by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
23 Aug 2019 09:07:23 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,421,1559545200"; d="scan'208";a="354660366"
Received: from fmusates-mobl1.ger.corp.intel.com (HELO [10.237.221.57])
([10.237.221.57])
by orsmga005.jf.intel.com with ESMTP; 23 Aug 2019 09:07:21 -0700
To: Kevin Traynor <ktraynor@redhat.com>, dev@dpdk.org
Cc: "kevin.laatz@intel.com; ferruh.yigit"@intel.com, stable@dpdk.org,
Reshma Pattan <reshma.pattan@intel.com>, ciara.power@intel.com,
bruce.richardson@intel.com
References: <1562077208-15355-1-git-send-email-flavia.musatescu@intel.com>
<571738bd-fbe5-42e5-5abc-cfec4f0aa71b@redhat.com>
From: "Musatescu, Flavia" <flavia.musatescu@intel.com>
Message-ID: <9fbbd98c-5a77-16e9-c526-c35c7fa9f80b@intel.com>
Date: Fri, 23 Aug 2019 17:07:20 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <571738bd-fbe5-42e5-5abc-cfec4f0aa71b@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Subject: Re: [dpdk-dev] [PATCH] telemetry: fix build warnings seen when
using gcc 9
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 23/08/2019 11:01, Kevin Traynor wrote:
> On 02/07/2019 15:20, Flavia Musatescu wrote:
>> Suppress the unaligned packed member address warnings by extending
>> the telemetry library build flags with -Wno-address-of-packed-member
>> option, through the WERROR_FLAGS makefile variable.
>>
>> With this change additional warnings are turned on to be treated as errors,
>> which causes the following build issues to be seen:
>> - no previous prototype [-Werror=missing-prototypes]
>> - initialization discards ‘const’ qualifier from pointer target type
>> [-Werror=discarded-qualifiers]
>> - old-style function definition [-Werror=old-style-definition]
>> - variable may be used before its value is set (when using icc compiler).
>>
>> Fixes: 0fe3a37924d4 ("telemetry: format json response when sending stats")
>> Fixes: ee5ff0d3297e ("telemetry: add client feature and sockets")
>> Fixes: 8877ac688b52 ("telemetry: introduce infrastructure")
>> Fixes: 1b756087db93 ("telemetry: add parser for client socket messages")
>> Fixes: fff6df7bf58e ("telemetry: fix using ports of different types")
>> Fixes: 4080e46c8078 ("telemetry: support global metrics")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
>> Signed-off-by: Flavia Musatescu <flavia.musatescu@intel.com>
> Hi Flavio, in the 18.11. stable branch, I had "fixed" the gcc9 warnings
> in telemetry with 2ae7bca9594d ("mk: disable packed member pointer
> warning for telemetry")
>
> This patch in 18.11 branch is causing the following build error:
>
> /root/lts/dpdk-18.11/lib/librte_telemetry/rte_telemetry.c:1822:13:
> error: initialization discards ‘const’ qualifier from pointer target
> type [-Werror=discarded-qualifiers]
> .opt_str = "--telemetry",
> ^~~~~~~~~~~~~
>
> I'm inclined to just keep the existing existing patch in stable and not
> apply this one. Or if you want to do a backport for 18.11 branch that is
> ok too. WDYT?
Hi Kevin,
I will backport the patch for 18.11. Thanks