From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 1AD86592A
 for <dev@dpdk.org>; Tue, 13 Sep 2016 19:11:00 +0200 (CEST)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by orsmga101.jf.intel.com with ESMTP; 13 Sep 2016 10:11:00 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.30,329,1470726000"; 
   d="scan'208";a="7945137"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.106])
 ([10.237.220.106])
 by fmsmga006.fm.intel.com with ESMTP; 13 Sep 2016 10:10:59 -0700
To: Alejandro Lucero <alejandro.lucero@netronome.com>, dev@dpdk.org
References: <1471360528-13477-1-git-send-email-alejandro.lucero@netronome.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <9fbfe918-5a09-46c1-2c85-928fac9d7c0d@intel.com>
Date: Tue, 13 Sep 2016 18:10:58 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <1471360528-13477-1-git-send-email-alejandro.lucero@netronome.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] nfp: using random mac address if not a
 configured mac
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Sep 2016 17:11:01 -0000

Hi Alejandro,

On 8/16/2016 4:15 PM, Alejandro Lucero wrote:
> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
> ---

There are following checkpatch warnings, also check-git-log complains:

Headline too long:
        nfp: unregister interrupt callback function when closing device

...

>  
> +static void nfp_net_read_mac(struct nfp_net_hw *hw) {
> +

ERROR:OPEN_BRACE: open brace '{' following function declarations go on
the next line
#45: FILE: drivers/net/nfp/nfp_net.c:620:
+static void nfp_net_read_mac(struct nfp_net_hw *hw) {

...

> +	if (!is_valid_assigned_ether_addr((struct ether_addr *)&hw->mac_addr[0]))

WARNING:LONG_LINE: line over 80 characters
#67: FILE: drivers/net/nfp/nfp_net.c:2419:
+       if (!is_valid_assigned_ether_addr((struct ether_addr
*)&hw->mac_addr[0]))

> +		/* Using random mac addresses for VFs */