From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6AC7CA0542; Fri, 18 Nov 2022 11:23:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1A93D4021F; Fri, 18 Nov 2022 11:23:55 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 3C6864003F for ; Fri, 18 Nov 2022 11:23:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668767032; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dpdm4yeU2OsfPvR47FBOUyiIchU3stloVw5d9KYfFWk=; b=TLTyXw6pDW3D/gZnIZO/+fxB3mtRwOq9aaKQHmCIbFrYdY76vIAAgPkznwo6MBQHacm3yf CRaVzrwOWwuctW8Mfebd+OCsDwey3d/NUmmtGh95YJP0dIbI/RR9BmpWWYst9dTiRcGjHi U4/fmz+F8yAKvmZC5N4VrUfapZb80yg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-414-l-bmGXr_OyWpzCiyq0Pp3w-1; Fri, 18 Nov 2022 05:23:48 -0500 X-MC-Unique: l-bmGXr_OyWpzCiyq0Pp3w-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EB1E8833A09; Fri, 18 Nov 2022 10:23:47 +0000 (UTC) Received: from [10.39.208.34] (unknown [10.39.208.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B08CC141511F; Fri, 18 Nov 2022 10:23:46 +0000 (UTC) Message-ID: <9fe17726-fc4d-0f62-3a59-1e8640c92afa@redhat.com> Date: Fri, 18 Nov 2022 11:23:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 02/11] vhost: fix build with clang 15 To: David Marchand , dev@dpdk.org Cc: stable@dpdk.org, Chenbo Xia , Jiayu Hu , Cheng Jiang References: <20221118085313.2118977-1-david.marchand@redhat.com> <20221118085313.2118977-3-david.marchand@redhat.com> From: Maxime Coquelin In-Reply-To: <20221118085313.2118977-3-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/18/22 09:53, David Marchand wrote: > This variable is not used. > > Fixes: abeb86525577 ("vhost: remove copy threshold for async path") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > --- > lib/vhost/virtio_net.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c > index 4358899718..9abf752f30 100644 > --- a/lib/vhost/virtio_net.c > +++ b/lib/vhost/virtio_net.c > @@ -1877,7 +1877,6 @@ virtio_dev_rx_async_submit_packed(struct virtio_net *dev, struct vhost_virtqueue > struct rte_mbuf **pkts, uint32_t count, int16_t dma_id, uint16_t vchan_id) > { > uint32_t pkt_idx = 0; > - uint32_t remained = count; > uint16_t n_xfer; > uint16_t num_buffers; > uint16_t num_descs; > @@ -1903,7 +1902,6 @@ virtio_dev_rx_async_submit_packed(struct virtio_net *dev, struct vhost_virtqueue > pkts_info[slot_idx].mbuf = pkts[pkt_idx]; > > pkt_idx++; > - remained--; > vq_inc_last_avail_packed(vq, num_descs); > } while (pkt_idx < count); > Reviewed-by: Maxime Coquelin Thanks, Maxime