From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 94B82A0C40;
	Tue,  8 Jun 2021 14:26:10 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 55B7E40689;
	Tue,  8 Jun 2021 14:26:10 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 282E74067A
 for <dev@dpdk.org>; Tue,  8 Jun 2021 14:26:09 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 932037F5F5;
 Tue,  8 Jun 2021 15:26:08 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 932037F5F5
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1623155168;
 bh=+C+x297tJexcVRrX/fQipU/Olj0S4Zoooo49xvnhC1c=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=Wb4daI0GU6jK45NvhWEZoh3uAEwIsvG7doKxXZ4cIKXhuuPhZ9GESYLTH0Lx+AXmp
 bri2Yz1kb860DTbNVZdy9KiyKvKJpXruQZwif2HdAXUgrqogSq/ApWfpipvixH+rAL
 8txpj8QycmFZpwvaQEBYI3qETMMAPzpDxQDKOmts=
To: Nithin Dabilpuram <ndabilpuram@marvell.com>, dev@dpdk.org
Cc: jerinj@marvell.com, skori@marvell.com, skoteshwar@marvell.com,
 pbhagavatula@marvell.com, kirankumark@marvell.com, psatheesh@marvell.com,
 asekhar@marvell.com, Srujana Challa <schalla@marvell.com>
References: <20210306153404.10781-1-ndabilpuram@marvell.com>
 <20210607175943.31690-1-ndabilpuram@marvell.com>
 <20210607175943.31690-3-ndabilpuram@marvell.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <9ffa7ba0-e506-4c31-284a-c9bc6238e6d5@oktetlabs.ru>
Date: Tue, 8 Jun 2021 15:26:08 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.0
MIME-Version: 1.0
In-Reply-To: <20210607175943.31690-3-ndabilpuram@marvell.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2 02/62] common/cnxk: update Rx inline IPsec
 mbox message format
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 6/7/21 8:58 PM, Nithin Dabilpuram wrote:
> From: Srujana Challa <schalla@marvell.com>
> 
> Updates Rx inline IPSEC mailbox message format to make it
> sync with latest CPT PF driver.
> 
> Signed-off-by: Srujana Challa <schalla@marvell.com>
> ---
>  drivers/common/cnxk/roc_mbox.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/common/cnxk/roc_mbox.h b/drivers/common/cnxk/roc_mbox.h
> index f6b11b6..fe4df21 100644
> --- a/drivers/common/cnxk/roc_mbox.h
> +++ b/drivers/common/cnxk/roc_mbox.h
> @@ -1328,6 +1328,9 @@ struct cpt_rxc_time_cfg_req {
>  struct cpt_rx_inline_lf_cfg_msg {
>  	struct mbox_msghdr hdr;
>  	uint16_t __io sso_pf_func;
> +	uint16_t __io param1;
> +	uint16_t __io param2;
> +	uint16_t __io reserved;
>  };
>  
>  enum cpt_eng_type {
> 

Isn't is a dead code?
May be it should be added when it is actually used?