From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 8F60DA0096 for ; Tue, 4 Jun 2019 15:35:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E335C1BC74; Tue, 4 Jun 2019 15:35:54 +0200 (CEST) Received: from integrity.niometrics.com (integrity.niometrics.com [42.61.70.122]) by dpdk.org (Postfix) with ESMTP id B63731BB9A for ; Tue, 4 Jun 2019 15:35:53 +0200 (CEST) Received: from [10.15.0.2] (unknown [10.15.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by integrity.niometrics.com (Postfix) with ESMTPSA id BEF9A409CBA8; Tue, 4 Jun 2019 21:35:51 +0800 (+08) DMARC-Filter: OpenDMARC Filter v1.3.2 integrity.niometrics.com BEF9A409CBA8 Authentication-Results: integrity.niometrics.com; dmarc=fail (p=reject dis=none) header.from=niometrics.com Authentication-Results: integrity.niometrics.com; spf=fail smtp.mailfrom=locnguyen@niometrics.com DKIM-Filter: OpenDKIM Filter v2.11.0 integrity.niometrics.com BEF9A409CBA8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niometrics.com; s=default; t=1559655352; bh=B80kGq8981n+e7ap37nsiK7esoKiBr/X/YfdkGusk3c=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=YgjvC2YZVra4qcMl0NdYoyUi+GQU2DyM2+Tpc5BzD+r2XhZttUdn4Il2JkX1oGATn QSIl2RqROUNeeYMUTrbThCQe5eMOHGErirQPPCju2kDJByw0Ff9FmvXEVordcK4/bQ 5bhHbZ721nvI1BCp/HfJ1/voeuCkac5L4EtodaHo= From: Loc Nguyen Message-Id: Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Date: Tue, 4 Jun 2019 21:35:51 +0800 In-Reply-To: <20190604100141.GA1311@bricha3-MOBL.ger.corp.intel.com> Cc: Thomas Monjalon , dev@dpdk.org To: Bruce Richardson References: <20190603125736.48511-1-locnguyen@niometrics.com> <20190604100141.GA1311@bricha3-MOBL.ger.corp.intel.com> X-Mailer: Apple Mail (2.3445.104.11) X-Spam-Status: No, score=-1.0 required=3.5 tests=ALL_TRUSTED,HTML_MESSAGE autolearn=disabled version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on integrity.niometrics.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] usertools: add device index for dpdk-devbind script X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Bruce, Thanks for the feedback. In my application, we map the NIC interfaces = into port numbers, which are these indexes. For example, we have an config file saying we = would like to use port 2, 3 and 5 for RX. Having the indexes printed together with the NIC = interfaces via this script helps us to easily select the correct interfaces to use. = Especially when we usually bind or unbind the interfaces to kernel driver or DPDK driver depending = on the situation, which will cause a shift in the interface to port number mapping. On = machines with more than 10 interfaces, it=E2=80=99s much slower if we need to count the = indexes manually. Thanks, Loc > On 4 Jun 2019, at 6:01 PM, Bruce Richardson = wrote: >=20 > On Mon, Jun 03, 2019 at 08:57:36PM +0800, Loc Nguyen wrote: >> Add a device index in front of the PCI ID for easy counting >>=20 >> Network devices using DPDK-compatible driver >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> 0: 0000:07:00.0 ... >> 1: 0000:07:00.1 ... >>=20 >> Signed-off-by: Loc Nguyen >> --- >> usertools/dpdk-devbind.py | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >>=20 > While I don't see anything wrong with this change, can you elaborate = on why > you think this is of use? The rest of the script doesn't do anything = with > these indexes so why is it worth using columns of screen space to = display > them? >=20 > Thanks, > /Bruce