From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <deepak.k.jain@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
by dpdk.org (Postfix) with ESMTP id 1629CCC1E
for <dev@dpdk.org>; Fri, 17 Jun 2016 11:49:13 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
by fmsmga102.fm.intel.com with ESMTP; 17 Jun 2016 02:49:13 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,483,1459839600"; d="scan'208";a="999724740"
Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31])
by orsmga002.jf.intel.com with ESMTP; 17 Jun 2016 02:49:12 -0700
Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by
IRSMSX106.ger.corp.intel.com (163.33.3.31) with Microsoft SMTP Server (TLS)
id 14.3.248.2; Fri, 17 Jun 2016 10:49:11 +0100
Received: from irsmsx107.ger.corp.intel.com ([169.254.10.96]) by
IRSMSX156.ger.corp.intel.com ([10.108.20.68]) with mapi id 14.03.0248.002;
Fri, 17 Jun 2016 10:49:11 +0100
From: "Jain, Deepak K" <deepak.k.jain@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Griffin, John" <john.griffin@intel.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>, "Doherty, Declan"
<declan.doherty@intel.com>
Thread-Topic: [dpdk-dev] [PATCH] qat: fix for VFs not getting recognized
Thread-Index: AQHRx+Pc4sdK3NyoFEGX3xhZ3SdsAZ/sNByAgAASkOCAAPpyAIAAJfmA
Date: Fri, 17 Jun 2016 09:49:09 +0000
Deferred-Delivery: Fri, 17 Jun 2016 09:49:01 +0000
Message-ID: <A09C9DDE180C7E429EC68E2BFB95C903393C33B2@IRSMSX107.ger.corp.intel.com>
References: <1466090950-12231-1-git-send-email-deepak.k.jain@intel.com>
<11386705.985BuDGx4F@xps13>
<A09C9DDE180C7E429EC68E2BFB95C903393C2D06@IRSMSX107.ger.corp.intel.com>
<7138878.rfgI980QT2@xps13>
In-Reply-To: <7138878.rfgI980QT2@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ctpclassification: CTP_IC
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjg2MjNhZDMtODEwNS00OTYxLWEwMmItMjBmMjRjMmI2ZmQxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjFoZ2M1YUNkMXhZZVdGYWQ5VCtpVE9pOUgrZUlnUmt6cm1TaXdJSVpSSms9In0=
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] qat: fix for VFs not getting recognized
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Jun 2016 09:49:14 -0000
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Friday, June 17, 2016 9:19 AM
> To: Jain, Deepak K <deepak.k.jain@intel.com>
> Cc: dev@dpdk.org; Griffin, John <john.griffin@intel.com>; De Lara Guarch,
> Pablo <pablo.de.lara.guarch@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] qat: fix for VFs not getting recognized
>=20
> 2016-06-16 16:25, Jain, Deepak K:
> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > 2016-06-16 16:29, Jain, Deepak K:
> > > > Due to addition of CLASS_ID in EAL, class_id is amended into the co=
de.
> > >
> > > Why the VF is not recognized?
> > > The class id should not be mandatory.
> >
> > Without the change proposed, QuickAssist Devices were not visible and
> hence tests were not running.
> > Seems like changes in EAL especially where class_id is added affected t=
he
> QuickAssist tests.
> > With this change, QuickAssist devices are visible during tests and test=
s
> working fine.
>=20
> Which tests?
> Have you investigated why?
Hi Thomas,
On investigation, I found that when class_id is not set in the rte_qat_cryp=
todev.c, the value of id_table->class_id defaults to 0.
Hence the following code snippet always executes and the probing of driver =
is never done.
if (id_table->class_id !=3D dev->id.class_id &&
id_table->class_id !=3D RTE_CLASS_ANY_ID
continue;=09
If value of id_table->class_id is set, as shown in patch which was submitte=
d, the id_table->class_ID is set to RTE_CLASS_ANY_ID and hence its probes t=
he driver and fixes the issues.
Other fix would be to set default value of class_id equal to RTE_CLASS_ANY_=
ID instead of 0.