* [dpdk-dev] [PATCH] crypto/qat: fix typo
@ 2017-06-29 11:16 Pablo de Lara
2017-06-29 19:46 ` Jain, Deepak K
0 siblings, 1 reply; 8+ messages in thread
From: Pablo de Lara @ 2017-06-29 11:16 UTC (permalink / raw)
To: fiona.trahe, john.griffin, deepak.k.jain; +Cc: dev, Pablo de Lara, stable
Fixed a comment in QAT, referring to the IV size
for AES-GCM, that should be in bytes, and not bits.
Fixes: 53d8971cbe81 ("qat: fix AES-GCM decryption")
CC: stable@dpdk.org
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
drivers/crypto/qat/qat_crypto.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/qat/qat_crypto.c b/drivers/crypto/qat/qat_crypto.c
index 37d8a58..dc6595a 100644
--- a/drivers/crypto/qat/qat_crypto.c
+++ b/drivers/crypto/qat/qat_crypto.c
@@ -1146,7 +1146,7 @@ qat_write_hw_desc_entry(struct rte_crypto_op *op, uint8_t *out_msg,
ctx->qat_hash_alg == ICP_QAT_HW_AUTH_ALGO_GALOIS_64) {
if (op->sym->cipher.iv.length == 12) {
/*
- * For GCM a 12 bit IV is allowed,
+ * For GCM a 12 byte IV is allowed,
* but we need to inform the f/w
*/
ICP_QAT_FW_LA_GCM_IV_LEN_FLAG_SET(
--
2.9.4
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] crypto/qat: fix typo
2017-06-29 11:16 [dpdk-dev] [PATCH] crypto/qat: fix typo Pablo de Lara
@ 2017-06-29 19:46 ` Jain, Deepak K
2017-06-30 6:23 ` De Lara Guarch, Pablo
0 siblings, 1 reply; 8+ messages in thread
From: Jain, Deepak K @ 2017-06-29 19:46 UTC (permalink / raw)
To: De Lara Guarch, Pablo, Trahe, Fiona, Griffin, John; +Cc: dev, stable
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Thursday, June 29, 2017 12:16 PM
> To: Trahe, Fiona <fiona.trahe@intel.com>; Griffin, John
> <john.griffin@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> stable@dpdk.org
> Subject: [PATCH] crypto/qat: fix typo
>
> Fixed a comment in QAT, referring to the IV size for AES-GCM, that should be
> in bytes, and not bits.
>
> Fixes: 53d8971cbe81 ("qat: fix AES-GCM decryption")
> CC: stable@dpdk.org
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> --
> 2.9.4
Acked-by: Deepak Kumar Jain <deepak.k.jain@intel.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] crypto/qat: fix typo
2017-06-29 19:46 ` Jain, Deepak K
@ 2017-06-30 6:23 ` De Lara Guarch, Pablo
0 siblings, 0 replies; 8+ messages in thread
From: De Lara Guarch, Pablo @ 2017-06-30 6:23 UTC (permalink / raw)
To: Jain, Deepak K, Trahe, Fiona, Griffin, John; +Cc: dev, stable
> -----Original Message-----
> From: Jain, Deepak K
> Sent: Thursday, June 29, 2017 8:46 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>; Griffin, John <john.griffin@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: RE: [PATCH] crypto/qat: fix typo
>
>
>
> > -----Original Message-----
> > From: De Lara Guarch, Pablo
> > Sent: Thursday, June 29, 2017 12:16 PM
> > To: Trahe, Fiona <fiona.trahe@intel.com>; Griffin, John
> > <john.griffin@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>
> > Cc: dev@dpdk.org; De Lara Guarch, Pablo
> > <pablo.de.lara.guarch@intel.com>; stable@dpdk.org
> > Subject: [PATCH] crypto/qat: fix typo
> >
> > Fixed a comment in QAT, referring to the IV size for AES-GCM, that
> > should be in bytes, and not bits.
> >
> > Fixes: 53d8971cbe81 ("qat: fix AES-GCM decryption")
> > CC: stable@dpdk.org
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > ---
> > --
> > 2.9.4
> Acked-by: Deepak Kumar Jain <deepak.k.jain@intel.com>
Applied to dpdk-next-crypto.
Pablo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] crypto/qat: fix typo
2018-09-17 7:56 ` Thomas Monjalon
@ 2018-09-17 9:01 ` Trahe, Fiona
0 siblings, 0 replies; 8+ messages in thread
From: Trahe, Fiona @ 2018-09-17 9:01 UTC (permalink / raw)
To: Thomas Monjalon, akhil.goyal
Cc: dev, De Lara Guarch, Pablo, Jozwiak, TomaszX, Trahe, Fiona
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Monday, September 17, 2018 8:56 AM
> To: Trahe, Fiona <fiona.trahe@intel.com>; akhil.goyal@nxp.com
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Jozwiak, TomaszX
> <tomaszx.jozwiak@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] crypto/qat: fix typo
>
> Hi,
>
> 10/08/2018 17:20, Trahe, Fiona:
> > > -/**< Intel(R) QAT Symmetric Crypto PMD device name */
> > > +/**< Intel(R) QAT Symmetric Crypto PMD driver name */
> > > #define CRYPTODEV_NAME_QAT_SYM_PMD crypto_qat
>
> The comment is above, so the syntax should be /**, not /**<
> Do you want me to fix it when pulling in master?
>
That would be great thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] crypto/qat: fix typo
2018-08-10 15:20 Trahe, Fiona
2018-08-13 14:39 ` Jozwiak, TomaszX
2018-08-23 12:55 ` Akhil Goyal
@ 2018-09-17 7:56 ` Thomas Monjalon
2018-09-17 9:01 ` Trahe, Fiona
2 siblings, 1 reply; 8+ messages in thread
From: Thomas Monjalon @ 2018-09-17 7:56 UTC (permalink / raw)
To: Trahe, Fiona, akhil.goyal; +Cc: dev, De Lara Guarch, Pablo, Jozwiak, TomaszX
Hi,
10/08/2018 17:20, Trahe, Fiona:
> > -/**< Intel(R) QAT Symmetric Crypto PMD device name */
> > +/**< Intel(R) QAT Symmetric Crypto PMD driver name */
> > #define CRYPTODEV_NAME_QAT_SYM_PMD crypto_qat
The comment is above, so the syntax should be /**, not /**<
Do you want me to fix it when pulling in master?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] crypto/qat: fix typo
2018-08-10 15:20 Trahe, Fiona
2018-08-13 14:39 ` Jozwiak, TomaszX
@ 2018-08-23 12:55 ` Akhil Goyal
2018-09-17 7:56 ` Thomas Monjalon
2 siblings, 0 replies; 8+ messages in thread
From: Akhil Goyal @ 2018-08-23 12:55 UTC (permalink / raw)
To: Trahe, Fiona, dev, De Lara Guarch, Pablo, Jozwiak, TomaszX
On 8/10/2018 8:50 PM, Trahe, Fiona wrote:
> Corrected subject - only 1 patch here.
>
>> -----Original Message-----
>> From: Trahe, Fiona
>> Sent: Friday, August 10, 2018 4:19 PM
>> To: dev@dpdk.org; akhil.goyal@nxp.com; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
>> Jozwiak, TomaszX <tomaszx.jozwiak@intel.com>
>> Cc: Trahe, Fiona <fiona.trahe@intel.com>
>> Subject: [PATCH 1/2] crypto/qat: fix typo
>>
>> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
>> ---
>> drivers/crypto/qat/qat_sym_pmd.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/crypto/qat/qat_sym_pmd.h b/drivers/crypto/qat/qat_sym_pmd.h
>> index d343285..75c3362 100644
>> --- a/drivers/crypto/qat/qat_sym_pmd.h
>> +++ b/drivers/crypto/qat/qat_sym_pmd.h
>> @@ -12,7 +12,7 @@
>> #include "qat_sym_capabilities.h"
>> #include "qat_device.h"
>>
>> -/**< Intel(R) QAT Symmetric Crypto PMD device name */
>> +/**< Intel(R) QAT Symmetric Crypto PMD driver name */
>> #define CRYPTODEV_NAME_QAT_SYM_PMD crypto_qat
>>
>> extern uint8_t cryptodev_qat_driver_id;
>> --
>> 2.7.4
>
Applied to dpdk-next-crypto.
Added fixes line.
As insisted, this patch is also not CCed to stable.
Please ensure to add fixes line for such patches.
Thanks,
Akhil
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] crypto/qat: fix typo
2018-08-10 15:20 Trahe, Fiona
@ 2018-08-13 14:39 ` Jozwiak, TomaszX
2018-08-23 12:55 ` Akhil Goyal
2018-09-17 7:56 ` Thomas Monjalon
2 siblings, 0 replies; 8+ messages in thread
From: Jozwiak, TomaszX @ 2018-08-13 14:39 UTC (permalink / raw)
To: Trahe, Fiona, dev, akhil.goyal, De Lara Guarch, Pablo
-----Original Message-----
From: Trahe, Fiona
Sent: Friday, August 10, 2018 5:20 PM
To: dev@dpdk.org; akhil.goyal@nxp.com; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Jozwiak, TomaszX <tomaszx.jozwiak@intel.com>
Cc: Trahe, Fiona <fiona.trahe@intel.com>
Subject: RE: [PATCH] crypto/qat: fix typo
Corrected subject - only 1 patch here.
> -----Original Message-----
> From: Trahe, Fiona
> Sent: Friday, August 10, 2018 4:19 PM
> To: dev@dpdk.org; akhil.goyal@nxp.com; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Jozwiak, TomaszX
> <tomaszx.jozwiak@intel.com>
> Cc: Trahe, Fiona <fiona.trahe@intel.com>
> Subject: [PATCH 1/2] crypto/qat: fix typo
>
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
Acked-by: tomaszx.jozwiak@intel.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] crypto/qat: fix typo
@ 2018-08-10 15:20 Trahe, Fiona
2018-08-13 14:39 ` Jozwiak, TomaszX
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Trahe, Fiona @ 2018-08-10 15:20 UTC (permalink / raw)
To: dev, akhil.goyal, De Lara Guarch, Pablo, Jozwiak, TomaszX; +Cc: Trahe, Fiona
Corrected subject - only 1 patch here.
> -----Original Message-----
> From: Trahe, Fiona
> Sent: Friday, August 10, 2018 4:19 PM
> To: dev@dpdk.org; akhil.goyal@nxp.com; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> Jozwiak, TomaszX <tomaszx.jozwiak@intel.com>
> Cc: Trahe, Fiona <fiona.trahe@intel.com>
> Subject: [PATCH 1/2] crypto/qat: fix typo
>
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> ---
> drivers/crypto/qat/qat_sym_pmd.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/qat/qat_sym_pmd.h b/drivers/crypto/qat/qat_sym_pmd.h
> index d343285..75c3362 100644
> --- a/drivers/crypto/qat/qat_sym_pmd.h
> +++ b/drivers/crypto/qat/qat_sym_pmd.h
> @@ -12,7 +12,7 @@
> #include "qat_sym_capabilities.h"
> #include "qat_device.h"
>
> -/**< Intel(R) QAT Symmetric Crypto PMD device name */
> +/**< Intel(R) QAT Symmetric Crypto PMD driver name */
> #define CRYPTODEV_NAME_QAT_SYM_PMD crypto_qat
>
> extern uint8_t cryptodev_qat_driver_id;
> --
> 2.7.4
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-09-17 9:01 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-29 11:16 [dpdk-dev] [PATCH] crypto/qat: fix typo Pablo de Lara
2017-06-29 19:46 ` Jain, Deepak K
2017-06-30 6:23 ` De Lara Guarch, Pablo
2018-08-10 15:20 Trahe, Fiona
2018-08-13 14:39 ` Jozwiak, TomaszX
2018-08-23 12:55 ` Akhil Goyal
2018-09-17 7:56 ` Thomas Monjalon
2018-09-17 9:01 ` Trahe, Fiona
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).