* Re: [dpdk-dev] [PATCH] doc: announce crypto vdev init removal
2017-08-03 2:12 [dpdk-dev] [PATCH] doc: announce crypto vdev init removal Pablo de Lara
@ 2017-08-03 10:38 ` Mcnamara, John
2017-08-03 10:42 ` Akhil Goyal
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Mcnamara, John @ 2017-08-03 10:38 UTC (permalink / raw)
To: De Lara Guarch, Pablo, thomas, jerin.jacob, akhil.goyal,
hemant.agrawal, Trahe, Fiona, Jain, Deepak K, Griffin, John,
Doherty, Declan
Cc: dev
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Thursday, August 3, 2017 3:12 AM
> To: thomas@monjalon.net; jerin.jacob@caviumnetworks.com;
> akhil.goyal@nxp.com; hemant.agrawal@nxp.com; Trahe, Fiona
> <fiona.trahe@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>;
> Griffin, John <john.griffin@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>; Mcnamara, John <john.mcnamara@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [PATCH] doc: announce crypto vdev init removal
>
> In order to remove all dependencies on vdev for cryptodev, the
> implementation of rte_cryptodev_vdev_pmd_init() function needs to be moved
> to rte_cryptodev_vdev.h, and all crypto vdevs will include it, and
> therefore, this function will be removed as a public API.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] doc: announce crypto vdev init removal
2017-08-03 2:12 [dpdk-dev] [PATCH] doc: announce crypto vdev init removal Pablo de Lara
2017-08-03 10:38 ` Mcnamara, John
@ 2017-08-03 10:42 ` Akhil Goyal
2017-08-08 10:12 ` Thomas Monjalon
2017-08-03 14:02 ` Jain, Deepak K
2017-08-03 14:13 ` Jain, Deepak K
3 siblings, 1 reply; 6+ messages in thread
From: Akhil Goyal @ 2017-08-03 10:42 UTC (permalink / raw)
To: Pablo de Lara, thomas, jerin.jacob, hemant.agrawal, fiona.trahe,
deepak.k.jain, john.griffin, declan.doherty, john.mcnamara
Cc: dev
On 8/3/2017 7:42 AM, Pablo de Lara wrote:
> In order to remove all dependencies on vdev for cryptodev,
> the implementation of rte_cryptodev_vdev_pmd_init() function
> needs to be moved to rte_cryptodev_vdev.h, and all crypto
> vdevs will include it, and therefore, this function will
> be removed as a public API.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index f6bd910..63ffad1 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -69,3 +69,8 @@ Deprecation Notices
> be removed in 17.11:
>
> - ``rte_cryptodev_create_vdev``
> +
> +* cryptodev: the following function will be static in 17.11 and included
> + by all crypto drivers, therefore, will not be public:
> +
> + - ``rte_cryptodev_vdev_pmd_init``
>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce crypto vdev init removal
2017-08-03 10:42 ` Akhil Goyal
@ 2017-08-08 10:12 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2017-08-08 10:12 UTC (permalink / raw)
To: Pablo de Lara
Cc: dev, Akhil Goyal, jerin.jacob, hemant.agrawal, fiona.trahe,
deepak.k.jain, john.griffin, declan.doherty, john.mcnamara
03/08/2017 12:42, Akhil Goyal:
> On 8/3/2017 7:42 AM, Pablo de Lara wrote:
> > In order to remove all dependencies on vdev for cryptodev,
> > the implementation of rte_cryptodev_vdev_pmd_init() function
> > needs to be moved to rte_cryptodev_vdev.h, and all crypto
> > vdevs will include it, and therefore, this function will
> > be removed as a public API.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce crypto vdev init removal
2017-08-03 2:12 [dpdk-dev] [PATCH] doc: announce crypto vdev init removal Pablo de Lara
2017-08-03 10:38 ` Mcnamara, John
2017-08-03 10:42 ` Akhil Goyal
@ 2017-08-03 14:02 ` Jain, Deepak K
2017-08-03 14:13 ` Jain, Deepak K
3 siblings, 0 replies; 6+ messages in thread
From: Jain, Deepak K @ 2017-08-03 14:02 UTC (permalink / raw)
To: De Lara Guarch, Pablo, thomas, jerin.jacob, akhil.goyal,
hemant.agrawal, Trahe, Fiona, Griffin, John, Doherty, Declan,
Mcnamara, John
Cc: dev
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Thursday, August 3, 2017 3:12 AM
> To: thomas@monjalon.net; jerin.jacob@caviumnetworks.com;
> akhil.goyal@nxp.com; hemant.agrawal@nxp.com; Trahe, Fiona
> <fiona.trahe@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>;
> Griffin, John <john.griffin@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [PATCH] doc: announce crypto vdev init removal
>
> In order to remove all dependencies on vdev for cryptodev, the
> implementation of rte_cryptodev_vdev_pmd_init() function needs to be
> moved to rte_cryptodev_vdev.h, and all crypto vdevs will include it, and
> therefore, this function will be removed as a public API.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> be removed in 17.11:
>
> - ``rte_cryptodev_create_vdev``
> +
> +* cryptodev: the following function will be static in 17.11 and
> +included
> + by all crypto drivers, therefore, will not be public:
> +
> + - ``rte_cryptodev_vdev_pmd_init``
> --
> 2.9.4
Acked-by: Deepak Kumar Jain <Deepak.k.jain@intel.com.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce crypto vdev init removal
2017-08-03 2:12 [dpdk-dev] [PATCH] doc: announce crypto vdev init removal Pablo de Lara
` (2 preceding siblings ...)
2017-08-03 14:02 ` Jain, Deepak K
@ 2017-08-03 14:13 ` Jain, Deepak K
3 siblings, 0 replies; 6+ messages in thread
From: Jain, Deepak K @ 2017-08-03 14:13 UTC (permalink / raw)
To: De Lara Guarch, Pablo, thomas, jerin.jacob, akhil.goyal,
hemant.agrawal, Trahe, Fiona, Griffin, John, Doherty, Declan,
Mcnamara, John
Cc: dev
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Thursday, August 3, 2017 3:12 AM
> To: thomas@monjalon.net; jerin.jacob@caviumnetworks.com;
> akhil.goyal@nxp.com; hemant.agrawal@nxp.com; Trahe, Fiona
> <fiona.trahe@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>;
> Griffin, John <john.griffin@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [PATCH] doc: announce crypto vdev init removal
>
> In order to remove all dependencies on vdev for cryptodev, the
> implementation of rte_cryptodev_vdev_pmd_init() function needs to be
> moved to rte_cryptodev_vdev.h, and all crypto vdevs will include it, and
> therefore, this function will be removed as a public API.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index f6bd910..63ffad1 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -69,3 +69,8 @@ Deprecation Notices
> be removed in 17.11:
>
> - ``rte_cryptodev_create_vdev``
> +
> +* cryptodev: the following function will be static in 17.11 and
> +included
> + by all crypto drivers, therefore, will not be public:
> +
> + - ``rte_cryptodev_vdev_pmd_init``
> --
> 2.9.4
Acked-by: Deepak Kumar Jain <Deepak.k.jain@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread