From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 802FFA046B for ; Thu, 25 Jul 2019 10:38:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 008FB1C2AF; Thu, 25 Jul 2019 10:38:28 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 901511C2AC for ; Thu, 25 Jul 2019 10:38:26 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jul 2019 01:38:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,306,1559545200"; d="scan'208";a="171746219" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga007.fm.intel.com with ESMTP; 25 Jul 2019 01:38:23 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.164]) by IRSMSX102.ger.corp.intel.com ([169.254.2.59]) with mapi id 14.03.0439.000; Thu, 25 Jul 2019 09:38:22 +0100 From: "Morrissey, Sean" To: Thomas Monjalon CC: "dev@dpdk.org" , "Laatz, Kevin" Thread-Topic: [PATCH v2] Revert "eal: fix parsing option --telemetry" Thread-Index: AQHVQjNstERtUCwqf0aRlJNCTuPSOqbZ1IiAgAAgM+CAAEVSAIAAw0CA Date: Thu, 25 Jul 2019 08:38:21 +0000 Message-ID: References: <20190724152059.17859-1-sean.morrissey@intel.com> <9665256.xY3FNFdC9b@xps> <1932425.85ze7CrQjK@xps> In-Reply-To: <1932425.85ze7CrQjK@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWY3MzRkZWQtNzNhOC00YzlkLWEwYjgtNDQyYTUxMjE1OTk2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibHNDNkhmZDIyTzUwR1RVK3lNcWRjT0xiTE5DOTJ5aDk2Q2YzbVZsZFU0S3VibURZMTZQNHlqMFI5TTFnWWZKNiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2] Revert "eal: fix parsing option --telemetry" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Subject: Re: [PATCH v2] Revert "eal: fix parsing option --telemetry" 24/07/2019 18:28, Morrissey, Sean: > = > Subject: Re: [PATCH v2] Revert "eal: fix parsing option --telemetry" > = > 24/07/2019 17:20, Sean Morrissey: > > This reverts commit debacba0297fbe214b4185a9791e6a9fdf6642ba. > > = > > Reverting this patch as it currently breaks the initialization of = > > telemetry, more investigation is ongoing to fix the issue for the = > > printed error message for unrecognized argument. > > = > > Signed-off-by: Sean Morrissey > = > It's very disapointing. > Did you or the reviewer tested the previous patch? > = > The reporter of the bug tested this and verified functionality and closed= the internal bug. So the reverted commit is supposed to work? I won't apply this revert until I fully understand what happens. The patch that I sent up was to remove an "unrecognized option telemetry" w= arning message, which the patch removed and was tested to ensure the messa= ge was removed. Further testing, after the patch was sent up, revealed that= the unix domain socket, which is required by telemetry consumers, was no l= onger being created, rendering the telemetry functionality non-functional. = On further investigation, the full fix involves a change in the EAL command= line parameter handling, which is probably too risky for RC3. = This revert will allow telemetry to function again, but with the erroneous = message still in place. We will aim to fix in the next release. -------------------------------------------------------------- Intel Research and Development Ireland Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact = the sender and delete all copies.