From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id D8CDC5580 for ; Fri, 29 Jul 2016 08:03:52 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP; 28 Jul 2016 23:03:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,437,1464678000"; d="scan'208";a="147363150" Received: from pgsmsx108.gar.corp.intel.com ([10.221.44.103]) by fmsmga004.fm.intel.com with ESMTP; 28 Jul 2016 23:03:52 -0700 Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.74]) by PGSMSX108.gar.corp.intel.com ([169.254.8.98]) with mapi id 14.03.0248.002; Fri, 29 Jul 2016 14:02:13 +0800 From: "Zhao1, Wei" To: "Wu, Jingjing" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/i40e: fiX statstic inconsistent when port stopped Thread-Index: AQHR6UPiDua3iJ1+VU2f6tgvD+ZceqAu5s8Q Date: Fri, 29 Jul 2016 06:02:12 +0000 Message-ID: References: <1469498772-66958-1-git-send-email-wei.zhao1@intel.com> <9BB6961774997848B5B42BEC655768F80E17324D@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <9BB6961774997848B5B42BEC655768F80E17324D@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTY2N2U0ZTMtYWU3MS00NmU5LThiMmUtMzczMjllMjlkMTk5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InIxZlQ5a2tydGRaVys3ZkRuOEZkQ1VXcjFKY2lXZ3JiWnV1eVByS2NDOW89In0= x-ctpclassification: CTP_IC x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fiX statstic inconsistent when port stopped X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jul 2016 06:03:53 -0000 Hi, Wu Jingjing=20 Thanks for your feedback .I didn't find statistic of discard bytes i40= e data sheet, so I have to delete discard packets item from rx_good_packets statistic. In other words, we have no way to to minus the discard byte count from rx_g= ood_bytes. Also I will make some change to meet requirements of commit log and subjec= t. -----Original Message----- From: Wu, Jingjing=20 Sent: Friday, July 29, 2016 10:50 AM To: Zhao1, Wei Cc: dev@dpdk.org Subject: RE: [dpdk-dev] [PATCH] net/i40e: fiX statstic inconsistent when po= rt stopped Hi, zhaowei Few comments below: > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao1 > Sent: Tuesday, July 26, 2016 10:06 AM > To: dev@dpdk.org > Cc: Zhao1, Wei > Subject: [dpdk-dev] [PATCH] net/i40e: fiX statstic inconsistent when=20 > port stopped >=20 Avoid typo: fiX -> fix; statstic -> statistic And there are some requirements based on the subject and commit log in , su= ch as: * The summary line should be around 50 characters. * The text of the commit message should be wrapped at 72 characters. Please check the doc " doc/guides/contributing/patches.rst" and use " scrip= ts/check-git-log.sh" to help you. > rx_good_bytes and rx_good_packets statstic is inconsistent when port=20 > stopped,ipackets statistic is minus the discard packets but rx_bytes=20 > statistic not. > Also,i40e has no statstic of discard bytes, so we have to delete=20 > discard packets item from rx_good_packets statstic. >=20 > Fixes: 9aace75fc82e ("i40e: fix statistics") >=20 > Signed-off-by: Wei Zhao1 > --- > drivers/net/i40e/i40e_ethdev.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev.c=20 > b/drivers/net/i40e/i40e_ethdev.c index 11a5804..553dfd9 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -2319,8 +2319,7 @@ i40e_dev_stats_get(struct rte_eth_dev *dev,=20 > struct rte_eth_stats *stats) >=20 > stats->ipackets =3D pf->main_vsi->eth_stats.rx_unicast + > pf->main_vsi->eth_stats.rx_multicast + > - pf->main_vsi->eth_stats.rx_broadcast - > - pf->main_vsi->eth_stats.rx_discards; > + pf->main_vsi->eth_stats.rx_broadcast; > stats->opackets =3D pf->main_vsi->eth_stats.tx_unicast + > pf->main_vsi->eth_stats.tx_multicast + > pf->main_vsi->eth_stats.tx_broadcast; rx_discards is included in imiss. So I think it's better to minus the disca= rd count. /Jingjing