From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 6FAAC58C5 for ; Mon, 5 Dec 2016 04:06:29 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 04 Dec 2016 19:06:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,302,1477983600"; d="scan'208";a="794214295" Received: from pgsmsx106.gar.corp.intel.com ([10.221.44.98]) by FMSMGA003.fm.intel.com with ESMTP; 04 Dec 2016 19:06:27 -0800 Received: from pgsmsx109.gar.corp.intel.com (10.221.44.109) by PGSMSX106.gar.corp.intel.com (10.221.44.98) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 5 Dec 2016 11:06:26 +0800 Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.199]) by PGSMSX109.gar.corp.intel.com ([169.254.14.134]) with mapi id 14.03.0248.002; Mon, 5 Dec 2016 11:06:26 +0800 From: "Zhao1, Wei" To: Olivier Matz CC: "dev@dpdk.org" Thread-Topic: [PATCH v2] mempool: remove a redundant word "for" in comment Thread-Index: AQHSSFij9umv2DKguU6aoi1eciIGd6Dtj9IAgABPGQCACtiIkA== Date: Mon, 5 Dec 2016 03:06:25 +0000 Message-ID: References: <1480214627-27666-1-git-send-email-wei.zhao1@intel.com> <20161128094212.135ce16c@platinum> <20161128142518.6ed7b6e0@platinum> In-Reply-To: <20161128142518.6ed7b6e0@platinum> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] mempool: remove a redundant word "for" in comment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Dec 2016 03:06:29 -0000 Hi, olivier > -----Original Message----- > From: Olivier Matz [mailto:olivier.matz@6wind.com] > Sent: Monday, November 28, 2016 9:25 PM > To: Zhao1, Wei > Cc: dev@dpdk.org > Subject: Re: [PATCH v2] mempool: remove a redundant word "for" in > comment >=20 > Hi Wei, >=20 > On Mon, 28 Nov 2016 09:42:12 +0100 > Olivier Matz wrote: > > Hi Wenzhuo, >=20 > First, sorry for the mistake in your name my previous mail. >=20 > Please find below some other comments about the patch (on the form). >=20 > > On Sun, 27 Nov 2016 10:43:47 +0800 > > Wei Zhao wrote: > > > > > From: zhao wei > > > > > > There is a redundant repetition word "for" in commnet line of the >=20 > commnet -> comment >=20 > > > file rte_mempool.h after the definition of > RTE_MEMPOOL_OPS_NAMESIZE. > > > The word "for"appear twice in line 359 and 360.One of them is >=20 > Missing space after '"for"' and after '360.' >=20 >=20 > > > redundant, so delete it. > > > > > > Fixes: 449c49b93a6b (" mempool: support handler operations") >=20 > We should have an empty line after the 'Fixes:' tag. The check-git-log.sh= can > help you to notice these errors. >=20 > Also, it is important that no spaces are added in the title of the commit= . You > can get the exact line with: > git log -1 --abbrev=3D12 --format=3D'Fixes: %h (\"%s\")' >=20 > > > Signed-off-by: zhao wei >=20 > The name in your .gitconfig should be the same than in you mail: > Wei Zhao >=20 > > > Acked-by: John McNamara > > > > Acked-by: Olivier Matz > > >=20 > Please, could you also check the same comments in the other patch? >=20 > Last thing: when doing another version of the patch, you should add a > changelog that describes what was modified. They take place after the 3 > dashes. >=20 > Thank you for contributing. >=20 > Regards, > Olivier Thank you for your nicely guide to me, I have found that I miss using chec= k patch tool last time.