From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <wei.zhao1@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 538102BB9
 for <dev@dpdk.org>; Tue,  3 Jan 2017 04:09:37 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by orsmga103.jf.intel.com with ESMTP; 02 Jan 2017 19:09:36 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,451,1477983600"; d="scan'208";a="1107134118"
Received: from kmsmsx154.gar.corp.intel.com ([172.21.73.14])
 by fmsmga002.fm.intel.com with ESMTP; 02 Jan 2017 19:09:35 -0800
Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.52]) by
 KMSMSX154.gar.corp.intel.com ([169.254.12.113]) with mapi id 14.03.0248.002;
 Tue, 3 Jan 2017 11:09:32 +0800
From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "Xing, Beilei" <beilei.xing@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH v2 16/18] net/ixgbe: create consistent filter
Thread-Index: AQHSYnKYX3S22U2SCk+56FpyHtF+eaEliKUAgACPdyA=
Date: Tue, 3 Jan 2017 03:09:31 +0000
Message-ID: <A2573D2ACFCADC41BB3BE09C6DE313CA0201ADE7@PGSMSX103.gar.corp.intel.com>
References: <1483084390-53159-1-git-send-email-wei.zhao1@intel.com>
 <1483084390-53159-17-git-send-email-wei.zhao1@intel.com>
 <94479800C636CB44BD422CB454846E013158D036@SHSMSX101.ccr.corp.intel.com>
In-Reply-To: <94479800C636CB44BD422CB454846E013158D036@SHSMSX101.ccr.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [172.30.20.205]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 16/18] net/ixgbe: create consistent filter
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Jan 2017 03:09:37 -0000


Hi ,beilei
> -----Original Message-----
> From: Xing, Beilei
> Sent: Tuesday, January 3, 2017 10:34 AM
> To: Zhao1, Wei <wei.zhao1@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v2 16/18] net/ixgbe: create consistent fil=
ter
>=20
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao
> > Sent: Friday, December 30, 2016 3:53 PM
> > To: dev@dpdk.org
> > Cc: Zhao1, Wei <wei.zhao1@intel.com>; Lu, Wenzhuo
> > <wenzhuo.lu@intel.com>
> > Subject: [dpdk-dev] [PATCH v2 16/18] net/ixgbe: create consistent
> > filter
> >
> > This patch adds a function to create the flow directory filter.
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> >
> > ---
> >
> > v2:
> > --add new error set function
> > ---
> >  drivers/net/ixgbe/ixgbe_ethdev.c | 240
> > ++++++++++++++++++++++++++++++++++++++-
> >  drivers/net/ixgbe/ixgbe_ethdev.h |   5 +
> >  2 files changed, 244 insertions(+), 1 deletion(-)
> >
> > @@ -1380,6 +1429,14 @@ eth_ixgbe_dev_init(struct rte_eth_dev
> *eth_dev)
> >
> >  	/* initialize l2 tunnel filter list & hash */
> >  	ixgbe_l2_tn_filter_init(eth_dev);
> > +
> > +	TAILQ_INIT(&filter_ntuple_list);
> > +	TAILQ_INIT(&filter_ethertype_list);
> > +	TAILQ_INIT(&filter_syn_list);
> > +	TAILQ_INIT(&filter_fdir_list);
> > +	TAILQ_INIT(&filter_l2_tunnel_list);
> > +	TAILQ_INIT(&ixgbe_flow_list);
>=20
> You need to destroy these lists in dev_unint function.
>=20
> > +
> >  	return 0;
> >  }
> >

Yes, I have add a function ixgbe_filterlist_flush()  in 18/18 in dev_unint =
patch to flush these list.