From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 3AC632B95 for ; Wed, 4 Jan 2017 02:46:29 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP; 03 Jan 2017 17:46:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,457,1477983600"; d="scan'208";a="918654168" Received: from kmsmsx155.gar.corp.intel.com ([172.21.73.106]) by orsmga003.jf.intel.com with ESMTP; 03 Jan 2017 17:46:28 -0800 Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.52]) by KMSMSX155.gar.corp.intel.com ([169.254.15.241]) with mapi id 14.03.0248.002; Wed, 4 Jan 2017 09:46:27 +0800 From: "Zhao1, Wei" To: "Dai, Wei" , "dev@dpdk.org" CC: "Lu, Wenzhuo" Thread-Topic: [dpdk-dev] [PATCH v2 01/18] net/ixgbe: store SYN filter Thread-Index: AQHSYnJsfJz2GSFI2UWD0cCseJ2DwKEmUaAAgAFB3+A= Date: Wed, 4 Jan 2017 01:46:26 +0000 Message-ID: References: <1483084390-53159-1-git-send-email-wei.zhao1@intel.com> <1483084390-53159-2-git-send-email-wei.zhao1@intel.com> <49759EB36A64CF4892C1AFEC9231E8D63A322663@PGSMSX106.gar.corp.intel.com> In-Reply-To: <49759EB36A64CF4892C1AFEC9231E8D63A322663@PGSMSX106.gar.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 01/18] net/ixgbe: store SYN filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jan 2017 01:46:30 -0000 Hi, Daiwei > -----Original Message----- > From: Dai, Wei > Sent: Tuesday, January 3, 2017 10:33 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Zhao1, Wei > > Subject: RE: [dpdk-dev] [PATCH v2 01/18] net/ixgbe: store SYN filter >=20 > Hi, Wei Zhao >=20 > I think that you had better give a cover letter for such a series of patc= hes. > You can give the changes between v2 and v1 in cover letter and maybe no > need describe it in each one. >=20 Ok, I will add cover letter in v3 > Thanks &Best Regards > -Wei >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao > > Sent: Friday, December 30, 2016 3:53 PM > > To: dev@dpdk.org > > Cc: Lu, Wenzhuo ; Zhao1, Wei > > > > Subject: [dpdk-dev] [PATCH v2 01/18] net/ixgbe: store SYN filter > > > > Add support for storing SYN filter in SW. > > > > Signed-off-by: Wenzhuo Lu > > Signed-off-by: Wei Zhao > > --- > > > > v2: > > --synqf assignment location change > > --- > > drivers/net/ixgbe/ixgbe_ethdev.c | 14 +++++++++++--- > > drivers/net/ixgbe/ixgbe_ethdev.h | 2 ++ > > 2 files changed, 13 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > > b/drivers/net/ixgbe/ixgbe_ethdev.c > > index a25bac8..316e560 100644 > > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > > @@ -1274,6 +1274,8 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev) > > memset(filter_info->fivetuple_mask, 0, > > sizeof(uint32_t) * IXGBE_5TUPLE_ARRAY_SIZE); > > > > + /* initialize SYN filter */ > > + filter_info->syn_info =3D 0; > > return 0; > > } > > > > @@ -5580,15 +5582,18 @@ ixgbe_syn_filter_set(struct rte_eth_dev *dev, > > bool add) > > { > > struct ixgbe_hw *hw =3D > > IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private); > > + struct ixgbe_filter_info *filter_info =3D > > + IXGBE_DEV_PRIVATE_TO_FILTER_INFO(dev->data- > >dev_private); > > + uint32_t syn_info; > > uint32_t synqf; > > > > if (filter->queue >=3D IXGBE_MAX_RX_QUEUE_NUM) > > return -EINVAL; > > > > - synqf =3D IXGBE_READ_REG(hw, IXGBE_SYNQF); > > + syn_info =3D filter_info->syn_info; > > > > if (add) { > > - if (synqf & IXGBE_SYN_FILTER_ENABLE) > > + if (syn_info & IXGBE_SYN_FILTER_ENABLE) > > return -EINVAL; > > synqf =3D (uint32_t)(((filter->queue << > > IXGBE_SYN_FILTER_QUEUE_SHIFT) & > > IXGBE_SYN_FILTER_QUEUE) | > IXGBE_SYN_FILTER_ENABLE); @@ -5598,10 > > +5603,13 @@ ixgbe_syn_filter_set(struct rte_eth_dev *dev, > > else > > synqf &=3D ~IXGBE_SYN_FILTER_SYNQFP; > > } else { > > - if (!(synqf & IXGBE_SYN_FILTER_ENABLE)) > > + synqf =3D IXGBE_READ_REG(hw, IXGBE_SYNQF); > > + if (!(syn_info & IXGBE_SYN_FILTER_ENABLE)) > > return -ENOENT; > > synqf &=3D ~(IXGBE_SYN_FILTER_QUEUE | > IXGBE_SYN_FILTER_ENABLE); > > } > > + > > + filter_info->syn_info =3D synqf; > > IXGBE_WRITE_REG(hw, IXGBE_SYNQF, synqf); > > IXGBE_WRITE_FLUSH(hw); > > return 0; > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.h > > b/drivers/net/ixgbe/ixgbe_ethdev.h > > index 4ff6338..827026c 100644 > > --- a/drivers/net/ixgbe/ixgbe_ethdev.h > > +++ b/drivers/net/ixgbe/ixgbe_ethdev.h > > @@ -262,6 +262,8 @@ struct ixgbe_filter_info { > > /* Bit mask for every used 5tuple filter */ > > uint32_t fivetuple_mask[IXGBE_5TUPLE_ARRAY_SIZE]; > > struct ixgbe_5tuple_filter_list fivetuple_list; > > + /* store the SYN filter info */ > > + uint32_t syn_info; > > }; > > > > /* > > -- > > 2.5.5