From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <wei.zhao1@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id D18E01094
 for <dev@dpdk.org>; Tue, 10 Jan 2017 06:47:06 +0100 (CET)
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
 by fmsmga104.fm.intel.com with ESMTP; 09 Jan 2017 21:47:01 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,342,1477983600"; d="scan'208";a="51445030"
Received: from kmsmsx153.gar.corp.intel.com ([172.21.73.88])
 by fmsmga005.fm.intel.com with ESMTP; 09 Jan 2017 21:47:01 -0800
Received: from pgsmsx109.gar.corp.intel.com (10.221.44.109) by
 KMSMSX153.gar.corp.intel.com (172.21.73.88) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Tue, 10 Jan 2017 13:47:00 +0800
Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.52]) by
 PGSMSX109.gar.corp.intel.com ([169.254.14.172]) with mapi id 14.03.0248.002;
 Tue, 10 Jan 2017 13:47:00 +0800
From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v2 13/18] net/ixgbe: parse TCP SYN filter
Thread-Index: AQHSYnKH4yh16ev2w0uyatD+dlddgqErNyKAgAYNiPA=
Date: Tue, 10 Jan 2017 05:46:58 +0000
Message-ID: <A2573D2ACFCADC41BB3BE09C6DE313CA0201E60D@PGSMSX103.gar.corp.intel.com>
References: <1483084390-53159-1-git-send-email-wei.zhao1@intel.com>
 <1483084390-53159-14-git-send-email-wei.zhao1@intel.com>
 <8c0dd569-43e5-8b8c-d411-aef2be616e03@intel.com>
In-Reply-To: <8c0dd569-43e5-8b8c-d411-aef2be616e03@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [172.30.20.205]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 13/18] net/ixgbe: parse TCP SYN filter
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Jan 2017 05:47:07 -0000

Hi, Yigit

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Saturday, January 7, 2017 1:20 AM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v2 13/18] net/ixgbe: parse TCP SYN filter
>=20
> On 12/30/2016 7:53 AM, Wei Zhao wrote:
> > check if the rule is a TCP SYN rule, and get the SYN info.
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> >
> > ---
> >
> > v2:add new error set function
> > ---
>=20
> <...>
>=20
> > +static int
> > +ixgbe_parse_syn_filter(const struct rte_flow_attr *attr,
> > +			     const struct rte_flow_item pattern[],
> > +			     const struct rte_flow_action actions[],
> > +			     struct rte_eth_syn_filter *filter,
> > +			     struct rte_flow_error *error) {
> > +	int ret;
> > +
> > +	ret =3D cons_parse_syn_filter(attr, pattern,
> > +					actions, filter, error);
> > +
>=20
> > +	if (ret)
> > +		return ret;
> > +
> > +	return 0;
>=20
> "return ret;" will do the same.
> Or remove ret completely perhaps.
>=20
> > +}
> > +
> <...>

Yes, "return ret;" may be more appropriate.