From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id BE35A9E3 for ; Thu, 6 Apr 2017 10:53:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1491468796; x=1523004796; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=X6yAG40UQbcEwgGnT9pyyGbwtDEERr4aI9l7g1CntBc=; b=Aa/xu8/vORXqupqbI3P6Eo3jlPU6uThCw0SAvstc0Nc3xBWBuRu9IAON lU4o+Zad+P+c62QY9wEQ5CF+LcWmFg==; Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Apr 2017 01:53:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,283,1488873600"; d="scan'208";a="83823787" Received: from pgsmsx104.gar.corp.intel.com ([10.221.44.91]) by orsmga005.jf.intel.com with ESMTP; 06 Apr 2017 01:53:14 -0700 Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.175]) by PGSMSX104.gar.corp.intel.com ([169.254.3.113]) with mapi id 14.03.0319.002; Thu, 6 Apr 2017 16:53:13 +0800 From: "Zhao1, Wei" To: Thomas Monjalon CC: "Mcnamara, John" , "dev@dpdk.org" , "Lu, Wenzhuo" Thread-Topic: [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support for port reset Thread-Index: AQHSqTm8K6Xc/Z+bh0WPnxNjoB7PqKGtRo6AgAplLjD//8WxAIAAoiDg Date: Thu, 6 Apr 2017 08:53:13 +0000 Message-ID: References: <1490866456-52241-1-git-send-email-wei.zhao1@intel.com> <2969664.trJitADFWx@xps13> <2978037.PdPlo8nOdn@xps13> In-Reply-To: <2978037.PdPlo8nOdn@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support for port reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Apr 2017 08:53:17 -0000 Hi, Thomas > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Thursday, April 6, 2017 3:11 PM > To: Zhao1, Wei > Cc: Mcnamara, John ; dev@dpdk.org; Lu, > Wenzhuo > Subject: Re: [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support for = port > reset >=20 > 2017-04-06 02:57, Zhao1, Wei: > > > /** > > > > + * Reset an ethernet device when it's not working. One scenario > > > > + is, after PF > > > > + * port is down and up, the related VF port should be reset. > > > > + * The API will stop the port, clear the rx/tx queues, re-setup > > > > + the rx/tx > > > > + * queues, restart the port. > > > > > > s/The API/This function/ > > > > > > Please explain exactly the responsibility of this function, and how > > > it is different from calling stop/configure/start. > > > > In this reset feature, reset function can do the calling > > stop/configure/start process, but also It can also do some restore > > work for the port, for example, it can restore the added parameters of > vlan, mac_addrs, promisc_unicast_enabled falg and > promisc_multicast_enabled flag. > > Maybe , I should add this explanation in the patch comments or function > comments? >=20 > Yes it must be explain in the doxygen part of the function. Yes, I have add that explanation in v5 which has been commit to dpdk.org.=20