Re: [dpdk-dev] [PATCH] net/ixgbe: remove tpid check for fdir filter

["Zhao1, Wei" <wei.zhao1@intel.com>]

Hi, Ferruh

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Thursday, April 13, 2017 6:21 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: remove tpid check for fdir filter
> 
> On 4/13/2017 8:49 AM, Wei Zhao wrote:
> > DPDK community has several emails discussion on this topic, these
> > mails name is "FW: Issues with ixgbe and rte_flow",
> 
> Can you please add reference to discussions by mail list archive links.
> Like: http://dpdk.org/ml/archives/dev/2017-April/063942.html
> 

I have got it,  I will fix that in v2

> > items like VLAN can already have several valid "types"
> > (0x88a8, 0x8100, 0x9100), and who knows what will come up in the
> > future.And ixgbe_flow just ignores the types when do filter
> > configuration. So it may be reasonable to delete the related tpid
> > check process.
> > Also add some more comment log on stack explanation.
> >
> > Fixes: 11777435c72 ("net/ixgbe: parse flow director filter")
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> 
> <...>