From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 0A50AF94 for ; Fri, 14 Apr 2017 05:52:10 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Apr 2017 20:52:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,197,1488873600"; d="scan'208";a="956002634" Received: from kmsmsx152.gar.corp.intel.com ([172.21.73.87]) by orsmga003.jf.intel.com with ESMTP; 13 Apr 2017 20:52:08 -0700 Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.175]) by KMSMSX152.gar.corp.intel.com ([169.254.11.200]) with mapi id 14.03.0319.002; Fri, 14 Apr 2017 11:52:08 +0800 From: "Zhao1, Wei" To: "Yigit, Ferruh" , "Zhang, Helin" , "Ananyev, Konstantin" CC: "dev@dpdk.org" , "Lu, Wenzhuo" Thread-Topic: [PATCH] net/ixgbe: fix duplicated check Thread-Index: AQHSstcz5fdAKtrxSUyYJIlmslL5gaHEPsHg Date: Fri, 14 Apr 2017 03:52:06 +0000 Message-ID: References: <20170411152034.23784-1-ferruh.yigit@intel.com> In-Reply-To: <20170411152034.23784-1-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix duplicated check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Apr 2017 03:52:11 -0000 > -----Original Message----- > From: Yigit, Ferruh > Sent: Tuesday, April 11, 2017 11:21 PM > To: Zhang, Helin ; Ananyev, Konstantin > > Cc: dev@dpdk.org; Yigit, Ferruh ; Lu, Wenzhuo > ; Zhao1, Wei > Subject: [PATCH] net/ixgbe: fix duplicated check >=20 > Same check duplicated, updated check according what commend states. >=20 > Coverity issue: 1407507 > Fixes: 11777435c727 ("net/ixgbe: parse flow director filter") >=20 > Signed-off-by: Ferruh Yigit > --- > drivers/net/ixgbe/ixgbe_flow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flo= w.c > index e2ba9c2..803d6f8 100644 > --- a/drivers/net/ixgbe/ixgbe_flow.c > +++ b/drivers/net/ixgbe/ixgbe_flow.c > @@ -2231,7 +2231,7 @@ ixgbe_parse_fdir_filter_tunnel(const struct > rte_flow_attr *attr, > index++; > NEXT_ITEM_OF_PATTERN(item, pattern, index); > if ((item->type !=3D RTE_FLOW_ITEM_TYPE_VLAN) && > - (item->type !=3D RTE_FLOW_ITEM_TYPE_VLAN)) { > + (item->type !=3D RTE_FLOW_ITEM_TYPE_IPV4)) { > memset(rule, 0, sizeof(struct ixgbe_fdir_rule)); > rte_flow_error_set(error, EINVAL, > RTE_FLOW_ERROR_TYPE_ITEM, > -- > 2.9.3 Acked-by Wei Zhao