From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <wei.zhao1@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id DC3F52BAE
 for <dev@dpdk.org>; Mon, 24 Apr 2017 05:39:58 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 23 Apr 2017 20:39:57 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.37,242,1488873600"; d="scan'208";a="1122747317"
Received: from pgsmsx108.gar.corp.intel.com ([10.221.44.103])
 by orsmga001.jf.intel.com with ESMTP; 23 Apr 2017 20:39:56 -0700
Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.175]) by
 PGSMSX108.gar.corp.intel.com ([169.254.8.249]) with mapi id 14.03.0319.002;
 Mon, 24 Apr 2017 11:39:55 +0800
From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>, Thomas Monjalon
 <thomas@monjalon.net>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Ananyev, Konstantin"
 <konstantin.ananyev@intel.com>, "Mcnamara, John" <john.mcnamara@intel.com>,
 "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Liu, Yu Y" <yu.y.liu@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support for
 port reset
Thread-Index: AQHSqTm8K6Xc/Z+bh0WPnxNjoB7PqKGtRo6AgAplLjCAFbSeAIAAugdggACayYCAAGSYgIAAjhsA//+C4oCABDoGAIAAoMyw
Date: Mon, 24 Apr 2017 03:39:54 +0000
Message-ID: <A2573D2ACFCADC41BB3BE09C6DE313CA02080796@PGSMSX103.gar.corp.intel.com>
References: <1490866456-52241-1-git-send-email-wei.zhao1@intel.com>
 <1581788.2CBIGuQB5e@xps>
 <A2573D2ACFCADC41BB3BE09C6DE313CA020803F0@PGSMSX103.gar.corp.intel.com>
 <7495505.68D2QY7hX0@xps> <20170424020120.GC11512@yliu-dev.sh.intel.com>
In-Reply-To: <20170424020120.GC11512@yliu-dev.sh.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [172.30.20.206]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support for
 port reset
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Apr 2017 03:39:59 -0000

Hi, yuanhan & thomas

> -----Original Message-----
> From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
> Sent: Monday, April 24, 2017 10:01 AM
> To: Thomas Monjalon <thomas@monjalon.net>
> Cc: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org; Ananyev,
> Konstantin <konstantin.ananyev@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Liu,
> Yu Y <yu.y.liu@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support for =
port
> reset
>=20
> On Fri, Apr 21, 2017 at 11:28:37AM +0200, Thomas Monjalon wrote:
> > > Maybe I should add some words in doc\guides\nics\i40e.rst to Record
> > > which configurations are  saved  and restored by the PMD driver in
> > > reset function. Which not list in that are recognized as not saved
> > > and restored by default. OTHER  NIC for this feature can add similar
> > > record in their xxx.rst.
> >
> > No, when defining a generic API in ethdev, we must define the same
> > behaviour for every drivers.
>=20
> Agreed. That was my point.
>=20
> 	--yliu
>=20
> > Please check how to make the behaviour consistent and documented in
> > ethdev. We may need to document your new function and start/stop also.

Do you have any suggestion on which document  in rte layer to record store =
and restore info by me?