From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 3C7FD2BF5 for ; Tue, 25 Apr 2017 05:14:53 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP; 24 Apr 2017 20:14:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,247,1488873600"; d="scan'208";a="960691011" Received: from pgsmsx102.gar.corp.intel.com ([10.221.44.80]) by orsmga003.jf.intel.com with ESMTP; 24 Apr 2017 20:14:51 -0700 Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.175]) by PGSMSX102.gar.corp.intel.com ([169.254.6.18]) with mapi id 14.03.0319.002; Tue, 25 Apr 2017 11:14:50 +0800 From: "Zhao1, Wei" To: Thomas Monjalon CC: "dev@dpdk.org" , Yuanhan Liu , "Ananyev, Konstantin" , "Mcnamara, John" , "Lu, Wenzhuo" , "Liu, Yu Y" Thread-Topic: [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support for port reset Thread-Index: AQHSqTm8K6Xc/Z+bh0WPnxNjoB7PqKGtRo6AgAplLjCAFbSeAIAAugdggACayYCAAGSYgIAAjhsA//+C4oCABDoGAIAAoMyw///EuACAAcdP4A== Date: Tue, 25 Apr 2017 03:14:49 +0000 Message-ID: References: <1490866456-52241-1-git-send-email-wei.zhao1@intel.com> <20170424020120.GC11512@yliu-dev.sh.intel.com> <1567270.9lMUqcoftf@xps> In-Reply-To: <1567270.9lMUqcoftf@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support for port reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Apr 2017 03:14:54 -0000 Ok. > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Monday, April 24, 2017 4:05 PM > To: Zhao1, Wei > Cc: dev@dpdk.org; Yuanhan Liu ; Ananyev, > Konstantin ; Mcnamara, John > ; Lu, Wenzhuo ; Liu, > Yu Y > Subject: Re: [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support for = port > reset >=20 > 24/04/2017 05:39, Zhao1, Wei: > > Hi, yuanhan & thomas > > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > > > On Fri, Apr 21, 2017 at 11:28:37AM +0200, Thomas Monjalon wrote: > > > > > Maybe I should add some words in doc\guides\nics\i40e.rst to > > > > > Record which configurations are saved and restored by the PMD > > > > > driver in reset function. Which not list in that are recognized > > > > > as not saved and restored by default. OTHER NIC for this > > > > > feature can add similar record in their xxx.rst. > > > > > > > > No, when defining a generic API in ethdev, we must define the same > > > > behaviour for every drivers. > > > > > > Agreed. That was my point. > > > > > > --yliu > > > > > > > Please check how to make the behaviour consistent and documented > > > > in ethdev. We may need to document your new function and start/stop > also. > > > > Do you have any suggestion on which document in rte layer to record > > store and restore info by me? >=20 > It should be documented in the doxygen comment of the functions. > Either we explain which configuration is restored on start and reset, or = we > state everything (or nothing) is restored except the configurations > commented in the related configuration functions.