Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix ntuple filter support for sctp

["Zhao1, Wei" <wei.zhao1@intel.com>]

Hi，Ferruh

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Thursday, April 27, 2017 5:44 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix ntuple filter support for
> sctp
> 
> On 4/27/2017 6:39 AM, Wei Zhao wrote:
> > Add the support of RTE_FLOW_ITEM_TYPE_SCTP type packet for ixgbe
> > ntuple filter.
> >
> > v2:
> > --add type check of RTE_FLOW_ITEM_TYPE_SCTP for item flow.
> 
> For version information in the commit log, can you put it as:
> Below signed-off tag, in new line put three dashes "---", later put the version
> information. This way git automatically strips that part when applied,
> otherwise maintainer manually needs to do the update.
> 

Ok, fix in v3

> And can you please send new version of the patches using git send-email "--
> in-reply-to" option, otherwise it is hard to trace the patch versions and
> previous comments on it.
> 

Sorry, I have forget that info.

> Thanks.
> 
> >
> > Fixes: 672be56d76a ("net/ixgbe: parse n-tuple filter")
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > ---
> >  drivers/net/ixgbe/ixgbe_flow.c | 30 ++++++++++++++++++++++++++++--
> >  1 file changed, 28 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_flow.c
> > b/drivers/net/ixgbe/ixgbe_flow.c index e2ba9c2..98e414a 100644
> > --- a/drivers/net/ixgbe/ixgbe_flow.c
> > +++ b/drivers/net/ixgbe/ixgbe_flow.c
> > @@ -142,6 +142,8 @@ cons_parse_ntuple_filter(const struct rte_flow_attr
> *attr,
> >  	const struct rte_flow_item_tcp *tcp_mask;
> >  	const struct rte_flow_item_udp *udp_spec;
> >  	const struct rte_flow_item_udp *udp_mask;
> > +	const struct rte_flow_item_sctp *sctp_spec;
> > +	const struct rte_flow_item_sctp *sctp_mask;
> >  	uint32_t index;
> >
> >  	if (!pattern) {
> > @@ -253,7 +255,8 @@ cons_parse_ntuple_filter(const struct rte_flow_attr
> *attr,
> >  	index++;
> >  	NEXT_ITEM_OF_PATTERN(item, pattern, index);
> >  	if (item->type != RTE_FLOW_ITEM_TYPE_TCP &&
> > -	    item->type != RTE_FLOW_ITEM_TYPE_UDP) {
> > +	    item->type != RTE_FLOW_ITEM_TYPE_UDP &&
> > +	    item->type != RTE_FLOW_ITEM_TYPE_SCTP) {
> 
> There is a function comment, that documents the expected/valid pattern
> types, that should be updated with this new type.

Ok, I will fix that in v3.