From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: add queue index check in filter
Date: Wed, 19 Jul 2017 03:50:14 +0000 [thread overview]
Message-ID: <A2573D2ACFCADC41BB3BE09C6DE313CA07C2EE6D@PGSMSX103.gar.corp.intel.com> (raw)
In-Reply-To: <3677ba30-b6de-50eb-a85a-7b19e35c876c@intel.com>
Hi, Ferruh
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Tuesday, July 18, 2017 6:44 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: add queue index check in filter
>
> On 7/17/2017 7:13 AM, Wei Zhao wrote:
> > Add queue index check when create filter rule, or filter with invalid
> > queue id can be created successfully.
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
>
> <...>
>
> > @@ -1177,6 +1178,9 @@ ixgbe_parse_l2_tn_filter(struct rte_eth_dev
> *dev,
> > return -rte_errno;
> > }
> >
> > + if (filter->queue >= dev->data->nb_rx_queues)
> > + return -rte_errno;
> > +
>
> This is giving following build error [1].
>
> [1]
> .../drivers/net/ixgbe/ixgbe_flow.c:1180:6:
> error: use of undeclared identifier 'filter'
> if (filter->queue >= dev->data->nb_rx_queues)
> ^
Thank you, a new v2 patch has been commit to DPDK.org
next prev parent reply other threads:[~2017-07-19 3:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 6:13 Wei Zhao
2017-07-18 10:43 ` Ferruh Yigit
2017-07-19 3:50 ` Zhao1, Wei [this message]
2017-07-19 3:34 ` [dpdk-dev] [PATCH v2] " Wei Zhao
2017-07-19 8:56 ` Ferruh Yigit
2017-11-03 6:40 ` [dpdk-dev] [PATCH v3] net/ixgbe: fix filter parser error in L2 tunnel Wei Zhao
2017-11-03 7:38 ` [dpdk-dev] [PATCH v4] " Wei Zhao
2017-11-03 8:33 ` Peng, Yuan
2017-11-03 8:38 ` Peng, Yuan
2017-11-03 19:11 ` Ferruh Yigit
2017-11-03 18:54 ` Ferruh Yigit
-- strict thread matches above, loose matches on Subject: below --
2017-07-17 6:12 [dpdk-dev] [PATCH] net/ixgbe: add queue index check in filter Wei Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A2573D2ACFCADC41BB3BE09C6DE313CA07C2EE6D@PGSMSX103.gar.corp.intel.com \
--to=wei.zhao1@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).