From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <wei.zhao1@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 45B991B1B2
 for <dev@dpdk.org>; Fri, 29 Sep 2017 07:21:41 +0200 (CEST)
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
 by orsmga105.jf.intel.com with ESMTP; 28 Sep 2017 22:21:40 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.42,451,1500966000"; d="scan'208";a="156862320"
Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78])
 by fmsmga005.fm.intel.com with ESMTP; 28 Sep 2017 22:21:39 -0700
Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.203]) by
 PGSMSX101.gar.corp.intel.com ([169.254.1.141]) with mapi id 14.03.0319.002;
 Fri, 29 Sep 2017 13:21:38 +0800
From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH v5 2/3] app/testpmd: add API for
 configuration of	queue region
Thread-Index: AQHTOOCAlhklfLO4vUOsdNHTSdUUmaLLU7cA
Date: Fri, 29 Sep 2017 05:21:38 +0000
Message-ID: <A2573D2ACFCADC41BB3BE09C6DE313CA07C6A0E4@PGSMSX103.gar.corp.intel.com>
References: <1506589809-59533-1-git-send-email-wei.zhao1@intel.com>
 <1506653786-28970-1-git-send-email-wei.zhao1@intel.com>
 <1506653786-28970-3-git-send-email-wei.zhao1@intel.com>
 <9BB6961774997848B5B42BEC655768F810E83539@SHSMSX103.ccr.corp.intel.com>
In-Reply-To: <9BB6961774997848B5B42BEC655768F810E83539@SHSMSX103.ccr.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-product: dlpe-windows
dlp-version: 11.0.0.116
dlp-reaction: no-action
x-originating-ip: [172.30.20.206]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v5 2/3] app/testpmd: add API for
 configuration of	queue region
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Sep 2017 05:21:41 -0000

Ok.

> -----Original Message-----
> From: Wu, Jingjing
> Sent: Friday, September 29, 2017 1:05 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: Zhao1, Wei <wei.zhao1@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v5 2/3] app/testpmd: add API for
> configuration of queue region
>=20
> General comments:
>=20
> You need to wrap i40e private API by
> #ifdef RTE_LIBRTE_I40E_PMD
> #endif
>=20
> Otherwise it will cause compile error if I40E_PMD is not enable in config=
.
>=20
> You can refer to other implementation like
> cmd_ptype_mapping_get_parsed.
>=20
> Thanks
> Jingjing