From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 2134E1B2C1 for ; Wed, 27 Dec 2017 09:43:20 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Dec 2017 00:43:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,464,1508828400"; d="scan'208";a="14823196" Received: from pgsmsx102.gar.corp.intel.com ([10.221.44.80]) by FMSMGA003.fm.intel.com with ESMTP; 27 Dec 2017 00:43:19 -0800 Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.108]) by PGSMSX102.gar.corp.intel.com ([169.254.6.144]) with mapi id 14.03.0319.002; Wed, 27 Dec 2017 16:43:18 +0800 From: "Zhao1, Wei" To: Ori Kam CC: "Lu, Wenzhuo" , "dev@dpdk.org" Thread-Topic: [PATCH] examples/flow_filtering: add Tx queues setup process Thread-Index: AQHTfiv5q/U95YaTIkq2KJa/7XBXSaNVZODQ//++w4CAAb0BIA== Date: Wed, 27 Dec 2017 08:43:17 +0000 Message-ID: References: <20171226092104.82707-1-wei.zhao1@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] examples/flow_filtering: add Tx queues setup process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Dec 2017 08:43:21 -0000 Hi, Ori Kam Thank you for your suggestion. I have commit a v2 to DPDK.org. https://dpdk.org/dev/patchwork/patch/32768/ > -----Original Message----- > From: Ori Kam [mailto:orika@mellanox.com] > Sent: Tuesday, December 26, 2017 10:09 PM > To: Zhao1, Wei > Cc: Lu, Wenzhuo ; dev@dpdk.org > Subject: RE: [PATCH] examples/flow_filtering: add Tx queues setup process >=20 > Hi Wei, >=20 > Your patch looks good, but there is an ack patch that deals with offloads= . > http://dpdk.org/ml/archives/dev/2017-December/083639.html >=20 > Please update your patch to support the new tx offloads. >=20 > Regards, > Ori >=20 >=20 > > -----Original Message----- > > From: Zhao1, Wei [mailto:wei.zhao1@intel.com] > > Sent: Tuesday, December 26, 2017 12:03 PM > > To: Ori Kam > > Cc: Lu, Wenzhuo ; dev@dpdk.org > > Subject: RE: [PATCH] examples/flow_filtering: add Tx queues setup > > process > > > > Add maintainer orika@mellanox.com into cc list. > > > > > > > -----Original Message----- > > > From: Zhao1, Wei > > > Sent: Tuesday, December 26, 2017 5:21 PM > > > To: dev@dpdk.org > > > Cc: Lu, Wenzhuo ; Zhao1, Wei > > > > > > Subject: [PATCH] examples/flow_filtering: add Tx queues setup > > > process > > > > > > This example do not has the process of set up tx queues, but some > > > NIC start up process will be blocked if this is no tx queue and only > > > rx queues. So add tx queues setup process in main code. > > > > > > Signed-off-by: Wei Zhao > > > --- > > > examples/flow_filtering/main.c | 11 +++++++++++ > > > 1 file changed, 11 insertions(+) > > > > > > diff --git a/examples/flow_filtering/main.c > > > b/examples/flow_filtering/main.c index 7d739b4..b5c7677 100644 > > > --- a/examples/flow_filtering/main.c > > > +++ b/examples/flow_filtering/main.c > > > @@ -173,6 +173,17 @@ init_port(void) > > > } > > > } > > > > > > + for (i =3D 0; i < nr_queues; i++) { > > > + ret =3D rte_eth_tx_queue_setup(port_id, i, 512, > > > + rte_eth_dev_socket_id(port_id), > > > + NULL); > > > + if (ret < 0) { > > > + rte_exit(EXIT_FAILURE, > > > + ":: Tx queue setup failed: err=3D%d, > > > port=3D%u\n", > > > + ret, port_id); > > > + } > > > + } > > > + > > > rte_eth_promiscuous_enable(port_id); > > > ret =3D rte_eth_dev_start(port_id); > > > if (ret < 0) { > > > -- > > > 2.9.3